Message ID | 20230731215310.3949441-2-charlie.johnston@ni.com |
---|---|
State | New |
Headers | show |
Series | Add new packagefeed recipe class. | expand |
As these directories will be written into by multiple recipes that use the packagefeed class, won't they race and step on each other? Should there be a ${PN} in these definitions? Alex On Mon, 31 Jul 2023 at 23:53, Charlie Johnston <charlie.johnston@ni.com> wrote: > > This change adds a new variable that defines where > feeds should be created when building a packagefeed. > A feed location for each package type is also added > to allow multiple package type feeds to be created > in parallel. > > The location is ${DEPLOY_DIR}/feeds/<pkg_type> > > Signed-off-by: Charlie Johnston <charlie.johnston@ni.com> > --- > meta/conf/bitbake.conf | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 8daaaad615..fd1738069f 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -450,6 +450,10 @@ DEPLOY_DIR_RPM = "${DEPLOY_DIR}/rpm" > DEPLOY_DIR_DEB = "${DEPLOY_DIR}/deb" > DEPLOY_DIR_IMAGE ?= "${DEPLOY_DIR}/images/${MACHINE}" > DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools" > +DEPLOY_DIR_FEED ?= "${DEPLOY_DIR}/feeds/" > +DEPLOY_DIR_FEED_IPK = "${DEPLOY_DIR_FEED}/ipk" > +DEPLOY_DIR_FEED_RPM = "${DEPLOY_DIR_FEED}/rpm" > +DEPLOY_DIR_FEED_DEB = "${DEPLOY_DIR_FEED}/deb" > > PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}" > PKGDATA_DIR_SDK = "${TMPDIR}/pkgdata/${SDK_SYS}" > -- > 2.41.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#185175): https://lists.openembedded.org/g/openembedded-core/message/185175 > Mute This Topic: https://lists.openembedded.org/mt/100471799/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Ah, good idea. I had the bbclass adding the ${PN} but it definitely makes more sense here. Is it worth it to add [lockfiles] for each package type's directory? Or maybe one at the top level "feeds" location? Thanks! Charlie Johnston On 8/1/23 05:25, Alexander Kanavin wrote: > As these directories will be written into by multiple recipes that use > the packagefeed class, won't they race and step on each other? Should > there be a ${PN} in these definitions? > > Alex > > On Mon, 31 Jul 2023 at 23:53, Charlie Johnston <charlie.johnston@ni.com> wrote: >> >> This change adds a new variable that defines where >> feeds should be created when building a packagefeed. >> A feed location for each package type is also added >> to allow multiple package type feeds to be created >> in parallel. >> >> The location is ${DEPLOY_DIR}/feeds/<pkg_type> >> >> Signed-off-by: Charlie Johnston <charlie.johnston@ni.com> >> --- >> meta/conf/bitbake.conf | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 8daaaad615..fd1738069f 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -450,6 +450,10 @@ DEPLOY_DIR_RPM = "${DEPLOY_DIR}/rpm" >> DEPLOY_DIR_DEB = "${DEPLOY_DIR}/deb" >> DEPLOY_DIR_IMAGE ?= "${DEPLOY_DIR}/images/${MACHINE}" >> DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools" >> +DEPLOY_DIR_FEED ?= "${DEPLOY_DIR}/feeds/" >> +DEPLOY_DIR_FEED_IPK = "${DEPLOY_DIR_FEED}/ipk" >> +DEPLOY_DIR_FEED_RPM = "${DEPLOY_DIR_FEED}/rpm" >> +DEPLOY_DIR_FEED_DEB = "${DEPLOY_DIR_FEED}/deb" >> >> PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}" >> PKGDATA_DIR_SDK = "${TMPDIR}/pkgdata/${SDK_SYS}" >> -- >> 2.41.0 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#185175): https://lists.openembedded.org/g/openembedded-core/message/185175 >> Mute This Topic: https://lists.openembedded.org/mt/100471799/1686489 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
I don't know about lockfiles, so your call. Investigate how it's used elsewhere in poky. Alex On Tue, 1 Aug 2023 at 18:18, Charlie Johnston <charlie.johnston@ni.com> wrote: > > Ah, good idea. I had the bbclass adding the ${PN} but it definitely > makes more sense here. > > Is it worth it to add [lockfiles] for each package type's directory? > Or maybe one at the top level "feeds" location? > > Thanks! > Charlie Johnston > > On 8/1/23 05:25, Alexander Kanavin wrote: > > As these directories will be written into by multiple recipes that use > > the packagefeed class, won't they race and step on each other? Should > > there be a ${PN} in these definitions? > > > > Alex > > > > On Mon, 31 Jul 2023 at 23:53, Charlie Johnston <charlie.johnston@ni.com> wrote: > >> > >> This change adds a new variable that defines where > >> feeds should be created when building a packagefeed. > >> A feed location for each package type is also added > >> to allow multiple package type feeds to be created > >> in parallel. > >> > >> The location is ${DEPLOY_DIR}/feeds/<pkg_type> > >> > >> Signed-off-by: Charlie Johnston <charlie.johnston@ni.com> > >> --- > >> meta/conf/bitbake.conf | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > >> index 8daaaad615..fd1738069f 100644 > >> --- a/meta/conf/bitbake.conf > >> +++ b/meta/conf/bitbake.conf > >> @@ -450,6 +450,10 @@ DEPLOY_DIR_RPM = "${DEPLOY_DIR}/rpm" > >> DEPLOY_DIR_DEB = "${DEPLOY_DIR}/deb" > >> DEPLOY_DIR_IMAGE ?= "${DEPLOY_DIR}/images/${MACHINE}" > >> DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools" > >> +DEPLOY_DIR_FEED ?= "${DEPLOY_DIR}/feeds/" > >> +DEPLOY_DIR_FEED_IPK = "${DEPLOY_DIR_FEED}/ipk" > >> +DEPLOY_DIR_FEED_RPM = "${DEPLOY_DIR_FEED}/rpm" > >> +DEPLOY_DIR_FEED_DEB = "${DEPLOY_DIR_FEED}/deb" > >> > >> PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}" > >> PKGDATA_DIR_SDK = "${TMPDIR}/pkgdata/${SDK_SYS}" > >> -- > >> 2.41.0 > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- > >> Links: You receive all messages sent to this group. > >> View/Reply Online (#185175): https://lists.openembedded.org/g/openembedded-core/message/185175 > >> Mute This Topic: https://lists.openembedded.org/mt/100471799/1686489 > >> Group Owner: openembedded-core+owner@lists.openembedded.org > >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > >> -=-=-=-=-=-=-=-=-=-=-=- > >> >
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 8daaaad615..fd1738069f 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -450,6 +450,10 @@ DEPLOY_DIR_RPM = "${DEPLOY_DIR}/rpm" DEPLOY_DIR_DEB = "${DEPLOY_DIR}/deb" DEPLOY_DIR_IMAGE ?= "${DEPLOY_DIR}/images/${MACHINE}" DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools" +DEPLOY_DIR_FEED ?= "${DEPLOY_DIR}/feeds/" +DEPLOY_DIR_FEED_IPK = "${DEPLOY_DIR_FEED}/ipk" +DEPLOY_DIR_FEED_RPM = "${DEPLOY_DIR_FEED}/rpm" +DEPLOY_DIR_FEED_DEB = "${DEPLOY_DIR_FEED}/deb" PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}" PKGDATA_DIR_SDK = "${TMPDIR}/pkgdata/${SDK_SYS}"
This change adds a new variable that defines where feeds should be created when building a packagefeed. A feed location for each package type is also added to allow multiple package type feeds to be created in parallel. The location is ${DEPLOY_DIR}/feeds/<pkg_type> Signed-off-by: Charlie Johnston <charlie.johnston@ni.com> --- meta/conf/bitbake.conf | 4 ++++ 1 file changed, 4 insertions(+)