[bitbake-devel] knotty2: return exit code

Submitted by Enrico Scholz on May 19, 2012, 9:59 a.m.

Details

Message ID 1337421593-24163-1-git-send-email-enrico.scholz@sigma-chemnitz.de
State Accepted
Commit 243e4ba405b88fd466bec7b4aa042d20aa6121ff
Headers show

Commit Message

Enrico Scholz May 19, 2012, 9:59 a.m.
From: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de>

'bitbake -u knotty2' never failed which was caused by main() not
propagating the exit code.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 lib/bb/ui/knotty2.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox

diff --git a/lib/bb/ui/knotty2.py b/lib/bb/ui/knotty2.py
index aa6a408..65e941b 100644
--- a/lib/bb/ui/knotty2.py
+++ b/lib/bb/ui/knotty2.py
@@ -106,4 +106,4 @@  class TerminalFilter2(object):
             self.termios.tcsetattr(fd, self.termios.TCSADRAIN, self.stdinbackup)
 
 def main(server, eventHandler):
-    bb.ui.knotty.main(server, eventHandler, TerminalFilter2)
+    return bb.ui.knotty.main(server, eventHandler, TerminalFilter2)

Comments

Richard Purdie May 20, 2012, 7:10 a.m.
On Sat, 2012-05-19 at 11:59 +0200, Enrico Scholz wrote:
> From: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de>
> 
> 'bitbake -u knotty2' never failed which was caused by main() not
> propagating the exit code.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
>  lib/bb/ui/knotty2.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard