Message ID | 20230622103445.31114-2-r-gunasekaran@ti.com |
---|---|
State | Superseded |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | Add meta-sysrepo recipes | expand |
On Thu, Jun 22, 2023 at 04:04:43PM +0530, Ravi Gunasekaran wrote: > Update the checksum values for nw-configurator Why? It is always "why?" question you should answer in the commit log. Everyone can see in the patch itself "what?" you are changing - license checksum - and "where?" you are changing it - in nw-configurator. Moreover, any license change when the checksum differs should be explicitly explained to track any re-licensing due to legal reasons. > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > .../recipes-sysrepo/nw-configurator/nw-configurator.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb > index 5a152017..b8a93f1c 100644 > --- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb > +++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb > @@ -1,6 +1,6 @@ > LICENSE="GPLv2" > DESCRIPTION = "Sysrepo based repo to configure EST" > -LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4" > +LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=f2ec672593c3707bb4fe68307dbf0506" Since you are using a source file for license checksum, you might want to limit it to the license text only, so code changes won't affect the checksum. Use beginline=x and endline=y, e.g.: https://git.yoctoproject.org/meta-ti/tree/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb#n4 > SRC_URI = "file://nw-configurator.c" > > -- > 2.17.1
On 6/22/23 9:26 PM, Denys Dmytriyenko wrote: > On Thu, Jun 22, 2023 at 04:04:43PM +0530, Ravi Gunasekaran wrote: >> Update the checksum values for nw-configurator > > Why? > > It is always "why?" question you should answer in the commit log. Everyone > can see in the patch itself "what?" you are changing - license checksum - > and "where?" you are changing it - in nw-configurator. > > Moreover, any license change when the checksum differs should be explicitly > explained to track any re-licensing due to legal reasons. > > >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> .../recipes-sysrepo/nw-configurator/nw-configurator.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb >> index 5a152017..b8a93f1c 100644 >> --- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb >> +++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb >> @@ -1,6 +1,6 @@ >> LICENSE="GPLv2" >> DESCRIPTION = "Sysrepo based repo to configure EST" >> -LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4" >> +LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=f2ec672593c3707bb4fe68307dbf0506" > > Since you are using a source file for license checksum, you might want to > limit it to the license text only, so code changes won't affect the checksum. > Use beginline=x and endline=y, e.g.: > https://git.yoctoproject.org/meta-ti/tree/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb#n4 Thanks for sharing the reference. I will update accordingly > > >> SRC_URI = "file://nw-configurator.c" >> >> -- >> 2.17.1
diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb index 5a152017..b8a93f1c 100644 --- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb +++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb @@ -1,6 +1,6 @@ LICENSE="GPLv2" DESCRIPTION = "Sysrepo based repo to configure EST" -LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4" +LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=f2ec672593c3707bb4fe68307dbf0506" SRC_URI = "file://nw-configurator.c"
Update the checksum values for nw-configurator Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> --- .../recipes-sysrepo/nw-configurator/nw-configurator.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)