| Message ID | 20230616221010.18458-2-reatmon@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,kirkstone,1/2] python3-pybind11: Backport from meta-openembedded master | expand |
Renable? Otherwise LGTM On Fri, Jun 16, 2023 at 05:10:10PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > With the pybind11 backport, the kms++ package builds correctly. Turn it > back on. > > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > .../recipes-core/packagegroups/packagegroup-arago-base.bb | 3 +-- > meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > index 31d9ad5b..ff32112a 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb > @@ -26,8 +26,6 @@ ARAGO_BASE = "\ > libgpiod-tools \ > " > > -# these require meta-openembedded/meta-oe layer > -# kms++-python is not provided yet > ARAGO_EXTRA = "\ > devmem2 \ > tcpdump \ > @@ -35,6 +33,7 @@ ARAGO_EXTRA = "\ > dropbear \ > openssh-sftp-server \ > kms++ \ > + kms++-python \ > can-utils \ > docker \ > " > diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > index eb39736c..2c0abaa7 100644 > --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" > > DEPENDS = "drm fmt" > > -# New meson build system fails to find pybind11 in sysroot, disable for now > -#DEPENDS += "python3-pybind11" > -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > +DEPENDS += "libevdev python3-pybind11" > +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > > PACKAGES =+ "${PN}-python"
I'll fix that. I decided to split the second patch. Fix kms++ with pybind. and then add kms++-python back in. That patch might be applicable to master as it should be the same patch. The first two would be kirkstone only. On 6/16/2023 5:24 PM, Denys Dmytriyenko wrote: > Renable? > > Otherwise LGTM > > > On Fri, Jun 16, 2023 at 05:10:10PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> With the pybind11 backport, the kms++ package builds correctly. Turn it >> back on. >> >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> .../recipes-core/packagegroups/packagegroup-arago-base.bb | 3 +-- >> meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> index 31d9ad5b..ff32112a 100644 >> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb >> @@ -26,8 +26,6 @@ ARAGO_BASE = "\ >> libgpiod-tools \ >> " >> >> -# these require meta-openembedded/meta-oe layer >> -# kms++-python is not provided yet >> ARAGO_EXTRA = "\ >> devmem2 \ >> tcpdump \ >> @@ -35,6 +33,7 @@ ARAGO_EXTRA = "\ >> dropbear \ >> openssh-sftp-server \ >> kms++ \ >> + kms++-python \ >> can-utils \ >> docker \ >> " >> diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> index eb39736c..2c0abaa7 100644 >> --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" >> >> DEPENDS = "drm fmt" >> >> -# New meson build system fails to find pybind11 in sysroot, disable for now >> -#DEPENDS += "python3-pybind11" >> -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >> +DEPENDS += "libevdev python3-pybind11" >> +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >> >> PACKAGES =+ "${PN}-python"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb index 31d9ad5b..ff32112a 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb @@ -26,8 +26,6 @@ ARAGO_BASE = "\ libgpiod-tools \ " -# these require meta-openembedded/meta-oe layer -# kms++-python is not provided yet ARAGO_EXTRA = "\ devmem2 \ tcpdump \ @@ -35,6 +33,7 @@ ARAGO_EXTRA = "\ dropbear \ openssh-sftp-server \ kms++ \ + kms++-python \ can-utils \ docker \ " diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb index eb39736c..2c0abaa7 100644 --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" DEPENDS = "drm fmt" -# New meson build system fails to find pybind11 in sysroot, disable for now -#DEPENDS += "python3-pybind11" -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" +DEPENDS += "libevdev python3-pybind11" +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" PACKAGES =+ "${PN}-python"
With the pybind11 backport, the kms++ package builds correctly. Turn it back on. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- .../recipes-core/packagegroups/packagegroup-arago-base.bb | 3 +-- meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-)