Message ID | 20230525121357.245812-1-ross.burton@arm.com |
---|---|
State | Under Review |
Headers | show |
Series | [01/14] libpeas: requires gobject-introspection-data DISTRO_FEATURE | expand |
There is this line already from your previous patch: https://lists.openembedded.org/g/openembedded-devel/message/102683 On Thu, May 25, 2023 at 2:14 PM Ross Burton <ross.burton@arm.com> wrote: > From: Ross Burton <ross.burton@arm.com> > > Until libpeas 2 is released, g-i is a hard requirement. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb > b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb > index 3bc975a6fa..1e3b0021c3 100644 > --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb > +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb > @@ -11,6 +11,8 @@ GTKDOC_MESON_OPTION = "gtk_doc" > inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache > features_check > > ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" > +# FIXME: When upgrading to libpeas 2, g-i is no longer needed. > +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data" > > SRC_URI += > "file://0001-Remove-builddir-and-srcdir-paths-from-test-binaries.patch" > SRC_URI[archive.sha256sum] = > "297cb9c2cccd8e8617623d1a3e8415b4530b8e5a893e3527bbfd1edd13237b4c" > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#102844): > https://lists.openembedded.org/g/openembedded-devel/message/102844 > Mute This Topic: https://lists.openembedded.org/mt/99128559/3617156 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > Martin.Jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Thu, May 25, 2023 at 11:14 PM Martin Jansa <Martin.Jansa@gmail.com> wrote: > > There is this line already from your previous patch: > https://lists.openembedded.org/g/openembedded-devel/message/102683 Good catch, I took the comment piece in though and dropped the duplicate setting. > > On Thu, May 25, 2023 at 2:14 PM Ross Burton <ross.burton@arm.com> wrote: >> >> From: Ross Burton <ross.burton@arm.com> >> >> Until libpeas 2 is released, g-i is a hard requirement. >> >> Signed-off-by: Ross Burton <ross.burton@arm.com> >> --- >> meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb >> index 3bc975a6fa..1e3b0021c3 100644 >> --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb >> +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb >> @@ -11,6 +11,8 @@ GTKDOC_MESON_OPTION = "gtk_doc" >> inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check >> >> ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" >> +# FIXME: When upgrading to libpeas 2, g-i is no longer needed. >> +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data" >> >> SRC_URI += "file://0001-Remove-builddir-and-srcdir-paths-from-test-binaries.patch" >> SRC_URI[archive.sha256sum] = "297cb9c2cccd8e8617623d1a3e8415b4530b8e5a893e3527bbfd1edd13237b4c" >> -- >> 2.34.1 >> >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#102862): https://lists.openembedded.org/g/openembedded-devel/message/102862 > Mute This Topic: https://lists.openembedded.org/mt/99128559/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb index 3bc975a6fa..1e3b0021c3 100644 --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.36.0.bb @@ -11,6 +11,8 @@ GTKDOC_MESON_OPTION = "gtk_doc" inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" +# FIXME: When upgrading to libpeas 2, g-i is no longer needed. +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data" SRC_URI += "file://0001-Remove-builddir-and-srcdir-paths-from-test-binaries.patch" SRC_URI[archive.sha256sum] = "297cb9c2cccd8e8617623d1a3e8415b4530b8e5a893e3527bbfd1edd13237b4c"