python3-prompt-toolkit1: Add latest 1.0 version

Message ID 0e2f97993408ba72440a4fa2677b17719a2b141d.1642019865.git.esben.haabendal@huawei.com
State New
Headers show
Series python3-prompt-toolkit1: Add latest 1.0 version | expand

Commit Message

esben.haabendal@huawei.com Jan. 12, 2022, 8:39 p.m. UTC
From: Esben Haabendal <esben.haabendal@huawei.com>

Old major version with different API (than 3.0) for use by recipes that is
still relying on that.

Signed-off-by: Esben Haabendal <esben.haabendal@huawei.com>
---
 .../python/python3-prompt-toolkit1_1.0.15.bb  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb

Comments

Khem Raj Jan. 13, 2022, 3:22 a.m. UTC | #1
On 1/12/22 12:39 PM, Esben Haabendal wrote:
> From: Esben Haabendal <esben.haabendal@huawei.com>
> 
> Old major version with different API (than 3.0) for use by recipes that is
> still relying on that.
> 
> Signed-off-by: Esben Haabendal <esben.haabendal@huawei.com>
> ---
>   .../python/python3-prompt-toolkit1_1.0.15.bb  | 22 +++++++++++++++++++
>   1 file changed, 22 insertions(+)
>   create mode 100644 meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
> 
> diff --git a/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
> new file mode 100644
> index 000000000000..a7a9bcf8c269
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "Library for building powerful interactive command lines in Python (version 1.0)"
> +HOMEPAGE = "https://python-prompt-toolkit.readthedocs.io/"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b2cde7da89f0c1f3e49bf968d00d554f"
> +
> +SRC_URI[sha256sum] = "858588f1983ca497f1cf4ffde01d978a3ea02b01c8a26a8bbc5cd2e66d816917"
> +
> +inherit pypi setuptools3
> +
> +PYPI_PACKAGE = "prompt_toolkit"
> +
> +RDEPENDS:${PN} += " \
> +    ${PYTHON_PN}-core \
> +    ${PYTHON_PN}-six \
> +    ${PYTHON_PN}-terminal \
> +    ${PYTHON_PN}-threading \
> +    ${PYTHON_PN}-wcwidth \
> +    ${PYTHON_PN}-datetime \
> +    ${PYTHON_PN}-shell \
> +"
> +
> +BBCLASSEXTEND = "native nativesdk"
> 
> 

I am not sure if we should add a version which has been deprecated 
upstream and moreover we dont have any other recipes needing this old 
version, 1.0.15 was released in 2017. Perhaps its better to promote 
folks to migrate to 3.x version.

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#94797): https://lists.openembedded.org/g/openembedded-devel/message/94797
> Mute This Topic: https://lists.openembedded.org/mt/88382434/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Esben Haabendal Jan. 17, 2022, 8:01 a.m. UTC | #2
"Khem Raj" <raj.khem@gmail.com> writes:

> On 1/12/22 12:39 PM, Esben Haabendal wrote:
>> From: Esben Haabendal <esben.haabendal@huawei.com>
>> Old major version with different API (than 3.0) for use by recipes that is
>> still relying on that.
>> Signed-off-by: Esben Haabendal <esben.haabendal@huawei.com>
>> ---
>>   .../python/python3-prompt-toolkit1_1.0.15.bb  | 22 +++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>   create mode 100644
>> meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
>> diff --git
>> a/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
>> b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
>> new file mode 100644
>> index 000000000000..a7a9bcf8c269
>> --- /dev/null
>> +++ b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
>> @@ -0,0 +1,22 @@
>> +SUMMARY = "Library for building powerful interactive command lines in
>> Python (version 1.0)"
>> +HOMEPAGE = "https://python-prompt-toolkit.readthedocs.io/"
>> +LICENSE = "BSD-3-Clause"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b2cde7da89f0c1f3e49bf968d00d554f"
>> +
>> +SRC_URI[sha256sum] = "858588f1983ca497f1cf4ffde01d978a3ea02b01c8a26a8bbc5cd2e66d816917"
>> +
>> +inherit pypi setuptools3
>> +
>> +PYPI_PACKAGE = "prompt_toolkit"
>> +
>> +RDEPENDS:${PN} += " \
>> +    ${PYTHON_PN}-core \
>> +    ${PYTHON_PN}-six \
>> +    ${PYTHON_PN}-terminal \
>> +    ${PYTHON_PN}-threading \
>> +    ${PYTHON_PN}-wcwidth \
>> +    ${PYTHON_PN}-datetime \
>> +    ${PYTHON_PN}-shell \
>> +"
>> +
>> +BBCLASSEXTEND = "native nativesdk"
>> 
>
> I am not sure if we should add a version which has been deprecated upstream
> and moreover we dont have any other recipes needing this old version, 1.0.15
> was released in 2017. Perhaps its better to promote folks to migrate to 3.x
> version.

I am not entirely sure that it is deprecated.  I have not seen any such
declaration from upstream.

Of-course, with latest 1.0 release (1.0.18, sorry about sending a patch
with an outdated version) in October 2019, it could very well seem
deprecated.  But it could also just be in minimal maintenance mode.
Version 1.0.18 seems to work with latest Python version.

Anyway, I am fine keeping this recipe in the layer where I have the
recipe needing it.  I just thought that other people could maybe benefit
from having it readily available.

/Esben

Patch

diff --git a/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
new file mode 100644
index 000000000000..a7a9bcf8c269
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python3-prompt-toolkit1_1.0.15.bb
@@ -0,0 +1,22 @@ 
+SUMMARY = "Library for building powerful interactive command lines in Python (version 1.0)"
+HOMEPAGE = "https://python-prompt-toolkit.readthedocs.io/"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=b2cde7da89f0c1f3e49bf968d00d554f"
+
+SRC_URI[sha256sum] = "858588f1983ca497f1cf4ffde01d978a3ea02b01c8a26a8bbc5cd2e66d816917"
+
+inherit pypi setuptools3
+
+PYPI_PACKAGE = "prompt_toolkit"
+
+RDEPENDS:${PN} += " \
+    ${PYTHON_PN}-core \
+    ${PYTHON_PN}-six \
+    ${PYTHON_PN}-terminal \
+    ${PYTHON_PN}-threading \
+    ${PYTHON_PN}-wcwidth \
+    ${PYTHON_PN}-datetime \
+    ${PYTHON_PN}-shell \
+"
+
+BBCLASSEXTEND = "native nativesdk"