[10/14] epiphany: make libportal optional, and move it to meta-oe

Message ID 20220109222732.2252416-10-alex@linutronix.de
State Accepted, archived
Commit f87993a918f3087284ac7f1d96701c7bfbbef725
Headers show
Series [01/14] python3: drop unneeded multiprocessing module patch | expand

Commit Message

Alexander Kanavin Jan. 9, 2022, 10:27 p.m. UTC
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/conf/distro/include/maintainers.inc      |  1 -
 meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
 meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
 3 files changed, 1 insertion(+), 19 deletions(-)
 delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb

Comments

Khem Raj Jan. 10, 2022, 6:43 p.m. UTC | #1
seeing this error

https://errors.yoctoproject.org/Errors/Details/621908/

On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/conf/distro/include/maintainers.inc      |  1 -
>  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
>  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
>  3 files changed, 1 insertion(+), 19 deletions(-)
>  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
>
> diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> index 0af6974a3d..ab7915482a 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <yi.zhao@windriver.com>"
>  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <unassigned@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
>  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
> -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
>  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <alex.kanavin@gmail.com>"
> diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> index 8f3bd87340..a64cdefd86 100644
> --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> @@ -15,7 +15,6 @@ DEPENDS = " \
>            libarchive \
>            libdazzle \
>            libhandy \
> -          libportal \
>            glib-2.0-native \
>            "
>
> @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
>  PACKAGECONFIG[developer-mode] = "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
>  PACKAGECONFIG[soup2] = "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
>  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
> +PACKAGECONFIG[libportal] = "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
>
>  FILES:${PN} += "${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
>  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme gsettings-desktop-schemas"
> diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb b/meta/recipes-gnome/libportal/libportal_0.5.bb
> deleted file mode 100644
> index 67f63fea68..0000000000
> --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak portals."
> -DESCRIPTION = "It provides simple asynchronous wrappers for most Flatpak portals \
> -with a familiar GObject API along side the D-Bus API"
> -HOMEPAGE = "https://github.com/flatpak/libportal"
> -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
> -LICENSE = "LGPLv3"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
> -
> -SRC_URI = "git://github.com/flatpak/${BPN}.git;protocol=https;branch=master"
> -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
> -S = "${WORKDIR}/git"
> -
> -inherit meson gtk-doc gobject-introspection
> -
> -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
> -
> -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
> --
> 2.20.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160313): https://lists.openembedded.org/g/openembedded-core/message/160313
> Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Alexander Kanavin Jan. 10, 2022, 6:49 p.m. UTC | #2
Was this patch included in the build?

Alex

On Mon, 10 Jan 2022 at 19:43, Khem Raj <raj.khem@gmail.com> wrote:

> seeing this error
>
> https://errors.yoctoproject.org/Errors/Details/621908/
>
> On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <alex.kanavin@gmail.com>
> wrote:
> >
> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> > ---
> >  meta/conf/distro/include/maintainers.inc      |  1 -
> >  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
> >  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
> >  3 files changed, 1 insertion(+), 19 deletions(-)
> >  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
> >
> > diff --git a/meta/conf/distro/include/maintainers.inc
> b/meta/conf/distro/include/maintainers.inc
> > index 0af6974a3d..ab7915482a 100644
> > --- a/meta/conf/distro/include/maintainers.inc
> > +++ b/meta/conf/distro/include/maintainers.inc
> > @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <
> yi.zhao@windriver.com>"
> >  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <
> unassigned@yoctoproject.org>"
> >  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
> >  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
> > -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
> >  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> > diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> > index 8f3bd87340..a64cdefd86 100644
> > --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> > +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> > @@ -15,7 +15,6 @@ DEPENDS = " \
> >            libarchive \
> >            libdazzle \
> >            libhandy \
> > -          libportal \
> >            glib-2.0-native \
> >            "
> >
> > @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
> >  PACKAGECONFIG[developer-mode] =
> "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
> >  PACKAGECONFIG[soup2] =
> "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
> >  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
> > +PACKAGECONFIG[libportal] =
> "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
> >
> >  FILES:${PN} += "${datadir}/dbus-1
> ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
> >  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme
> gsettings-desktop-schemas"
> > diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb
> b/meta/recipes-gnome/libportal/libportal_0.5.bb
> > deleted file mode 100644
> > index 67f63fea68..0000000000
> > --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
> > +++ /dev/null
> > @@ -1,17 +0,0 @@
> > -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak
> portals."
> > -DESCRIPTION = "It provides simple asynchronous wrappers for most
> Flatpak portals \
> > -with a familiar GObject API along side the D-Bus API"
> > -HOMEPAGE = "https://github.com/flatpak/libportal"
> > -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
> > -LICENSE = "LGPLv3"
> > -LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
> > -
> > -SRC_URI = "git://
> github.com/flatpak/${BPN}.git;protocol=https;branch=master
> <http://github.com/flatpak/$%7BBPN%7D.git;protocol=https;branch=master>"
> > -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
> > -S = "${WORKDIR}/git"
> > -
> > -inherit meson gtk-doc gobject-introspection
> > -
> > -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
> > -
> > -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
> > --
> > 2.20.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#160313):
> https://lists.openembedded.org/g/openembedded-core/message/160313
> > Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
Khem Raj Jan. 10, 2022, 6:57 p.m. UTC | #3
On Mon, Jan 10, 2022 at 10:49 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Was this patch included in the build?

I had included the meta-oe patch that you posted for sure. I am also
seeing failing build with similar errors for nautilus see
https://errors.yoctoproject.org/Errors/Details/621931/

>
> Alex
>
> On Mon, 10 Jan 2022 at 19:43, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> seeing this error
>>
>> https://errors.yoctoproject.org/Errors/Details/621908/
>>
>> On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>> >
>> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
>> > ---
>> >  meta/conf/distro/include/maintainers.inc      |  1 -
>> >  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
>> >  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
>> >  3 files changed, 1 insertion(+), 19 deletions(-)
>> >  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
>> >
>> > diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
>> > index 0af6974a3d..ab7915482a 100644
>> > --- a/meta/conf/distro/include/maintainers.inc
>> > +++ b/meta/conf/distro/include/maintainers.inc
>> > @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <yi.zhao@windriver.com>"
>> >  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <unassigned@yoctoproject.org>"
>> >  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
>> >  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
>> > -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> >  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
>> >  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> >  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> > diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> > index 8f3bd87340..a64cdefd86 100644
>> > --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> > +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> > @@ -15,7 +15,6 @@ DEPENDS = " \
>> >            libarchive \
>> >            libdazzle \
>> >            libhandy \
>> > -          libportal \
>> >            glib-2.0-native \
>> >            "
>> >
>> > @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
>> >  PACKAGECONFIG[developer-mode] = "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
>> >  PACKAGECONFIG[soup2] = "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
>> >  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
>> > +PACKAGECONFIG[libportal] = "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
>> >
>> >  FILES:${PN} += "${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
>> >  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme gsettings-desktop-schemas"
>> > diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb b/meta/recipes-gnome/libportal/libportal_0.5.bb
>> > deleted file mode 100644
>> > index 67f63fea68..0000000000
>> > --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
>> > +++ /dev/null
>> > @@ -1,17 +0,0 @@
>> > -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak portals."
>> > -DESCRIPTION = "It provides simple asynchronous wrappers for most Flatpak portals \
>> > -with a familiar GObject API along side the D-Bus API"
>> > -HOMEPAGE = "https://github.com/flatpak/libportal"
>> > -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
>> > -LICENSE = "LGPLv3"
>> > -LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
>> > -
>> > -SRC_URI = "git://github.com/flatpak/${BPN}.git;protocol=https;branch=master"
>> > -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
>> > -S = "${WORKDIR}/git"
>> > -
>> > -inherit meson gtk-doc gobject-introspection
>> > -
>> > -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
>> > -
>> > -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
>> > --
>> > 2.20.1
>> >
>> >
>> > -=-=-=-=-=-=-=-=-=-=-=-
>> > Links: You receive all messages sent to this group.
>> > View/Reply Online (#160313): https://lists.openembedded.org/g/openembedded-core/message/160313
>> > Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
>> > Group Owner: openembedded-core+owner@lists.openembedded.org
>> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
>> > -=-=-=-=-=-=-=-=-=-=-=-
>> >
Alexander Kanavin Jan. 10, 2022, 7:18 p.m. UTC | #4
For epiphany you also need the oe-core patch. Nautilus should switch to an
optional dependency via PACKAGECONFIG, similar to epiphany.

Alex

On Mon, 10 Jan 2022 at 19:57, Khem Raj <raj.khem@gmail.com> wrote:

> On Mon, Jan 10, 2022 at 10:49 AM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > Was this patch included in the build?
>
> I had included the meta-oe patch that you posted for sure. I am also
> seeing failing build with similar errors for nautilus see
> https://errors.yoctoproject.org/Errors/Details/621931/
>
> >
> > Alex
> >
> > On Mon, 10 Jan 2022 at 19:43, Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> seeing this error
> >>
> >> https://errors.yoctoproject.org/Errors/Details/621908/
> >>
> >> On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <
> alex.kanavin@gmail.com> wrote:
> >> >
> >> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> >> > ---
> >> >  meta/conf/distro/include/maintainers.inc      |  1 -
> >> >  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
> >> >  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
> >> >  3 files changed, 1 insertion(+), 19 deletions(-)
> >> >  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
> >> >
> >> > diff --git a/meta/conf/distro/include/maintainers.inc
> b/meta/conf/distro/include/maintainers.inc
> >> > index 0af6974a3d..ab7915482a 100644
> >> > --- a/meta/conf/distro/include/maintainers.inc
> >> > +++ b/meta/conf/distro/include/maintainers.inc
> >> > @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <
> yi.zhao@windriver.com>"
> >> >  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <
> unassigned@yoctoproject.org>"
> >> >  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com
> >"
> >> >  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
> >> > -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >> >  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com
> >"
> >> >  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >> >  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >> > diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> > index 8f3bd87340..a64cdefd86 100644
> >> > --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> > +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> > @@ -15,7 +15,6 @@ DEPENDS = " \
> >> >            libarchive \
> >> >            libdazzle \
> >> >            libhandy \
> >> > -          libportal \
> >> >            glib-2.0-native \
> >> >            "
> >> >
> >> > @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
> >> >  PACKAGECONFIG[developer-mode] =
> "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
> >> >  PACKAGECONFIG[soup2] =
> "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
> >> >  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
> >> > +PACKAGECONFIG[libportal] =
> "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
> >> >
> >> >  FILES:${PN} += "${datadir}/dbus-1
> ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
> >> >  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme
> gsettings-desktop-schemas"
> >> > diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb
> b/meta/recipes-gnome/libportal/libportal_0.5.bb
> >> > deleted file mode 100644
> >> > index 67f63fea68..0000000000
> >> > --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
> >> > +++ /dev/null
> >> > @@ -1,17 +0,0 @@
> >> > -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak
> portals."
> >> > -DESCRIPTION = "It provides simple asynchronous wrappers for most
> Flatpak portals \
> >> > -with a familiar GObject API along side the D-Bus API"
> >> > -HOMEPAGE = "https://github.com/flatpak/libportal"
> >> > -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
> >> > -LICENSE = "LGPLv3"
> >> > -LIC_FILES_CHKSUM =
> "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
> >> > -
> >> > -SRC_URI = "git://
> github.com/flatpak/${BPN}.git;protocol=https;branch=master
> <http://github.com/flatpak/$%7BBPN%7D.git;protocol=https;branch=master>"
> >> > -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
> >> > -S = "${WORKDIR}/git"
> >> > -
> >> > -inherit meson gtk-doc gobject-introspection
> >> > -
> >> > -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
> >> > -
> >> > -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
> >> > --
> >> > 2.20.1
> >> >
> >> >
> >> > -=-=-=-=-=-=-=-=-=-=-=-
> >> > Links: You receive all messages sent to this group.
> >> > View/Reply Online (#160313):
> https://lists.openembedded.org/g/openembedded-core/message/160313
> >> > Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
> >> > Group Owner: openembedded-core+owner@lists.openembedded.org
> >> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> [raj.khem@gmail.com]
> >> > -=-=-=-=-=-=-=-=-=-=-=-
> >> >
>
Khem Raj Jan. 10, 2022, 8:54 p.m. UTC | #5
On Mon, Jan 10, 2022 at 11:18 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> For epiphany you also need the oe-core patch. Nautilus should switch to an optional dependency via PACKAGECONFIG, similar to epiphany.

I might have missed the OE-core patch perhaps, I will rebuild with
latest master-next perhaps and see if that helps

>
> Alex
>
> On Mon, 10 Jan 2022 at 19:57, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Mon, Jan 10, 2022 at 10:49 AM Alexander Kanavin
>> <alex.kanavin@gmail.com> wrote:
>> >
>> > Was this patch included in the build?
>>
>> I had included the meta-oe patch that you posted for sure. I am also
>> seeing failing build with similar errors for nautilus see
>> https://errors.yoctoproject.org/Errors/Details/621931/
>>
>> >
>> > Alex
>> >
>> > On Mon, 10 Jan 2022 at 19:43, Khem Raj <raj.khem@gmail.com> wrote:
>> >>
>> >> seeing this error
>> >>
>> >> https://errors.yoctoproject.org/Errors/Details/621908/
>> >>
>> >> On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>> >> >
>> >> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
>> >> > ---
>> >> >  meta/conf/distro/include/maintainers.inc      |  1 -
>> >> >  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
>> >> >  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
>> >> >  3 files changed, 1 insertion(+), 19 deletions(-)
>> >> >  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
>> >> >
>> >> > diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
>> >> > index 0af6974a3d..ab7915482a 100644
>> >> > --- a/meta/conf/distro/include/maintainers.inc
>> >> > +++ b/meta/conf/distro/include/maintainers.inc
>> >> > @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <yi.zhao@windriver.com>"
>> >> >  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <unassigned@yoctoproject.org>"
>> >> >  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
>> >> >  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
>> >> > -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> >> >  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
>> >> >  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> >> >  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <alex.kanavin@gmail.com>"
>> >> > diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> >> > index 8f3bd87340..a64cdefd86 100644
>> >> > --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> >> > +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
>> >> > @@ -15,7 +15,6 @@ DEPENDS = " \
>> >> >            libarchive \
>> >> >            libdazzle \
>> >> >            libhandy \
>> >> > -          libportal \
>> >> >            glib-2.0-native \
>> >> >            "
>> >> >
>> >> > @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
>> >> >  PACKAGECONFIG[developer-mode] = "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
>> >> >  PACKAGECONFIG[soup2] = "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
>> >> >  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
>> >> > +PACKAGECONFIG[libportal] = "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
>> >> >
>> >> >  FILES:${PN} += "${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
>> >> >  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme gsettings-desktop-schemas"
>> >> > diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb b/meta/recipes-gnome/libportal/libportal_0.5.bb
>> >> > deleted file mode 100644
>> >> > index 67f63fea68..0000000000
>> >> > --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
>> >> > +++ /dev/null
>> >> > @@ -1,17 +0,0 @@
>> >> > -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak portals."
>> >> > -DESCRIPTION = "It provides simple asynchronous wrappers for most Flatpak portals \
>> >> > -with a familiar GObject API along side the D-Bus API"
>> >> > -HOMEPAGE = "https://github.com/flatpak/libportal"
>> >> > -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
>> >> > -LICENSE = "LGPLv3"
>> >> > -LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
>> >> > -
>> >> > -SRC_URI = "git://github.com/flatpak/${BPN}.git;protocol=https;branch=master"
>> >> > -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
>> >> > -S = "${WORKDIR}/git"
>> >> > -
>> >> > -inherit meson gtk-doc gobject-introspection
>> >> > -
>> >> > -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
>> >> > -
>> >> > -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
>> >> > --
>> >> > 2.20.1
>> >> >
>> >> >
>> >> > -=-=-=-=-=-=-=-=-=-=-=-
>> >> > Links: You receive all messages sent to this group.
>> >> > View/Reply Online (#160313): https://lists.openembedded.org/g/openembedded-core/message/160313
>> >> > Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
>> >> > Group Owner: openembedded-core+owner@lists.openembedded.org
>> >> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
>> >> > -=-=-=-=-=-=-=-=-=-=-=-
>> >> >
Khem Raj Jan. 11, 2022, 7:49 a.m. UTC | #6
On Mon, Jan 10, 2022 at 12:54 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Jan 10, 2022 at 11:18 AM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > For epiphany you also need the oe-core patch. Nautilus should switch to an optional dependency via PACKAGECONFIG, similar to epiphany.
>
> I might have missed the OE-core patch perhaps, I will rebuild with
> latest master-next perhaps and see if that helps

digging a bit deeper reveals this

../nautilus-41.1/src/nautilus-files-view.c:95:10: fatal error:
'libportal/portal-gtk3.h' file not found
#include <libportal/portal-gtk3.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

but libportal is staging it in

% find ../ -name portal-gtk3.h
../recipe-sysroot/usr/include/libportal-gtk3/portal-gtk3.h

and this is happening with 0.5 upgrade of libportal. I guess nautilus
needs to be patches perhaps.

>
> >
> > Alex
> >
> > On Mon, 10 Jan 2022 at 19:57, Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On Mon, Jan 10, 2022 at 10:49 AM Alexander Kanavin
> >> <alex.kanavin@gmail.com> wrote:
> >> >
> >> > Was this patch included in the build?
> >>
> >> I had included the meta-oe patch that you posted for sure. I am also
> >> seeing failing build with similar errors for nautilus see
> >> https://errors.yoctoproject.org/Errors/Details/621931/
> >>
> >> >
> >> > Alex
> >> >
> >> > On Mon, 10 Jan 2022 at 19:43, Khem Raj <raj.khem@gmail.com> wrote:
> >> >>
> >> >> seeing this error
> >> >>
> >> >> https://errors.yoctoproject.org/Errors/Details/621908/
> >> >>
> >> >> On Sun, Jan 9, 2022 at 2:28 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:
> >> >> >
> >> >> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> >> >> > ---
> >> >> >  meta/conf/distro/include/maintainers.inc      |  1 -
> >> >> >  meta/recipes-gnome/epiphany/epiphany_41.0.bb  |  2 +-
> >> >> >  meta/recipes-gnome/libportal/libportal_0.5.bb | 17 -----------------
> >> >> >  3 files changed, 1 insertion(+), 19 deletions(-)
> >> >> >  delete mode 100644 meta/recipes-gnome/libportal/libportal_0.5.bb
> >> >> >
> >> >> > diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> >> >> > index 0af6974a3d..ab7915482a 100644
> >> >> > --- a/meta/conf/distro/include/maintainers.inc
> >> >> > +++ b/meta/conf/distro/include/maintainers.inc
> >> >> > @@ -369,7 +369,6 @@ RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <yi.zhao@windriver.com>"
> >> >> >  RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <unassigned@yoctoproject.org>"
> >> >> >  RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
> >> >> >  RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
> >> >> > -RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >> >> >  RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
> >> >> >  RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >> >> >  RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <alex.kanavin@gmail.com>"
> >> >> > diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> >> > index 8f3bd87340..a64cdefd86 100644
> >> >> > --- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> >> > +++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
> >> >> > @@ -15,7 +15,6 @@ DEPENDS = " \
> >> >> >            libarchive \
> >> >> >            libdazzle \
> >> >> >            libhandy \
> >> >> > -          libportal \
> >> >> >            glib-2.0-native \
> >> >> >            "
> >> >> >
> >> >> > @@ -37,6 +36,7 @@ PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
> >> >> >  PACKAGECONFIG[developer-mode] = "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
> >> >> >  PACKAGECONFIG[soup2] = "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
> >> >> >  PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
> >> >> > +PACKAGECONFIG[libportal] = "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
> >> >> >
> >> >> >  FILES:${PN} += "${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
> >> >> >  RDEPENDS:${PN} = "iso-codes adwaita-icon-theme gsettings-desktop-schemas"
> >> >> > diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb b/meta/recipes-gnome/libportal/libportal_0.5.bb
> >> >> > deleted file mode 100644
> >> >> > index 67f63fea68..0000000000
> >> >> > --- a/meta/recipes-gnome/libportal/libportal_0.5.bb
> >> >> > +++ /dev/null
> >> >> > @@ -1,17 +0,0 @@
> >> >> > -SUMMARY = "libportal provides GIO-style async APIs for most Flatpak portals."
> >> >> > -DESCRIPTION = "It provides simple asynchronous wrappers for most Flatpak portals \
> >> >> > -with a familiar GObject API along side the D-Bus API"
> >> >> > -HOMEPAGE = "https://github.com/flatpak/libportal"
> >> >> > -BUGTRACKER = "https://github.com/flatpak/libportal/issues"
> >> >> > -LICENSE = "LGPLv3"
> >> >> > -LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
> >> >> > -
> >> >> > -SRC_URI = "git://github.com/flatpak/${BPN}.git;protocol=https;branch=master"
> >> >> > -SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
> >> >> > -S = "${WORKDIR}/git"
> >> >> > -
> >> >> > -inherit meson gtk-doc gobject-introspection
> >> >> > -
> >> >> > -DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
> >> >> > -
> >> >> > -EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"
> >> >> > --
> >> >> > 2.20.1
> >> >> >
> >> >> >
> >> >> > -=-=-=-=-=-=-=-=-=-=-=-
> >> >> > Links: You receive all messages sent to this group.
> >> >> > View/Reply Online (#160313): https://lists.openembedded.org/g/openembedded-core/message/160313
> >> >> > Mute This Topic: https://lists.openembedded.org/mt/88311445/1997914
> >> >> > Group Owner: openembedded-core+owner@lists.openembedded.org
> >> >> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> >> >> > -=-=-=-=-=-=-=-=-=-=-=-
> >> >> >
Alexander Kanavin Jan. 11, 2022, 8:48 a.m. UTC | #7
On Tue, 11 Jan 2022 at 08:49, Khem Raj <raj.khem@gmail.com> wrote:

> On Mon, Jan 10, 2022 at 12:54 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Mon, Jan 10, 2022 at 11:18 AM Alexander Kanavin
> > <alex.kanavin@gmail.com> wrote:
> > >
> > > For epiphany you also need the oe-core patch. Nautilus should switch
> to an optional dependency via PACKAGECONFIG, similar to epiphany.
> >
> > I might have missed the OE-core patch perhaps, I will rebuild with
> > latest master-next perhaps and see if that helps
>
> digging a bit deeper reveals this
>
> ../nautilus-41.1/src/nautilus-files-view.c:95:10: fatal error:
> 'libportal/portal-gtk3.h' file not found
> #include <libportal/portal-gtk3.h>
>         ^~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> but libportal is staging it in
>
> % find ../ -name portal-gtk3.h
> ../recipe-sysroot/usr/include/libportal-gtk3/portal-gtk3.h
>
> and this is happening with 0.5 upgrade of libportal. I guess nautilus
> needs to be patches perhaps.
>

It's a lot easier to just turn the dependency into a PACKAGECONFIG, and in
due time upstream will address it. It's not an essential feature at all.

Alex
Khem Raj Jan. 11, 2022, 7:44 p.m. UTC | #8
On Tue, Jan 11, 2022 at 12:48 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Tue, 11 Jan 2022 at 08:49, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Mon, Jan 10, 2022 at 12:54 PM Khem Raj <raj.khem@gmail.com> wrote:
>> >
>> > On Mon, Jan 10, 2022 at 11:18 AM Alexander Kanavin
>> > <alex.kanavin@gmail.com> wrote:
>> > >
>> > > For epiphany you also need the oe-core patch. Nautilus should switch to an optional dependency via PACKAGECONFIG, similar to epiphany.
>> >
>> > I might have missed the OE-core patch perhaps, I will rebuild with
>> > latest master-next perhaps and see if that helps
>>
>> digging a bit deeper reveals this
>>
>> ../nautilus-41.1/src/nautilus-files-view.c:95:10: fatal error:
>> 'libportal/portal-gtk3.h' file not found
>> #include <libportal/portal-gtk3.h>
>>         ^~~~~~~~~~~~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> but libportal is staging it in
>>
>> % find ../ -name portal-gtk3.h
>> ../recipe-sysroot/usr/include/libportal-gtk3/portal-gtk3.h
>>
>> and this is happening with 0.5 upgrade of libportal. I guess nautilus
>> needs to be patches perhaps.
>
>
> It's a lot easier to just turn the dependency into a PACKAGECONFIG, and in due time upstream will address it. It's not an essential feature at all.

I have sent a fix to contain the breakage. Generally, its good to keep
the dependencies working when doing such incisive changes

>
> Alex

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 0af6974a3d..ab7915482a 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -369,7 +369,6 @@  RECIPE_MAINTAINER:pn-libpcre = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER:pn-libpcre2 = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-libpipeline = "Wang Mingyu <wangmy@fujitsu.com>"
 RECIPE_MAINTAINER:pn-libpng = "Anuj Mittal <anuj.mittal@intel.com>"
-RECIPE_MAINTAINER:pn-libportal = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libproxy = "Anuj Mittal <anuj.mittal@intel.com>"
 RECIPE_MAINTAINER:pn-libpthread-stubs = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-libptytty = "Alexander Kanavin <alex.kanavin@gmail.com>"
diff --git a/meta/recipes-gnome/epiphany/epiphany_41.0.bb b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
index 8f3bd87340..a64cdefd86 100644
--- a/meta/recipes-gnome/epiphany/epiphany_41.0.bb
+++ b/meta/recipes-gnome/epiphany/epiphany_41.0.bb
@@ -15,7 +15,6 @@  DEPENDS = " \
           libarchive \
           libdazzle \
           libhandy \
-          libportal \
           glib-2.0-native \
           "
 
@@ -37,6 +36,7 @@  PACKAGECONFIG ??= "${PACKAGECONFIG_SOUP}"
 PACKAGECONFIG[developer-mode] = "-Ddeveloper_mode=true,-Ddeveloper_mode=false"
 PACKAGECONFIG[soup2] = "-Dsoup2=enabled,-Dsoup2=disabled,libsoup-2.4,,,soup3"
 PACKAGECONFIG[soup3] = ",,libsoup,,,soup2"
+PACKAGECONFIG[libportal] = "-Dlibportal=enabled,-Dlibportal=disabled,libportal"
 
 FILES:${PN} += "${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers ${datadir}/metainfo"
 RDEPENDS:${PN} = "iso-codes adwaita-icon-theme gsettings-desktop-schemas"
diff --git a/meta/recipes-gnome/libportal/libportal_0.5.bb b/meta/recipes-gnome/libportal/libportal_0.5.bb
deleted file mode 100644
index 67f63fea68..0000000000
--- a/meta/recipes-gnome/libportal/libportal_0.5.bb
+++ /dev/null
@@ -1,17 +0,0 @@ 
-SUMMARY = "libportal provides GIO-style async APIs for most Flatpak portals."
-DESCRIPTION = "It provides simple asynchronous wrappers for most Flatpak portals \
-with a familiar GObject API along side the D-Bus API"
-HOMEPAGE = "https://github.com/flatpak/libportal"
-BUGTRACKER = "https://github.com/flatpak/libportal/issues"
-LICENSE = "LGPLv3"
-LIC_FILES_CHKSUM = "file://COPYING;md5=3000208d539ec061b899bce1d9ce9404"
-
-SRC_URI = "git://github.com/flatpak/${BPN}.git;protocol=https;branch=master"
-SRCREV = "467a397fd7996557f837cdc26ac07c01c62810e5"
-S = "${WORKDIR}/git"
-
-inherit meson gtk-doc gobject-introspection
-
-DEPENDS += "glib-2.0 glib-2.0-native gtk+3"
-
-EXTRA_OEMESON = "-Dbackends=gtk3 -Dvapi=false"