From patchwork Tue Mar 21 14:20:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F54C6FD1D for ; Tue, 21 Mar 2023 14:20:57 +0000 (UTC) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web10.14691.1679408455235668860 for ; Tue, 21 Mar 2023 07:20:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=uZ9kPTp2; spf=softfail (domain: sakoman.com, ip: 209.85.216.42, mailfrom: steve@sakoman.com) Received: by mail-pj1-f42.google.com with SMTP id p3-20020a17090a74c300b0023f69bc7a68so11573854pjl.4 for ; Tue, 21 Mar 2023 07:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679408454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Pt2XAiSo2+VvYDHIynCCsqwkL9eOvc7oduFZfDV+IGs=; b=uZ9kPTp23MUO5jqt4MgVJeu8vbXGPjyV/E/LVdk4CP/G+gc1ytfGUuHdeQztCqOiaL Qv1i15OPjETvpL9K8nsFIr+VL1vRXCpLKqlpfyhveA0uWtGhY89AP0Bfwt7ScbWnqstm RsrLqiWJjXF4jsggR4Wo3AM2fS6OsgYfU/RY4MY37bC4spMi7FgDaVG7TGJHZAOF75az z6e2X3XCmhdBsBFtNrqXKBY2HWNTisxsWqrMhgfFqLzIUKKUmibq2RQSFWM/HsPyqhlD SI0CZ8u47Y213+yBcl6R4x4aYUBbdfO/3LDFxywI8KhGcwqfcLJTnKzj/+vxsBqZggWw RAWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679408454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pt2XAiSo2+VvYDHIynCCsqwkL9eOvc7oduFZfDV+IGs=; b=S5FVtvf/fbysUZt6XCMOfYI1g2n08H51x00SBR4l2uxUzz1pm2G/0P52ma+Y3Ws7RM lXCy0npx8gZQplXu3S5o5TFAoKU/GavRmTbrY/JIH1zBdIa2CnuyCykpLuI94uCwgLhK o0LnjCae44FfR7W4RL2liZUiQpoFNT8eQiVQxv65ztyxGtCwNUDYLU+OWbm4wBsZa1Hn xoh3Iuay4oT3dDYzaTEqA7arummDeEIWoMb1xh5mf07IMD1bPTon30VNp9oeG8ANSNiS ux2uceK6uL8XakgW/UZj87NvjLn/JY4pZKxiMHMD7tnCyeP7Pkm3dSSNtyBcA7bpkHaF eSJw== X-Gm-Message-State: AO0yUKWiKvhmfzPZq0hQv+P6QCZjrp1RprlQi6VGjkBV5zWwnFpRua+Z 563JPu+vA/xFwE7kObuEbhI4RC9XM5CTY9Z5lV0= X-Google-Smtp-Source: AK7set8h2/b3H8F1gGtc7MVH4gON8WAQp47CNg4tBXDeADAeTn7mf5c1M+JjaJRfckLdcE8PNF1Zbw== X-Received: by 2002:a05:6a20:ca7:b0:d5:635c:eaa2 with SMTP id dt39-20020a056a200ca700b000d5635ceaa2mr2006152pzb.14.1679408454349; Tue, 21 Mar 2023 07:20:54 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id g11-20020aa7818b000000b005892ea4f092sm8551291pfi.95.2023.03.21.07.20.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:20:54 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][dunfell 13/14] populate_sdk_ext: Handle spaces within user $PATH Date: Tue, 21 Mar 2023 04:20:18 -1000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Mar 2023 14:20:57 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178884 From: Kenfe-Mickael Laventure The script generated by the sdk_ext_postinst function was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 00e96bf250eaaded839caf465dbc0af5b604aed7) Signed-off-by: Steve Sakoman --- meta/classes/populate_sdk_ext.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass index b24f8d99d5..a43ff3fb32 100644 --- a/meta/classes/populate_sdk_ext.bbclass +++ b/meta/classes/populate_sdk_ext.bbclass @@ -669,7 +669,7 @@ sdk_ext_postinst() { # A bit of another hack, but we need this in the path only for devtool # so put it at the end of $PATH. - echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $env_setup_script + echo "export PATH=\"$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH\"" >> $env_setup_script echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script