[bitbake-devel,3/3] bitbake/knotty: ensure CommandFailed increases error count

Submitted by Paul Eggleton on Feb. 13, 2012, 11:41 a.m. | Patch ID: 21183


Message ID 4d20dd2b789c15ede3b1f7afa16b10d5f79f4e34.1329133148.git.paul.eggleton@linux.intel.com
State Accepted, archived
Headers show

Commit Message

Paul Eggleton Feb. 13, 2012, 11:41 a.m.
CommandFailed already sets the return code, so we print out the error
summary message, however we don't increase the error count so it is
usually zero in this case. As we are actually showing an ERROR message,
increment the error count so that the summary makes sense.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
 bitbake/lib/bb/ui/knotty.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 2693a78..ed978e2 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -203,6 +203,7 @@  def main(server, eventHandler):
             if isinstance(event, bb.command.CommandFailed):
                 return_value = event.exitcode
+                errors = errors + 1
                 logger.error("Command execution failed: %s", event.error)
             if isinstance(event, bb.command.CommandExit):