| Message ID | 20230311002722.3211118-10-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | 5aafe0dd13eba8303d1a954adffd6f1d8d234952 |
| Headers | show |
| Series | [01/16] m4/opkg/ethtool/attr/libgpg-error: Add missing bash ptest dependency | expand |
On Fri, Mar 10, 2023 at 4:27 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > The gawk ptests need some locale information, add the missing dependency > so tests work in minimal images. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > meta/recipes-extended/gawk/gawk_5.2.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-extended/gawk/gawk_5.2.1.bb b/meta/recipes-extended/gawk/gawk_5.2.1.bb > index fbe6e7040b0..d13110ddbec 100644 > --- a/meta/recipes-extended/gawk/gawk_5.2.1.bb > +++ b/meta/recipes-extended/gawk/gawk_5.2.1.bb > @@ -62,7 +62,7 @@ do_install_ptest() { > rm -f ${D}${PTEST_PATH}/test/timeout.* > } > > -RDEPENDS:${PN}-ptest += "make" > +RDEPENDS:${PN}-ptest += "make locale-base-en-us" > I think it should be added below so it does not break musl builds. > RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-en-us.iso-8859-1" > > -- > 2.38.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#178353): https://lists.openembedded.org/g/openembedded-core/message/178353 > Mute This Topic: https://lists.openembedded.org/mt/97533194/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, 2023-03-10 at 17:40 -0800, Khem Raj wrote: > On Fri, Mar 10, 2023 at 4:27 PM Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > > > The gawk ptests need some locale information, add the missing dependency > > so tests work in minimal images. > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > > --- > > meta/recipes-extended/gawk/gawk_5.2.1.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-extended/gawk/gawk_5.2.1.bb b/meta/recipes-extended/gawk/gawk_5.2.1.bb > > index fbe6e7040b0..d13110ddbec 100644 > > --- a/meta/recipes-extended/gawk/gawk_5.2.1.bb > > +++ b/meta/recipes-extended/gawk/gawk_5.2.1.bb > > @@ -62,7 +62,7 @@ do_install_ptest() { > > rm -f ${D}${PTEST_PATH}/test/timeout.* > > } > > > > -RDEPENDS:${PN}-ptest += "make" > > +RDEPENDS:${PN}-ptest += "make locale-base-en-us" > > > > I think it should be added below so it does not break musl builds. Interestingly, musl builds didn't break but I'll tweak the patch, well spotted! Cheers, Richard
diff --git a/meta/recipes-extended/gawk/gawk_5.2.1.bb b/meta/recipes-extended/gawk/gawk_5.2.1.bb index fbe6e7040b0..d13110ddbec 100644 --- a/meta/recipes-extended/gawk/gawk_5.2.1.bb +++ b/meta/recipes-extended/gawk/gawk_5.2.1.bb @@ -62,7 +62,7 @@ do_install_ptest() { rm -f ${D}${PTEST_PATH}/test/timeout.* } -RDEPENDS:${PN}-ptest += "make" +RDEPENDS:${PN}-ptest += "make locale-base-en-us" RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-en-us.iso-8859-1"
The gawk ptests need some locale information, add the missing dependency so tests work in minimal images. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- meta/recipes-extended/gawk/gawk_5.2.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)