diff mbox series

[meta-arago,master/kirkstone] arago-prefs: Change how variants interact with the kernel choice

Message ID 20230201144300.24040-1-reatmon@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,master/kirkstone] arago-prefs: Change how variants interact with the kernel choice | expand

Commit Message

Ryan Eatmon Feb. 1, 2023, 2:43 p.m. UTC
Rather than just explicitly locking the PREFERRED_PROVIDER_virtual/kernel
to linux-ti-staging and the suffix, use the :append to add the suffix to
whatever value PREFERRED_PROVIDER_virtual/kernel is.  This allows a
machine in a BSP layer to control which kernel to use as the bsse.

In the event that the kernel/variant choice is not valid the error
report from bitbake is very vague, but it does fail so you will not get
an incorrect build.

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 meta-arago-distro/conf/distro/include/arago-prefs.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Denys Dmytriyenko Feb. 1, 2023, 7:08 p.m. UTC | #1
On Wed, Feb 01, 2023 at 08:43:00AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> Rather than just explicitly locking the PREFERRED_PROVIDER_virtual/kernel
> to linux-ti-staging and the suffix, use the :append to add the suffix to
> whatever value PREFERRED_PROVIDER_virtual/kernel is.  This allows a
> machine in a BSP layer to control which kernel to use as the bsse.
> 
> In the event that the kernel/variant choice is not valid the error
> report from bitbake is very vague, but it does fail so you will not get
> an incorrect build.
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>

Acked-by: Denys Dmytriyenko <denys@konsulko.com>


> ---
>  meta-arago-distro/conf/distro/include/arago-prefs.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/conf/distro/include/arago-prefs.inc b/meta-arago-distro/conf/distro/include/arago-prefs.inc
> index 2dc4f212..34c3c539 100644
> --- a/meta-arago-distro/conf/distro/include/arago-prefs.inc
> +++ b/meta-arago-distro/conf/distro/include/arago-prefs.inc
> @@ -6,7 +6,7 @@ PREFERRED_PROVIDER_ltp-ddt = "ltp-ddt"
>  
>  PREFERRED_PROVIDER_virtual/gettext = "gettext"
>  
> -PREFERRED_PROVIDER_virtual/kernel = "linux-ti-staging${ARAGO_KERNEL_SUFFIX}"
> +PREFERRED_PROVIDER_virtual/kernel:append = "${ARAGO_KERNEL_SUFFIX}"
>  
>  PREFERRED_PROVIDER_jpeg = "libjpeg-turbo"
diff mbox series

Patch

diff --git a/meta-arago-distro/conf/distro/include/arago-prefs.inc b/meta-arago-distro/conf/distro/include/arago-prefs.inc
index 2dc4f212..34c3c539 100644
--- a/meta-arago-distro/conf/distro/include/arago-prefs.inc
+++ b/meta-arago-distro/conf/distro/include/arago-prefs.inc
@@ -6,7 +6,7 @@  PREFERRED_PROVIDER_ltp-ddt = "ltp-ddt"
 
 PREFERRED_PROVIDER_virtual/gettext = "gettext"
 
-PREFERRED_PROVIDER_virtual/kernel = "linux-ti-staging${ARAGO_KERNEL_SUFFIX}"
+PREFERRED_PROVIDER_virtual/kernel:append = "${ARAGO_KERNEL_SUFFIX}"
 
 PREFERRED_PROVIDER_jpeg = "libjpeg-turbo"