[meta-mingw] grpc: remove nl2 requirement since it is optional

Submitted by Sinan Kaya on Aug. 20, 2021, 8:46 p.m. | Patch ID: 180146

Details

Message ID 20210820204620.11236-1-okaya@kernel.org
State New
Headers show

Commit Message

Sinan Kaya Aug. 20, 2021, 8:46 p.m.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend  | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
index a72496d..dc0ea42 100644
--- a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
+++ b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
@@ -1,2 +1,5 @@ 
+# doesn't build and not required
+DEPENDS:remove:mingw32 = "libnsl2"
+
 EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
 EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"

Comments

Richard Purdie Aug. 21, 2021, 11:26 a.m.
On Fri, 2021-08-20 at 20:46 +0000, Sinan Kaya wrote:
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend  | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> index a72496d..dc0ea42 100644
> --- a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> +++ b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> @@ -1,2 +1,5 @@
> +# doesn't build and not required
> +DEPENDS:remove:mingw32 = "libnsl2"
> +
>  EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
>  EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"

Should we be making that a PACKAGECONFIG which mingw32 could change?

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54527): https://lists.yoctoproject.org/g/yocto/message/54527
Mute This Topic: https://lists.yoctoproject.org/mt/85030549/3617530
Group Owner: yocto+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Joshua Watt Aug. 21, 2021, 12:27 p.m.
On Sat, Aug 21, 2021, 6:26 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2021-08-20 at 20:46 +0000, Sinan Kaya wrote:
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> >  .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend  | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git
> a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > index a72496d..dc0ea42 100644
> > ---
> a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > +++
> b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
> > @@ -1,2 +1,5 @@
> > +# doesn't build and not required
> > +DEPENDS:remove:mingw32 = "libnsl2"
> > +
> >  EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON"
> >  EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
>
> Should we be making that a PACKAGECONFIG which mingw32 could change?
>

Yes, that's a good idea. Sinan, please make that change in meta-oe, then
change this patch to remove it from PACKAGECONFIG


> Cheers,
>
> Richard
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#54528): https://lists.yoctoproject.org/g/yocto/message/54528
Mute This Topic: https://lists.yoctoproject.org/mt/85030549/3617530
Group Owner: yocto+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-