[meta-oe] opus-tools: update to 0.2 and fix license

Submitted by Michael Opdenacker on Aug. 10, 2021, 1:18 p.m. | Patch ID: 180026

Details

Message ID 20210810131836.137934-1-michael.opdenacker@bootlin.com
State Master Next
Commit 23dde1b732708334009fee3f1f33c8a66f74ec9f
Headers show

Commit Message

Michael Opdenacker Aug. 10, 2021, 1:18 p.m.
The license in version 0.1.8 was already BSD-2-Clause and GPLv2
(for the "opusinfo" command).

The license checksum change is due to trivial changes on the license
text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 15 deletions(-)
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
 create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
deleted file mode 100644
index a84f2bf07..000000000
--- a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
+++ /dev/null
@@ -1,15 +0,0 @@ 
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
new file mode 100644
index 000000000..b5e6ed947
--- /dev/null
+++ b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
@@ -0,0 +1,15 @@ 
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig

Comments

Khem Raj Aug. 11, 2021, 5:23 p.m.
On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
> (for the "opusinfo" command).
>
> The license checksum change is due to trivial changes on the license
> text ("https" instead of "http" and whitespace changes).
>
> This new version now DEPENDs on "libopusenc" and "opusfile" too.
>

Thanks for this patch, it brings up a YP compatibility issue to front see
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455

I think it would be better to move this recipe to meta-multimedia
which should fix it.

> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>  .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
>  .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
>  2 files changed, 15 insertions(+), 15 deletions(-)
>  delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
>  create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
>
> diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
> deleted file mode 100644
> index a84f2bf07..000000000
> --- a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -SUMMARY = "Opus Audio Tools"
> -HOMEPAGE = "http://www.opus-codec.org/"
> -
> -LICENSE = "BSD-2-Clause"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
> -
> -SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
> -SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
> -SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
> -
> -S = "${WORKDIR}/opus-tools-${PV}"
> -
> -DEPENDS = "libopus flac"
> -
> -inherit autotools pkgconfig
> diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
> new file mode 100644
> index 000000000..b5e6ed947
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "Opus Audio Tools"
> +HOMEPAGE = "http://www.opus-codec.org/"
> +
> +LICENSE = "BSD-2-Clause & GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
> +
> +SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
> +SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
> +SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
> +
> +S = "${WORKDIR}/opus-tools-${PV}"
> +
> +DEPENDS = "libopus libopusenc flac opusfile"
> +
> +inherit autotools pkgconfig
> --
> 2.25.1
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#92584): https://lists.openembedded.org/g/openembedded-devel/message/92584
Mute This Topic: https://lists.openembedded.org/mt/84792449/3617530
Group Owner: openembedded-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Michael Opdenacker Aug. 11, 2021, 6:12 p.m.
Hi Khem,

Thanks for the review and checking the test report!

On 8/11/21 7:23 PM, Khem Raj wrote:
> On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
>> (for the "opusinfo" command).
>>
>> The license checksum change is due to trivial changes on the license
>> text ("https" instead of "http" and whitespace changes).
>>
>> This new version now DEPENDs on "libopusenc" and "opusfile" too.
>>
> Thanks for this patch, it brings up a YP compatibility issue to front see
> https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455
>
> I think it would be better to move this recipe to meta-multimedia
> which should fix it.


I'll be happy to.
However, what's really the difference between meta-oe/recipes-multimedia
and meta-multimedia/recipes-multimedia/? Why two different directories
in the same repository?

Thanks again,
Michael.
Khem Raj Aug. 11, 2021, 6:15 p.m.
On Wed, Aug 11, 2021 at 11:12 AM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> Hi Khem,
>
> Thanks for the review and checking the test report!
>
> On 8/11/21 7:23 PM, Khem Raj wrote:
> > On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
> > <michael.opdenacker@bootlin.com> wrote:
> >> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
> >> (for the "opusinfo" command).
> >>
> >> The license checksum change is due to trivial changes on the license
> >> text ("https" instead of "http" and whitespace changes).
> >>
> >> This new version now DEPENDs on "libopusenc" and "opusfile" too.
> >>
> > Thanks for this patch, it brings up a YP compatibility issue to front see
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455
> >
> > I think it would be better to move this recipe to meta-multimedia
> > which should fix it.
>
>
> I'll be happy to.
> However, what's really the difference between meta-oe/recipes-multimedia
> and meta-multimedia/recipes-multimedia/? Why two different directories
> in the same repository?

these are two different layers, someone may not use meta-multimedia if
its not in bblayers.conf
and thusly not see the dir under meta-multimedia, so tools/packages
which are media related
but more or less generic go into meta-oe/recipe-multimedia, which this
upgrade now depends
on packages in meta-multimedia so its better to put it in meta-multimedia now

>
> Thanks again,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#92586): https://lists.openembedded.org/g/openembedded-devel/message/92586
Mute This Topic: https://lists.openembedded.org/mt/84792449/3617530
Group Owner: openembedded-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Michael Opdenacker Aug. 12, 2021, 5:13 p.m.
Hi Khem,

On 8/11/21 8:15 PM, Khem Raj wrote:
> On Wed, Aug 11, 2021 at 11:12 AM Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>>
>> I'll be happy to.
>> However, what's really the difference between meta-oe/recipes-multimedia
>> and meta-multimedia/recipes-multimedia/? Why two different directories
>> in the same repository?
> these are two different layers, someone may not use meta-multimedia if
> its not in bblayers.conf
> and thusly not see the dir under meta-multimedia, so tools/packages
> which are media related
> but more or less generic go into meta-oe/recipe-multimedia, which this
> upgrade now depends
> on packages in meta-multimedia so its better to put it in meta-multimedia now


Thank you for the clarification. Now I understand that "meta-oe" is
rather for generic packages (outside of oe-core, of course), and the
other layers are for more specific purposes.

Cheers,
Michael.