[v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"

Submitted by Michael Opdenacker on July 29, 2021, 1:13 p.m. | Patch ID: 179991

Details

Message ID 20210729131311.164092-1-michael.opdenacker@bootlin.com
State Superseded
Headers show

Commit Message

Michael Opdenacker July 29, 2021, 1:13 p.m.
"metadata" is used both as singular and as plural.
The first change fixes a case in which the verb has a singular conjugation
but absence of article indicates a plural case.

The second and third changes are for consistency with the first one inside
the same paragraph.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Reviewed-by: Quentin Schulz <foss@0leil.net>
---
 doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
index eb140665..55effc35 100644
--- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
+++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
@@ -27,11 +27,11 @@  Linux software stacks using a task-oriented approach.
 Conceptually, BitBake is similar to GNU Make in some regards but has
 significant differences:
 
--  BitBake executes tasks according to provided metadata that builds up
-   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
+-  BitBake executes tasks according to provided metadata that build up
+   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
    "append" (``.bbappend``) files, configuration (``.conf``) and
    underlying include (``.inc``) files, and in class (``.bbclass``)
-   files. The metadata provides BitBake with instructions on what tasks
+   files. The metadata provide BitBake with instructions on what tasks
    to run and the dependencies between those tasks.
 
 -  BitBake includes a fetcher library for obtaining source code from

Comments

Richard Purdie July 29, 2021, 1:51 p.m.
On Thu, 2021-07-29 at 15:13 +0200, Michael Opdenacker wrote:
> "metadata" is used both as singular and as plural.
> The first change fixes a case in which the verb has a singular conjugation
> but absence of article indicates a plural case.
> 
> The second and third changes are for consistency with the first one inside
> the same paragraph.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Reviewed-by: Quentin Schulz <foss@0leil.net>
> ---
>  doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> index eb140665..55effc35 100644
> --- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> +++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> @@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
>  Conceptually, BitBake is similar to GNU Make in some regards but has
>  significant differences:
>  
> 
> --  BitBake executes tasks according to provided metadata that builds up
> -   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
> +-  BitBake executes tasks according to provided metadata that build up
> +   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
>     "append" (``.bbappend``) files, configuration (``.conf``) and
>     underlying include (``.inc``) files, and in class (``.bbclass``)
> -   files. The metadata provides BitBake with instructions on what tasks
> +   files. The metadata provide BitBake with instructions on what tasks
>     to run and the dependencies between those tasks.

This change doesn't sound like an improvement to me. I would always say 
"The metadata provides", not what you have here which doesn't read 
correctly to me. "builds up" also sounds better to me than "build up". I'd
also say "Metadata is" sounds more correct too.

I'm not sure I like the original wording but this doesn't sound right, at
least to me.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1584): https://lists.yoctoproject.org/g/docs/message/1584
Mute This Topic: https://lists.yoctoproject.org/mt/84527437/3617530
Group Owner: docs+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Michael Opdenacker July 29, 2021, 2 p.m.
Hi Richard,

On 7/29/21 3:51 PM, Richard Purdie wrote:
> On Thu, 2021-07-29 at 15:13 +0200, Michael Opdenacker wrote:
>> "metadata" is used both as singular and as plural.
>> The first change fixes a case in which the verb has a singular conjugation
>> but absence of article indicates a plural case.
>>
>> The second and third changes are for consistency with the first one inside
>> the same paragraph.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Reviewed-by: Quentin Schulz <foss@0leil.net>
>> ---
>>  doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> index eb140665..55effc35 100644
>> --- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> +++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> @@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
>>  Conceptually, BitBake is similar to GNU Make in some regards but has
>>  significant differences:
>>  
>>
>> --  BitBake executes tasks according to provided metadata that builds up
>> -   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
>> +-  BitBake executes tasks according to provided metadata that build up
>> +   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
>>     "append" (``.bbappend``) files, configuration (``.conf``) and
>>     underlying include (``.inc``) files, and in class (``.bbclass``)
>> -   files. The metadata provides BitBake with instructions on what tasks
>> +   files. The metadata provide BitBake with instructions on what tasks
>>     to run and the dependencies between those tasks.
> This change doesn't sound like an improvement to me. I would always say 
> "The metadata provides", not what you have here which doesn't read 
> correctly to me. "builds up" also sounds better to me than "build up". I'd
> also say "Metadata is" sounds more correct too.
>
> I'm not sure I like the original wording but this doesn't sound right, at
> least to me.


Many thanks for the review. I know what to update then :)
Cheers
Michael.
Michael Opdenacker July 30, 2021, 12:01 a.m.
This is a system generated Comment: Patch 179991 was automatically marked as superseded by patch 179992.