UBUNTU sudo apt git instead of git-core

Submitted by janne.kiiskila@pelion.com on March 23, 2021, 6:14 p.m. | Patch ID: 179412

Details

Message ID KkZH.1616523262298523931.IGi7@lists.yoctoproject.org
State Superseded
Headers show

Commit Message

janne.kiiskila@pelion.com March 23, 2021, 6:14 p.m.
From 6d672cf6dcb39e20d10ee2da012e372016fa3c38 Mon Sep 17 00:00:00 2001
From: Janne Kiiskila <janne.kiiskila@arm.com>
Date: Tue, 23 Mar 2021 11:11:39 -0700
Subject: [PATCH] UBUNTU sudo apt git instead of git-core

Ubuntu has changed packing and git-core is not available anymore,
it is now just plain git.

(pelion-venv) jankii01@ubuntu1804:~/poky/documentation$ sudo apt-get install git-core
[sudo] password for jankii01:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'git' instead of 'git-core'
git is already the newest version (1:2.17.1-1ubuntu0.8).
The following package was automatically installed and is no longer required:
linux-hwe-5.4-headers-5.4.0-65
Use 'sudo apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.

Documentaiton should match the current package name to avoid confusion/warnings.
---
documentation/poky.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#941): https://lists.yoctoproject.org/g/docs/message/941
Mute This Topic: https://lists.yoctoproject.org/mt/81557577/3617530
Group Owner: docs+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/documentation/poky.yaml b/documentation/poky.yaml
index 3c30c4430e..2554f1e496 100644
--- a/documentation/poky.yaml
+++ b/documentation/poky.yaml
@@ -11,7 +11,7 @@  YOCTO_POKY : "poky-&DISTRO_NAME_NO_CAP;-&POKYVERSION;"
YOCTO_DL_URL : "https://downloads.yoctoproject.org"
YOCTO_AB_URL : "https://autobuilder.yoctoproject.org"
YOCTO_RELEASE_DL_URL : "&YOCTO_DL_URL;/releases/yocto/yocto-&DISTRO;"
-UBUNTU_HOST_PACKAGES_ESSENTIAL : "gawk wget git-core diffstat unzip texinfo gcc-multilib \
+UBUNTU_HOST_PACKAGES_ESSENTIAL : "gawk wget git diffstat unzip texinfo gcc-multilib \
build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
xz-utils debianutils iputils-ping python3-git python3-jinja2 libegl1-mesa libsdl1.2-dev \
pylint3 xterm python3-subunit mesa-common-dev"

Comments

Quentin Schulz March 23, 2021, 6:23 p.m.
Hi Janne,

On Tue, Mar 23, 2021 at 11:14:22AM -0700, janne.kiiskila@pelion.com wrote:
> From 6d672cf6dcb39e20d10ee2da012e372016fa3c38 Mon Sep 17 00:00:00 2001
> From: Janne Kiiskila <janne.kiiskila@arm.com>
> Date: Tue, 23 Mar 2021 11:11:39 -0700
> Subject: [PATCH] UBUNTU sudo apt git instead of git-core
> 
> Ubuntu has changed packing and git-core is not available anymore,
> it is now just plain git.
> 
> (pelion-venv) jankii01@ubuntu1804:~/poky/documentation$ sudo apt-get install git-core
> [sudo] password for jankii01:
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> Note, selecting 'git' instead of 'git-core'
> git is already the newest version (1:2.17.1-1ubuntu0.8).
> The following package was automatically installed and is no longer required:
> linux-hwe-5.4-headers-5.4.0-65
> Use 'sudo apt autoremove' to remove it.
> 0 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.
> 
> Documentaiton should match the current package name to avoid confusion/warnings.

We're missing your Signed-off-by here.

The documentation applies to both Ubuntu AND Debian. 16.04, 18.04 and
20.04 are supported as well as Debian 8, 9 and 10.

You need to check your change is working for all the above. Otherwise, a
warning is really not that big of deal for the sake of consistency and
compatibility with older (and still supported) distributions.

Thanks,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#942): https://lists.yoctoproject.org/g/docs/message/942
Mute This Topic: https://lists.yoctoproject.org/mt/81557577/3617530
Group Owner: docs+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
janne.kiiskila@pelion.com March 24, 2021, 5:51 a.m.
Hei,

Updated patch provided with sign-off and a test script which confirms sudo apt-get install git works on mentioned distributions.

From b43f224c44e18c1ee41e0170c4289bada8844559 Mon Sep 17 00:00:00 2001
From: Janne Kiiskila <janne.kiiskila@arm.com>
Date: Tue, 23 Mar 2021 11:11:39 -0700
Subject: [PATCH] UBUNTU sudo apt git instead of git-core

Ubuntu has changed packing and git-core is not available anymore,
it is now just plain git.

(pelion-venv) jankii01@ubuntu1804:~/poky/documentation$ sudo apt-get install git-core
[sudo] password for jankii01:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'git' instead of 'git-core'
git is already the newest version (1:2.17.1-1ubuntu0.8).
The following package was automatically installed and is no longer required:
  linux-hwe-5.4-headers-5.4.0-65
Use 'sudo apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.

Documentation should match the current package name to avoid confusion/warnings.

Change can be verified by running the following script

set -ex

distros=("debian:8" "debian:9" "debian:10" "ubuntu:16.04" "ubuntu:18.04" "ubuntu:20.04")
for i in "${distros[@]}"
do
   folder="${i/:/.}"      # change : to .
   mkdir -p $folder
   cd $folder
   echo FROM $i > Dockerfile
   echo RUN apt-get update \&\& apt-get install -y git >> Dockerfile
   cat Dockerfile
   docker build -t test-$folder .
   cd ..
   rm $folder/Dockerfile
   rmdir $folder
done

Signed-off-by: Janne Kiiskila <janne.kiiskila@pelion.com>
---
 documentation/poky.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#944): https://lists.yoctoproject.org/g/docs/message/944
Mute This Topic: https://lists.yoctoproject.org/mt/81557577/3617530
Group Owner: docs+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Quentin Schulz March 24, 2021, 9:19 a.m.
Hi Janne,

On Wed, Mar 24, 2021 at 05:51:56AM +0000, Janne Kiiskila wrote:
> Hei,
> 
> Updated patch provided with sign-off and a test script which confirms sudo apt-get install git works on mentioned distributions.
> 

Please send a v2 following the same process you went through for the
original mail (basically, the mail subject is the commit title, the mail
body is the commit log + content of the patch.

https://docs.yoctoproject.org/dev-manual/common-tasks.html#responding-to-patch-review
should help you with how to do a v2 of your patch.

Thanks for the patch :)

Slight note: your From: is different from the Signed-off-by, is this
expected?

Cheers,
Quentin

> From b43f224c44e18c1ee41e0170c4289bada8844559 Mon Sep 17 00:00:00 2001
> From: Janne Kiiskila <janne.kiiskila@arm.com>
> Date: Tue, 23 Mar 2021 11:11:39 -0700
> Subject: [PATCH] UBUNTU sudo apt git instead of git-core
> 
> Ubuntu has changed packing and git-core is not available anymore,
> it is now just plain git.
> 
> (pelion-venv) jankii01@ubuntu1804:~/poky/documentation$ sudo apt-get install git-core
> [sudo] password for jankii01:
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> Note, selecting 'git' instead of 'git-core'
> git is already the newest version (1:2.17.1-1ubuntu0.8).
> The following package was automatically installed and is no longer required:
>   linux-hwe-5.4-headers-5.4.0-65
> Use 'sudo apt autoremove' to remove it.
> 0 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.
> 
> Documentation should match the current package name to avoid confusion/warnings.
> 
> Change can be verified by running the following script
> 
> set -ex
> 
> distros=("debian:8" "debian:9" "debian:10" "ubuntu:16.04" "ubuntu:18.04" "ubuntu:20.04")
> for i in "${distros[@]}"
> do
>    folder="${i/:/.}"      # change : to .
>    mkdir -p $folder
>    cd $folder
>    echo FROM $i > Dockerfile
>    echo RUN apt-get update \&\& apt-get install -y git >> Dockerfile
>    cat Dockerfile
>    docker build -t test-$folder .
>    cd ..
>    rm $folder/Dockerfile
>    rmdir $folder
> done
> 
> Signed-off-by: Janne Kiiskila <janne.kiiskila@pelion.com>
> ---
>  documentation/poky.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/documentation/poky.yaml b/documentation/poky.yaml
> index 3c30c4430e..2554f1e496 100644
> --- a/documentation/poky.yaml
> +++ b/documentation/poky.yaml
> @@ -11,7 +11,7 @@ YOCTO_POKY : "poky-&DISTRO_NAME_NO_CAP;-&POKYVERSION;"
>  YOCTO_DL_URL : "https://downloads.yoctoproject.org"
>  YOCTO_AB_URL : "https://autobuilder.yoctoproject.org"
>  YOCTO_RELEASE_DL_URL : "&YOCTO_DL_URL;/releases/yocto/yocto-&DISTRO;"
> -UBUNTU_HOST_PACKAGES_ESSENTIAL : "gawk wget git-core diffstat unzip texinfo gcc-multilib \
> +UBUNTU_HOST_PACKAGES_ESSENTIAL : "gawk wget git diffstat unzip texinfo gcc-multilib \
>       build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
>       xz-utils debianutils iputils-ping python3-git python3-jinja2 libegl1-mesa libsdl1.2-dev \
>       pylint3 xterm python3-subunit mesa-common-dev"
> --
> 2.17.1
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
janne.kiiskila@pelion.com March 24, 2021, 11:35 p.m.
This is a system generated Comment: Patch 179412 was automatically marked as superseded by patch 179421.