ltp: fix rpc build error

Submitted by Kory Maincent on Dec. 17, 2020, 9:55 a.m. | Patch ID: 178964

Details

Message ID 20201217095506.28531-1-kory.maincent@bootlin.com
State Superseded
Headers show

Commit Message

Kory Maincent Dec. 17, 2020, 9:55 a.m.
Add support to tirpc tests build.
Export incdir and libdir to have the right path.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

---
 meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145811): https://lists.openembedded.org/g/openembedded-core/message/145811
Mute This Topic: https://lists.openembedded.org/mt/79033325/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb
index 7acf15b360..9b17d68f67 100644
--- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb
@@ -14,7 +14,7 @@  LIC_FILES_CHKSUM = "\
     file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 "
 
-DEPENDS = "attr libaio libcap acl openssl zip-native"
+DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
 DEPENDS_append_libc-musl = " fts "
 EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
 EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
@@ -44,12 +44,12 @@  TARGET_CC_ARCH += "${LDFLAGS}"
 
 export prefix = "/opt/${PN}"
 export exec_prefix = "/opt/${PN}"
+export libdir = "/usr/lib"
+export incdir = "/usr/include"
 
 PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
 EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
 EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
-# ltp network/rpc test cases ftbfs when libtirpc is found
-EXTRA_OECONF += " --without-tirpc "
 
 do_install(){
     install -d ${D}${prefix}/

Comments

Konrad Weihmann Dec. 17, 2020, 10:03 a.m.
On 17.12.20 10:55, Kory Maincent wrote:
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

> ---

>   meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---

>   1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb

> index 7acf15b360..9b17d68f67 100644

> --- a/meta/recipes-extended/ltp/ltp_20200930.bb

> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb

> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\

>       file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \

>   "

>   

> -DEPENDS = "attr libaio libcap acl openssl zip-native"

> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"


Can we have that as a PACKAGECONFIG entry, please? otherwise I think it 
will change the behavior of the existing setups.
Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think 
depending on virtual/librpc should be the safest way

>   DEPENDS_append_libc-musl = " fts "

>   EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "

>   EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "

> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"

>   

>   export prefix = "/opt/${PN}"

>   export exec_prefix = "/opt/${PN}"

> +export libdir = "/usr/lib"

> +export incdir = "/usr/include"


Those should be ${libdir} and ${incdir} if I'm not mistaken

>   

>   PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"



>   EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"

>   EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "

> -# ltp network/rpc test cases ftbfs when libtirpc is found

> -EXTRA_OECONF += " --without-tirpc "


Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being 
the default

>   

>   do_install(){

>       install -d ${D}${prefix}/

> 

> 

> 

> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145812): https://lists.openembedded.org/g/openembedded-core/message/145812
Mute This Topic: https://lists.openembedded.org/mt/79033325/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Kory Maincent Dec. 17, 2020, 10:25 a.m.
Hello Konrad,

On Thu, 17 Dec 2020 11:03:39 +0100
Konrad Weihmann <kweihmann@outlook.com> wrote:

> On 17.12.20 10:55, Kory Maincent wrote:

> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

> > ---

> >   meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---

> >   1 file changed, 3 insertions(+), 3 deletions(-)

> > 

> > diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb

> > b/meta/recipes-extended/ltp/ltp_20200930.bb index 7acf15b360..9b17d68f67

> > 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb

> > +++ b/meta/recipes-extended/ltp/ltp_20200930.bb

> > @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\

> >       file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f

> > \ "

> >   

> > -DEPENDS = "attr libaio libcap acl openssl zip-native"

> > +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"  

> 

> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it 

> will change the behavior of the existing setups.


I assumed the tirpc was disable because they did not manage to build with
it "# ltp network/rpc test cases ftbfs when libtirpc is found".
But if you prefer I can add it to PACKAGECONFIG.

> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think 

> depending on virtual/librpc should be the safest way


Ok

> 

> >   DEPENDS_append_libc-musl = " fts "

> >   EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "

> >   EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "

> > @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"

> >   

> >   export prefix = "/opt/${PN}"

> >   export exec_prefix = "/opt/${PN}"

> > +export libdir = "/usr/lib"

> > +export incdir = "/usr/include"  

> 

> Those should be ${libdir} and ${incdir} if I'm not mistaken


The exporting of ${prefix} change the value of ${libdir} and ${incdir}
therefore I set them up again. If I don't set it, pkgconfig can not find
libtirpc.

> 

> >   

> >   PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"  

> 

> 

> >   EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"

> >   EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "

> > -# ltp network/rpc test cases ftbfs when libtirpc is found

> > -EXTRA_OECONF += " --without-tirpc "  

> 

> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being 

> the default


Ok,

Köry
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145813): https://lists.openembedded.org/g/openembedded-core/message/145813
Mute This Topic: https://lists.openembedded.org/mt/79033325/3616849
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [michael@yoctoproject.org]
-=-=-=-=-=-=-=-=-=-=-=-
Konrad Weihmann Dec. 17, 2020, 10:47 a.m.
On 17.12.20 11:25, Köry Maincent wrote:
> Hello Konrad,

> 

> On Thu, 17 Dec 2020 11:03:39 +0100

> Konrad Weihmann <kweihmann@outlook.com> wrote:

> 

>> On 17.12.20 10:55, Kory Maincent wrote:

>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

>>> ---

>>>    meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---

>>>    1 file changed, 3 insertions(+), 3 deletions(-)

>>>

>>> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb

>>> b/meta/recipes-extended/ltp/ltp_20200930.bb index 7acf15b360..9b17d68f67

>>> 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb

>>> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb

>>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\

>>>        file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f

>>> \ "

>>>    

>>> -DEPENDS = "attr libaio libcap acl openssl zip-native"

>>> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"

>>

>> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it

>> will change the behavior of the existing setups.

> 

> I assumed the tirpc was disable because they did not manage to build with

> it "# ltp network/rpc test cases ftbfs when libtirpc is found".

> But if you prefer I can add it to PACKAGECONFIG.

> 

>> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think

>> depending on virtual/librpc should be the safest way

> 

> Ok

> 

>>

>>>    DEPENDS_append_libc-musl = " fts "

>>>    EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "

>>>    EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "

>>> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"

>>>    

>>>    export prefix = "/opt/${PN}"

>>>    export exec_prefix = "/opt/${PN}"

>>> +export libdir = "/usr/lib"

>>> +export incdir = "/usr/include"

>>

>> Those should be ${libdir} and ${incdir} if I'm not mistaken

> 

> The exporting of ${prefix} change the value of ${libdir} and ${incdir}

> therefore I set them up again. If I don't set it, pkgconfig can not find

> libtirpc.

> 

I see, then please just export ${libdir} and ${incdir} before the prefix 
export and it should be fine
>>

>>>    

>>>    PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"

>>

>>

>>>    EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"

>>>    EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "

>>> -# ltp network/rpc test cases ftbfs when libtirpc is found

>>> -EXTRA_OECONF += " --without-tirpc "

>>

>> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being

>> the default

> 

> Ok,

> 

> Köry

> 

> 

> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145814): https://lists.openembedded.org/g/openembedded-core/message/145814
Mute This Topic: https://lists.openembedded.org/mt/79033325/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Konrad Weihmann Dec. 17, 2020, 10:53 a.m.
On 17.12.20 11:47, Konrad Weihmann wrote:
> On 17.12.20 11:25, Köry Maincent wrote:

>> Hello Konrad,

>>

>> On Thu, 17 Dec 2020 11:03:39 +0100

>> Konrad Weihmann <kweihmann@outlook.com> wrote:

>>

>>> On 17.12.20 10:55, Kory Maincent wrote:

>>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

>>>> ---

>>>>    meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---

>>>>    1 file changed, 3 insertions(+), 3 deletions(-)

>>>>

>>>> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb

>>>> b/meta/recipes-extended/ltp/ltp_20200930.bb index 

>>>> 7acf15b360..9b17d68f67

>>>> 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb

>>>> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb

>>>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\

>>>>        

>>>> file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f 

>>>>

>>>> \ "

>>>> -DEPENDS = "attr libaio libcap acl openssl zip-native"

>>>> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"

>>>

>>> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it

>>> will change the behavior of the existing setups.

>>

>> I assumed the tirpc was disable because they did not manage to build with

>> it "# ltp network/rpc test cases ftbfs when libtirpc is found".

>> But if you prefer I can add it to PACKAGECONFIG.

>>

>>> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think

>>> depending on virtual/librpc should be the safest way

>>

>> Ok

>>

>>>

>>>>    DEPENDS_append_libc-musl = " fts "

>>>>    EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "

>>>>    EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "

>>>> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"

>>>>    export prefix = "/opt/${PN}"

>>>>    export exec_prefix = "/opt/${PN}"

>>>> +export libdir = "/usr/lib"

>>>> +export incdir = "/usr/include"

>>>

>>> Those should be ${libdir} and ${incdir} if I'm not mistaken

>>

>> The exporting of ${prefix} change the value of ${libdir} and ${incdir}

>> therefore I set them up again. If I don't set it, pkgconfig can not find

>> libtirpc.

>>

> I see, then please just export ${libdir} and ${incdir} before the prefix 

> export and it should be fine


for instance that here

export libdir := "${exec_prefix}/${baselib}"
export incdir := "${exec_prefix}/include"
export prefix = "/opt/${PN}"

worked for me

>>>

>>>>    PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"

>>>

>>>

>>>>    EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"

>>>>    EXTRA_OECONF = " --with-realtime-testsuite 

>>>> --with-open-posix-testsuite "

>>>> -# ltp network/rpc test cases ftbfs when libtirpc is found

>>>> -EXTRA_OECONF += " --without-tirpc "

>>>

>>> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being

>>> the default

>>

>> Ok,

>>

>> Köry

>>

>>

>>

>>

> 

> 

> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145815): https://lists.openembedded.org/g/openembedded-core/message/145815
Mute This Topic: https://lists.openembedded.org/mt/79033325/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Kory Maincent Dec. 18, 2020, 4:58 a.m.
This is a system generated Comment: Patch 178964 was automatically marked as superseded by patch 179006.