[v2] ltp: fix rpc build error

Submitted by Kory Maincent on Dec. 17, 2020, 2:07 p.m. | Patch ID: 178946

Details

Message ID 20201217140756.30688-1-kory.maincent@bootlin.com
State Superseded
Headers show

Commit Message

Kory Maincent Dec. 17, 2020, 2:07 p.m.
Add support to tirpc tests build.
Export incdir and libdir to have the right path.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

---

Change since v1:
 - Use PACKAGECONFIG to enable rpc tests
 - Improve ${libdir} and ${incdir} export


 meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145817): https://lists.openembedded.org/g/openembedded-core/message/145817
Mute This Topic: https://lists.openembedded.org/mt/79036634/3616849
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [michael@yoctoproject.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb
index 7acf15b360..9da5d90353 100644
--- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb
@@ -42,14 +42,14 @@  inherit autotools-brokensep pkgconfig
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
+export libdir := "${exec_prefix}/${baselib}"
+export incdir := "${exec_prefix}/include"
 export prefix = "/opt/${PN}"
-export exec_prefix = "/opt/${PN}"
 
 PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
+PACKAGECONFIG[rpc] = ", --without-tirpc, virtual/librpc,"
 EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
 EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
-# ltp network/rpc test cases ftbfs when libtirpc is found
-EXTRA_OECONF += " --without-tirpc "
 
 do_install(){
     install -d ${D}${prefix}/

Comments

Peter Kjellerstedt Dec. 17, 2020, 4:21 p.m.
> -----Original Message-----

> From: openembedded-core@lists.openembedded.org <openembedded-

> core@lists.openembedded.org> On Behalf Of Kory Maincent

> Sent: den 17 december 2020 15:08

> To: openembedded-core@lists.openembedded.org

> Cc: thomas.petazzoni@bootlin.com

> Subject: [OE-core] [PATCH v2] ltp: fix rpc build error

> 

> Add support to tirpc tests build.

> Export incdir and libdir to have the right path.

> 

> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

> ---

> 

> Change since v1:

>  - Use PACKAGECONFIG to enable rpc tests

>  - Improve ${libdir} and ${incdir} export

> 

> 

>  meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-

> extended/ltp/ltp_20200930.bb

> index 7acf15b360..9da5d90353 100644

> --- a/meta/recipes-extended/ltp/ltp_20200930.bb

> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb

> @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig

> 

>  TARGET_CC_ARCH += "${LDFLAGS}"

> 

> +export libdir := "${exec_prefix}/${baselib}"

> +export incdir := "${exec_prefix}/include"


This should be a little bit better:

export libdir := "${libdir}"
export incdir := "${incdir}"

>  export prefix = "/opt/${PN}"

> -export exec_prefix = "/opt/${PN}"

> 

>  PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"

> +PACKAGECONFIG[rpc] = ", --without-tirpc, virtual/librpc,"


I assume there is a --with-tirpc as well, so this should be:

PACKAGECONFIG[rpc] = "--with-tirpc, --without-tirpc, virtual/librpc,"

>  EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"

>  EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "

> -# ltp network/rpc test cases ftbfs when libtirpc is found

> -EXTRA_OECONF += " --without-tirpc "

> 

>  do_install(){

>      install -d ${D}${prefix}/

> --

> 2.17.1


//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145818): https://lists.openembedded.org/g/openembedded-core/message/145818
Mute This Topic: https://lists.openembedded.org/mt/79036634/3616849
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [michael@yoctoproject.org]
-=-=-=-=-=-=-=-=-=-=-=-
Kory Maincent Dec. 18, 2020, 4:57 a.m.
This is a system generated Comment: Patch 178946 was automatically marked as superseded by patch 178964.