[v2,1/8] gstreamer1.0-plugins-bad: v4l2codecs fix typo

Submitted by Jose Quaresma on Dec. 8, 2020, 4:12 p.m. | Patch ID: 178653

Details

Message ID 20201208161257.949716-1-quaresma.jose@gmail.com
State New
Headers show

Commit Message

Jose Quaresma Dec. 8, 2020, 4:12 p.m.
Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.29.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145402): https://lists.openembedded.org/g/openembedded-core/message/145402
Mute This Topic: https://lists.openembedded.org/mt/78806803/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index f70437ccd3..f2b8a21abc 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -72,6 +72,7 @@  PACKAGECONFIG[srtp]            = "-Dsrtp=enabled,-Dsrtp=disabled,libsrtp"
 PACKAGECONFIG[tinyalsa]        = "-Dtinyalsa=enabled,-Dtinyalsa=disabled,tinyalsa"
 PACKAGECONFIG[ttml]            = "-Dttml=enabled,-Dttml=disabled,libxml2 pango cairo"
 PACKAGECONFIG[uvch264]         = "-Duvch264=enabled,-Duvch264=disabled,libusb1 libgudev"
+PACKAGECONFIG[v4l2codecs]      = "-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 PACKAGECONFIG[va]              = "-Dva=enabled,-Dva=disabled,libva"
 PACKAGECONFIG[voaacenc]        = "-Dvoaacenc=enabled,-Dvoaacenc=disabled,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "-Dvoamrwbenc=enabled,-Dvoamrwbenc=disabled,vo-amrwbenc"
@@ -81,7 +82,6 @@  PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
 PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing"
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
-PACKAGECONFIG[v4l2codecs]      = "-D-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
 #   aom androidmedia applemedia bs2b chromaprint d3dvideosink

Comments

Jose Quaresma Dec. 11, 2020, 9:13 p.m.
Hi Richard,

I have think about this patch and probably is better to drop it.
It is now on master-next

Without this we have meson options for all the gstreamer plugins that have
external dependencies.

Probably its better to have it explicity enabled than don't have this
options at all and falback to meson auto discovery dependencies.

Jose

A terça, 8/12/2020, 16:13, Jose Quaresma via lists.openembedded.org
<quaresma.jose=gmail.com@lists.openembedded.org> escreveu:

> decklink: libdl (glibc)

> dvbk: kernel headers

> fbdev: kernel headers

> ipcpipeline: gst-plugins-base

> shm: librt (glibc)

> transcode: gst-plugins-base

>

> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>

> ---

>  .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb            | 6 ------

>  1 file changed, 6 deletions(-)

>

> diff --git a/meta/recipes-multimedia/gstreamer/

> gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/

> gstreamer1.0-plugins-bad_1.18.2.bb

> index d37a223254..a43261b704 100644

> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb

> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb

> @@ -87,12 +87,6 @@ PACKAGECONFIG[x265]            =

> "-Dx265=enabled,-Dx265=disabled,x265"

>

>  EXTRA_OEMESON += " \

>      -Ddoc=disabled \

> -    -Ddecklink=enabled \

> -    -Ddvb=enabled \

> -    -Dfbdev=enabled \

> -    -Dipcpipeline=enabled \

> -    -Dshm=enabled \

> -    -Dtranscode=enabled \

>      -Dandroidmedia=disabled \

>      -Dapplemedia=disabled \

>      -Davtp=disabled \

> --

> 2.29.2

>

>

> 

>

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145484): https://lists.openembedded.org/g/openembedded-core/message/145484
Mute This Topic: https://lists.openembedded.org/mt/78889254/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Richard Purdie Dec. 15, 2020, 11:02 p.m.
Hi Jose,

On Fri, 2020-12-11 at 21:13 +0000, Jose Quaresma wrote:
> I have think about this patch and probably is better to drop it.

> It is now on master-next

> 

> Without this we have meson options for all the gstreamer plugins that

> have external dependencies.

> 

> Probably its better to have it explicity enabled than don't have this

> options at all and falback to meson auto discovery dependencies.


FWIW, I agree. I put things in master-next to run through the
autobuilder in parallel with other review so just because something
makes it there, it doesn't mean its definitely going to be merged. I've
dropped this one, thanks for highlighting!

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145759): https://lists.openembedded.org/g/openembedded-core/message/145759
Mute This Topic: https://lists.openembedded.org/mt/78889254/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jose Quaresma Dec. 17, 2020, 9:17 a.m.
Hi Richard,

Thanks for overview of the merge process.

Jose

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia terça,
15/12/2020 à(s) 23:02:

> Hi Jose,

>

> On Fri, 2020-12-11 at 21:13 +0000, Jose Quaresma wrote:

> > I have think about this patch and probably is better to drop it.

> > It is now on master-next

> >

> > Without this we have meson options for all the gstreamer plugins that

> > have external dependencies.

> >

> > Probably its better to have it explicity enabled than don't have this

> > options at all and falback to meson auto discovery dependencies.

>

> FWIW, I agree. I put things in master-next to run through the

> autobuilder in parallel with other review so just because something

> makes it there, it doesn't mean its definitely going to be merged. I've

> dropped this one, thanks for highlighting!

>

> Cheers,

>

> Richard

>

>


-- 
best regards,
José Quaresma
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145810): https://lists.openembedded.org/g/openembedded-core/message/145810
Mute This Topic: https://lists.openembedded.org/mt/78889254/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-