[v2] kernel-dummy: fix executing unexpected tasks

Submitted by Andrej Valek on Nov. 25, 2020, 5:20 p.m. | Patch ID: 178240

Details

Message ID 20201125172045.8697-1-andrej.valek@siemens.com
State Superseded
Headers show

Commit Message

Andrej Valek Nov. 25, 2020, 5:20 p.m.
- correctly save files into sstate
  - fix: ERROR: Task linux-dummy.do_fetch attempted to execute unexpectedly

Signed-off-by: Andrej Valek <andrej.valek@siemens.com>

---
 meta/recipes-kernel/linux/linux-dummy.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.11.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144988): https://lists.openembedded.org/g/openembedded-core/message/144988
Mute This Topic: https://lists.openembedded.org/mt/78504528/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-kernel/linux/linux-dummy.bb b/meta/recipes-kernel/linux/linux-dummy.bb
index 62cf6f5ea6..1498da392c 100644
--- a/meta/recipes-kernel/linux/linux-dummy.bb
+++ b/meta/recipes-kernel/linux/linux-dummy.bb
@@ -5,10 +5,12 @@  where you wish to build the kernel externally from the build system."
 SECTION = "kernel"
 
 LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://${WORKDIR}/COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
+LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
 
 PROVIDES += "virtual/kernel"
 
+inherit deploy
+
 PACKAGES_DYNAMIC += "^kernel-module-.*"
 PACKAGES_DYNAMIC += "^kernel-image-.*"
 PACKAGES_DYNAMIC += "^kernel-firmware-.*"
@@ -60,6 +62,6 @@  do_deploy() {
 }
 
 addtask bundle_initramfs after do_install before do_deploy
-addtask deploy after do_install
+addtask deploy after do_populate_sysroot do_packagedata
 addtask shared_workdir after do_compile before do_install
 addtask compile_kernelmodules

Comments

Richard Purdie Nov. 26, 2020, 2:37 p.m.
On Wed, 2020-11-25 at 18:20 +0100, Andrej Valek wrote:
>  - correctly save files into sstate

>   - fix: ERROR: Task linux-dummy.do_fetch attempted to execute

> unexpectedly

> 

> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>

> ---

>  meta/recipes-kernel/linux/linux-dummy.bb | 6 ++++--

>  1 file changed, 4 insertions(+), 2 deletions(-)

> 

> diff --git a/meta/recipes-kernel/linux/linux-dummy.bb b/meta/recipes-

> kernel/linux/linux-dummy.bb

> index 62cf6f5ea6..1498da392c 100644

> --- a/meta/recipes-kernel/linux/linux-dummy.bb

> +++ b/meta/recipes-kernel/linux/linux-dummy.bb

> @@ -5,10 +5,12 @@ where you wish to build the kernel externally from

> the build system."

>  SECTION = "kernel"

>  

>  LICENSE = "GPLv2"

> -LIC_FILES_CHKSUM =

> "file://${WORKDIR}/COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"

> +LIC_FILES_CHKSUM =

> "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"

>  

>  PROVIDES += "virtual/kernel"

>  

> +inherit deploy

> +

>  PACKAGES_DYNAMIC += "^kernel-module-.*"

>  PACKAGES_DYNAMIC += "^kernel-image-.*"

>  PACKAGES_DYNAMIC += "^kernel-firmware-.*"

> @@ -60,6 +62,6 @@ do_deploy() {

>  }

>  

>  addtask bundle_initramfs after do_install before do_deploy

> -addtask deploy after do_install

> +addtask deploy after do_populate_sysroot do_packagedata


Is this a leftover from the previous version of the patch? We don't
normally need those constraints?

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144998): https://lists.openembedded.org/g/openembedded-core/message/144998
Mute This Topic: https://lists.openembedded.org/mt/78504528/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Richard Purdie Nov. 26, 2020, 2:51 p.m.
On Thu, 2020-11-26 at 14:44 +0000, Valek, Andrej wrote:
> No it's not a leftover. I've just copied it from kernel.bbclass,

> where this task is written correctly. But you can change it to

> previous version I guess.


I'm trying to work out why we need the extra dependencies when the
tasks are empty.

I can see how adding the inherit would help, I'm less sure how adding
the deploy task after the others does though.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#145001): https://lists.openembedded.org/g/openembedded-core/message/145001
Mute This Topic: https://lists.openembedded.org/mt/78504528/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Andrej Valek Dec. 12, 2020, 7:26 a.m.
This is a system generated Comment: Patch 178240 was automatically marked as superseded by patch 178864.