libsdl2: Add directfb to PACKAGECONFIG rdepends

Submitted by Mark Jonas on Nov. 23, 2020, 7:13 p.m. | Patch ID: 178237

Details

Message ID 20201123191349.7503-1-toertel@gmail.com
State New
Headers show

Commit Message

Mark Jonas Nov. 23, 2020, 7:13 p.m.
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is
added to the DEPENDS. But the automatically generated runtime
dependencies do not add the directfb package to the runtime
dependencies. Most likely this happens because libsdl2 does not link
against directfb but uses dlopen() or similar. Thus, the runtime
dependency to directfb needs to be declared explicitly.

Here, a runtime recommendation is used to allow ignoring the runtime
dependency using NO_RECOMMENDATIONS.

Signed-off-by: Mark Jonas <toertel@gmail.com>

---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144938): https://lists.openembedded.org/g/openembedded-core/message/144938
Mute This Topic: https://lists.openembedded.org/mt/78460941/3616849
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [michael@yoctoproject.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
index 2ef7d2e5ef..ae42db2610 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
@@ -58,7 +58,7 @@  PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"

Comments

Andre McCurdy Nov. 23, 2020, 7:54 p.m.
On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas <toertel@gmail.com> wrote:
>

> When building libsdl2 with PACKAGECONFIG[directfb] then directfb is

> added to the DEPENDS. But the automatically generated runtime

> dependencies do not add the directfb package to the runtime

> dependencies. Most likely this happens because libsdl2 does not link

> against directfb but uses dlopen() or similar. Thus, the runtime

> dependency to directfb needs to be declared explicitly.

>

> Here, a runtime recommendation is used to allow ignoring the runtime

> dependency using NO_RECOMMENDATIONS.


Why would anyone want to ignore the runtime dependency?

> Signed-off-by: Mark Jonas <toertel@gmail.com>

> ---

>  meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb

> index 2ef7d2e5ef..ae42db2610 100644

> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb

> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb

> @@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \

>  "

>  PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"

>  PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"

> -PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"

> +PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"

>  PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"

>  PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"

>  PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"

> --

> 2.25.1

>

>

> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144940): https://lists.openembedded.org/g/openembedded-core/message/144940
Mute This Topic: https://lists.openembedded.org/mt/78460941/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-