[meta-arm,v2] arm-autonomy/xenguest-manager: Fixed subshell false positive

Submitted by Nathan Dunne on Nov. 25, 2020, 9:15 a.m. | Patch ID: 178191

Details

Message ID 20201125091545.7950-1-Nathan.Dunne@arm.com
State Superseded
Headers show

Commit Message

Nathan Dunne Nov. 25, 2020, 9:15 a.m. 
Removed private check from check_size and is_integer to prevent
false positive error on execution in a subshell

Issue-Id: SCM-1623
Signed-off-by: Nathan Dunne <Nathan.Dunne@arm.com>

Change-Id: I57564bf610e21244c963a77c0669da5d4526eeff
---
 .../recipes-extended/xenguest/files/xenguest-manager          | 4 ----
 1 file changed, 4 deletions(-)

--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1440): https://lists.yoctoproject.org/g/meta-arm/message/1440
Mute This Topic: https://lists.yoctoproject.org/mt/78496516/1003190
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox 

diff --git a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
index 33ec40f..cc55b26 100755
--- a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
+++ b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
@@ -70,8 +70,6 @@  function check_private()

 is_integer() {

-    check_private
-
     if ! [[ "${1}" =~ ^[0-9]+$ ]]; then
         >&2 echo "error: invalid number '${1}'"; exit 1
     fi
@@ -80,8 +78,6 @@  is_integer() {
 # check size and convert it to MB, e.g '1[G]' => '1000M'
 check_size() {

-    check_private
-
     local disksize="${1}"

     [ -n "${disksize}" ] || disksize="invalid"

Comments

Nathan Dunne Nov. 26, 2020, 7:21 a.m. 
This is a system generated Comment: Patch 178191 was automatically marked as superseded by patch 178210.