[meta-arm] arm-bsp/n1sdp: remove swap parition entry from wic image

Submitted by Khasim Mohammed on Nov. 12, 2020, 3:01 p.m. | Patch ID: 178124

Details

Message ID 20201112150138.30489-1-khasim.mohammed@arm.com
State New
Headers show

Commit Message

Khasim Mohammed Nov. 12, 2020, 3:01 p.m.
The swap partition on n1sdp seem to create an issue when shutdown or reboot is run
from the shell prompt, the console stops at "Deactivating swap ...". Hence
removing the swap partition entry from wic image.

Change-Id: I22cf971fdde7e3b8b386c74003983fab3d309cc5
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>

---
 meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --
 1 file changed, 2 deletions(-)

-- 
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1362): https://lists.yoctoproject.org/g/meta-arm/message/1362
Mute This Topic: https://lists.yoctoproject.org/mt/78207968/1003190
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta-arm-bsp/wic/n1sdp-efidisk.wks b/meta-arm-bsp/wic/n1sdp-efidisk.wks
index d1ebfb8..b131dd8 100644
--- a/meta-arm-bsp/wic/n1sdp-efidisk.wks
+++ b/meta-arm-bsp/wic/n1sdp-efidisk.wks
@@ -6,6 +6,4 @@  part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --
 
 part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd
 
-part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-
 bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5

Comments

Jon Mason Nov. 16, 2020, 2:25 p.m.
On Thu, Nov 12, 2020 at 08:31:38PM +0530, Khasim Mohammed wrote:
> The swap partition on n1sdp seem to create an issue when shutdown or reboot is run

> from the shell prompt, the console stops at "Deactivating swap ...". Hence

> removing the swap partition entry from wic image.

> 

> Change-Id: I22cf971fdde7e3b8b386c74003983fab3d309cc5

> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>


Applied to master.

Thanks,
Jon

> ---

>  meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/meta-arm-bsp/wic/n1sdp-efidisk.wks b/meta-arm-bsp/wic/n1sdp-efidisk.wks

> index d1ebfb8..b131dd8 100644

> --- a/meta-arm-bsp/wic/n1sdp-efidisk.wks

> +++ b/meta-arm-bsp/wic/n1sdp-efidisk.wks

> @@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --

>  

>  part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd

>  

> -part swap --ondisk sda --size 44 --label swap1 --fstype=swap

> -

>  bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5

> -- 

> 2.17.1

> 


> 

> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1370): https://lists.yoctoproject.org/g/meta-arm/message/1370
Mute This Topic: https://lists.yoctoproject.org/mt/78207968/1003190
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason Nov. 19, 2020, 2:59 p.m.
On Wed, Nov 18, 2020 at 02:52:34PM +0000, Khasim Mohammed wrote:
> Hi Jon,

> 

> ________________________________________

> From: Jon Mason <jdmason@kudzu.us>

> Sent: Monday, November 16, 2020 7:55 PM

> To: Khasim Mohammed

> Cc: meta-arm@lists.yoctoproject.org; nd

> Subject: Re: [meta-arm] [PATCH] arm-bsp/n1sdp: remove swap parition entry from wic image

> 

> On Thu, Nov 12, 2020 at 08:31:38PM +0530, Khasim Mohammed wrote:

> > The swap partition on n1sdp seem to create an issue when shutdown or reboot is run

> > from the shell prompt, the console stops at "Deactivating swap ...". Hence

> > removing the swap partition entry from wic image.

> >

> > Change-Id: I22cf971fdde7e3b8b386c74003983fab3d309cc5

> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>

> 

> > Applied to master.

> 

> Can you please apply this patch to gatesgarth branch as well ?


Done

> 

> Thanks,

> Jon

> 

> > ---

> >  meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --

> >  1 file changed, 2 deletions(-)

> >

> > diff --git a/meta-arm-bsp/wic/n1sdp-efidisk.wks b/meta-arm-bsp/wic/n1sdp-efidisk.wks

> > index d1ebfb8..b131dd8 100644

> > --- a/meta-arm-bsp/wic/n1sdp-efidisk.wks

> > +++ b/meta-arm-bsp/wic/n1sdp-efidisk.wks

> > @@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --

> >

> >  part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd

> >

> > -part swap --ondisk sda --size 44 --label swap1 --fstype=swap

> > -

> >  bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5

> > --

> > 2.17.1

> >

> 

> >

> > 

> >

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1399): https://lists.yoctoproject.org/g/meta-arm/message/1399
Mute This Topic: https://lists.yoctoproject.org/mt/78207968/1003190
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-