buildtools-tarball: add wic dependency into buildtools

Submitted by changqing.li@windriver.com on Nov. 19, 2020, 12:48 a.m. | Patch ID: 178067

Details

Message ID 20201119004832.23088-1-changqing.li@windriver.com
State New
Headers show

Commit Message

changqing.li@windriver.com Nov. 19, 2020, 12:48 a.m.
fix below error:
wic ls ./core-image-minimal-intel-x86-64.wic

ERROR: Can't find executable parted

wic depend on some tools like parted/mtools/..., and we have those
tools in native_sysroot. so above problem can be avoided by
run command like wic ls imagename.wic --native-sysroot <path>

but this cannot cover condition that usr don't have build the
image, the image just copy from somewhere.

Signed-off-by: Changqing Li <changqing.li@windriver.com>

---
 meta/recipes-core/meta/buildtools-tarball.bb | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144800): https://lists.openembedded.org/g/openembedded-core/message/144800
Mute This Topic: https://lists.openembedded.org/mt/78355292/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patch hide | download patch | download mbox

diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb
index 560b8d67b9..7783fabbf2 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -29,6 +29,9 @@  TOOLCHAIN_HOST_TASK ?= "\
     nativesdk-rpcsvc-proto \
     nativesdk-patch \
     nativesdk-mtools \
+    nativesdk-parted \
+    nativesdk-dosfstools \
+    nativesdk-gptfdisk \
     "
 
 MULTIMACH_TARGET_SYS = "${SDK_ARCH}-nativesdk${SDK_VENDOR}-${SDK_OS}"

Comments

Richard Purdie Nov. 20, 2020, 11:07 a.m.
On Thu, 2020-11-19 at 08:48 +0800, Changqing Li wrote:
> fix below error:

> wic ls ./core-image-minimal-intel-x86-64.wic

> 

> ERROR: Can't find executable parted

> 

> wic depend on some tools like parted/mtools/..., and we have those

> tools in native_sysroot. so above problem can be avoided by

> run command like wic ls imagename.wic --native-sysroot <path>

> 

> but this cannot cover condition that usr don't have build the

> image, the image just copy from somewhere.

> 

> Signed-off-by: Changqing Li <changqing.li@windriver.com>

> ---

>  meta/recipes-core/meta/buildtools-tarball.bb | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/meta/recipes-core/meta/buildtools-tarball.bb

> b/meta/recipes-core/meta/buildtools-tarball.bb

> index 560b8d67b9..7783fabbf2 100644

> --- a/meta/recipes-core/meta/buildtools-tarball.bb

> +++ b/meta/recipes-core/meta/buildtools-tarball.bb

> @@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\

>      nativesdk-rpcsvc-proto \

>      nativesdk-patch \

>      nativesdk-mtools \

> +    nativesdk-parted \

> +    nativesdk-dosfstools \

> +    nativesdk-gptfdisk \

>      "


These sound more like something which would be in buildtools-extended-
tarball. Our rough metric for inclusion in this recipe is whether the
tools are needed by an OE build and these are not, they're only needed
for standalone wic usage. I'm therefore unsure whether we should be
adding them at all.

Any other opinions?

Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144847): https://lists.openembedded.org/g/openembedded-core/message/144847
Mute This Topic: https://lists.openembedded.org/mt/78355292/1003190
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mhalstead@linuxfoundation.org]
-=-=-=-=-=-=-=-=-=-=-=-
changqing.li@windriver.com Nov. 25, 2020, 12:47 a.m.
On 20/11/20 7:07 pm, Richard Purdie wrote:
> [Please note this e-mail is from an EXTERNAL e-mail address]

>

> On Thu, 2020-11-19 at 08:48 +0800, Changqing Li wrote:

>> fix below error:

>> wic ls ./core-image-minimal-intel-x86-64.wic

>>

>> ERROR: Can't find executable parted

>>

>> wic depend on some tools like parted/mtools/..., and we have those

>> tools in native_sysroot. so above problem can be avoided by

>> run command like wic ls imagename.wic --native-sysroot <path>

>>

>> but this cannot cover condition that usr don't have build the

>> image, the image just copy from somewhere.

>>

>> Signed-off-by: Changqing Li <changqing.li@windriver.com>

>> ---

>>   meta/recipes-core/meta/buildtools-tarball.bb | 3 +++

>>   1 file changed, 3 insertions(+)

>>

>> diff --git a/meta/recipes-core/meta/buildtools-tarball.bb

>> b/meta/recipes-core/meta/buildtools-tarball.bb

>> index 560b8d67b9..7783fabbf2 100644

>> --- a/meta/recipes-core/meta/buildtools-tarball.bb

>> +++ b/meta/recipes-core/meta/buildtools-tarball.bb

>> @@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\

>>       nativesdk-rpcsvc-proto \

>>       nativesdk-patch \

>>       nativesdk-mtools \

>> +    nativesdk-parted \

>> +    nativesdk-dosfstools \

>> +    nativesdk-gptfdisk \

>>       "

> These sound more like something which would be in buildtools-extended-

> tarball. Our rough metric for inclusion in this recipe is whether the

> tools are needed by an OE build and these are not, they're only needed

> for standalone wic usage. I'm therefore unsure whether we should be

> adding them at all.

>

> Any other opinions?

>

> Cheers,

> Richard


ok. I will send a v2 to add them into buildtools-extended-tarbal.  Thanks.

changqing

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144962): https://lists.openembedded.org/g/openembedded-core/message/144962
Mute This Topic: https://lists.openembedded.org/mt/78355292/3616849
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [michael@yoctoproject.org]
-=-=-=-=-=-=-=-=-=-=-=-