[1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

Submitted by jay.shen.teoh@intel.com on Oct. 28, 2020, 3:40 a.m. | Patch ID: 177603

Details

Message ID 1603856427-62304-1-git-send-email-jay.shen.teoh@intel.com
State Master Next
Commit a63e92e888c3bb60a718f5a3c6a250e451ce3deb
Headers show

Commit Message

jay.shen.teoh@intel.com Oct. 28, 2020, 3:40 a.m.
From: Teoh Jay Shen <jay.shen.teoh@intel.com>

removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test

Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
---
 meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
 1 file changed, 22 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
index 75b8975..790c0c0 100644
--- a/meta/lib/oeqa/manual/bsp-hw.json
+++ b/meta/lib/oeqa/manual/bsp-hw.json
@@ -365,28 +365,6 @@ 
     },
     {
         "test": {
-            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
-            "author": [
-                {
-                    "email": "alexandru.c.georgescu@intel.com",
-                    "name": "alexandru.c.georgescu@intel.com"
-                }
-            ],
-            "execution": {
-                "1": {
-                    "action": "After system launch and X start up, click terminal icon on desktop",
-                    "expected_results": ""
-                },
-                "2": {
-                    "action": "Check if only one terminal window launched and no other problem met",
-                    "expected_results": "There should be no problem after launching terminal . "
-                }
-            },
-            "summary": "click_terminal_icon_on_X_desktop"
-        }
-    },
-    {
-        "test": {
             "@alias": "bsps-hw.bsps-hw.Add_multiple_files_in_media_player",
             "author": [
                 {

Comments

Richard Purdie Oct. 28, 2020, 1:39 p.m.
On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> 
> removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test
> 
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
> index 75b8975..790c0c0 100644
> --- a/meta/lib/oeqa/manual/bsp-hw.json
> +++ b/meta/lib/oeqa/manual/bsp-hw.json
> @@ -365,28 +365,6 @@
>      },
>      {
>          "test": {
> -            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
> -            "author": [
> -                {
> -                    "email": "alexandru.c.georgescu@intel.com",
> -                    "name": "alexandru.c.georgescu@intel.com"
> -                }
> -            ],
> -            "execution": {
> -                "1": {
> -                    "action": "After system launch and X start up, click terminal icon on desktop",
> -                    "expected_results": ""
> -                },
> -                "2": {
> -                    "action": "Check if only one terminal window launched and no other problem met",
> -                    "expected_results": "There should be no problem after launching terminal . "
> -                }
> -            },
> -            "summary": "click_terminal_icon_on_X_desktop"
> -        }
> -    },
> -    {
> -        "test": {

I'm afraid this testcase does not match what terminal.py is testing.
The test here is to:

a) check it launches
b) check there is only one terminal

and the test in terminal.py does neither of these things.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143851): https://lists.openembedded.org/g/openembedded-core/message/143851
Mute This Topic: https://lists.openembedded.org/mt/77855611/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
jay.shen.teoh@intel.com Oct. 29, 2020, 11:25 p.m.
Hi Richard,

Noted with thanks. I will rework on the test case.

Thanks,
Teoh Jay Shen

-----Original Message-----
From: Richard Purdie <richard.purdie@linuxfoundation.org> 

Sent: Wednesday, 28 October, 2020 9:40 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com>; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>

> 

> removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test

> 

> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>

> ---

>  meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------

>  1 file changed, 22 deletions(-)

> 

> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json

> index 75b8975..790c0c0 100644

> --- a/meta/lib/oeqa/manual/bsp-hw.json

> +++ b/meta/lib/oeqa/manual/bsp-hw.json

> @@ -365,28 +365,6 @@

>      },

>      {

>          "test": {

> -            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",

> -            "author": [

> -                {

> -                    "email": "alexandru.c.georgescu@intel.com",

> -                    "name": "alexandru.c.georgescu@intel.com"

> -                }

> -            ],

> -            "execution": {

> -                "1": {

> -                    "action": "After system launch and X start up, click terminal icon on desktop",

> -                    "expected_results": ""

> -                },

> -                "2": {

> -                    "action": "Check if only one terminal window launched and no other problem met",

> -                    "expected_results": "There should be no problem after launching terminal . "

> -                }

> -            },

> -            "summary": "click_terminal_icon_on_X_desktop"

> -        }

> -    },

> -    {

> -        "test": {


I'm afraid this testcase does not match what terminal.py is testing.
The test here is to:

a) check it launches
b) check there is only one terminal

and the test in terminal.py does neither of these things.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143985): https://lists.openembedded.org/g/openembedded-core/message/143985
Mute This Topic: https://lists.openembedded.org/mt/77855611/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-