| Message ID | 20201021171033.21198-1-abdellatif.elkhlifi@arm.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb new file mode 100644 index 0000000..d2bfb19 --- /dev/null +++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb @@ -0,0 +1,21 @@ +SUMMARY = "CORSTONE700 systems communications tests" +DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores" +HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git" +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0" + +SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https" +SRCREV = "ecd93a275d11cf08f670a97783110bd698250963" +PV .= "~git${SRCPV}" + +COMPATIBLE_MACHINE = "(corstone700)" + +S = "${WORKDIR}/git" + +do_compile() { + ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app +} + +do_install() { + install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app +}
On Wed, Oct 21, 2020 at 06:10:33PM +0100, Abdellatif El Khlifi wrote: > From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com> > > This commit provides a recipe that generates a Linux userspace > application used for testing the communication between Corstone700 cores. > > Change-Id: I7c00653b0fcd6d9074510bbb70a838762aed0150 > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com> > --- > .../corstone700-test-app_1.0.bb | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb > > diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb > new file mode 100644 > index 0000000..d2bfb19 > --- /dev/null > +++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb > @@ -0,0 +1,21 @@ > +SUMMARY = "CORSTONE700 systems communications tests" > +DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores" > +HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git" > +LICENSE = "BSD-3-Clause" > +LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0" > + > +SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https" > +SRCREV = "ecd93a275d11cf08f670a97783110bd698250963" > +PV .= "~git${SRCPV}" OpenEmbedded convention is to use "+git..." > + > +COMPATIBLE_MACHINE = "(corstone700)" > + > +S = "${WORKDIR}/git" > + > +do_compile() { > + ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app > +} > + > +do_install() { > + install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app > +} > -- > 2.17.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1260): https://lists.yoctoproject.org/g/meta-arm/message/1260 Mute This Topic: https://lists.yoctoproject.org/mt/77709823/3617530 Group Owner: meta-arm+owner@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [oe-patchwork@oe-patch.openembedded.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 21 Oct 2020 at 18:23, Denys Dmytriyenko <denis@denix.org> wrote: > > +PV .= "~git${SRCPV}" > > OpenEmbedded convention is to use "+git..." + and ~ have different behaviour, so the question is whether this SHA is before or after the 1.0 release. If the 1.0 release hasn't happened yet, ~ is correct. If 1.0 has already happened, + would be correct. The lack of a 1.0 tag suggests that ~ is in fact the correct character to use. ( 1.0~1 < 1.0 < 1.0+1) Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1261): https://lists.yoctoproject.org/g/meta-arm/message/1261 Mute This Topic: https://lists.yoctoproject.org/mt/77709823/3617530 Group Owner: meta-arm+owner@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [oe-patchwork@oe-patch.openembedded.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, Oct 21, 2020 at 07:39:16PM +0100, Ross Burton wrote: > On Wed, 21 Oct 2020 at 18:23, Denys Dmytriyenko <denis@denix.org> wrote: > > > +PV .= "~git${SRCPV}" > > > > OpenEmbedded convention is to use "+git..." > > + and ~ have different behaviour, so the question is whether this SHA > is before or after the 1.0 release. > > If the 1.0 release hasn't happened yet, ~ is correct. If 1.0 has > already happened, + would be correct. > > The lack of a 1.0 tag suggests that ~ is in fact the correct character to use. > > ( 1.0~1 < 1.0 < 1.0+1) Yeah, I know this is Debian convention for things like -rc1 And OpenEmbedded convention for this case historically was 0.9+1.0-rc1
The choice made to use ~ is because the 1.0 release hasn't happened yet. This convention is already used under openembedded/meta-openembedded: meta-oe/recipes-devtools/luajit/luajit_git.bb : PV = "2.1.0~beta3-200809"
On Wed, 21 Oct 2020 at 19:59, Denys Dmytriyenko <denis@denix.org> wrote: > Yeah, I know this is Debian convention for things like -rc1 > > And OpenEmbedded convention for this case historically was 0.9+1.0-rc1 That was because historically we didn't have ~ support. We do now. Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1269): https://lists.yoctoproject.org/g/meta-arm/message/1269 Mute This Topic: https://lists.yoctoproject.org/mt/77709823/3617530 Group Owner: meta-arm+owner@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [oe-patchwork@oe-patch.openembedded.org] -=-=-=-=-=-=-=-=-=-=-=-