[14/16] udev: run depmod if modules.dep doesn't exist

Submitted by Otavio Salvador on Dec. 28, 2011, 7:55 p.m.

Details

Message ID a4ffb960e298bf423adcda013c5b58c1db2f6b48.1325101675.git.otavio@ossystems.com.br
State New
Headers show

Commit Message

Otavio Salvador Dec. 28, 2011, 7:55 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-core/udev/udev/init   |    5 +++++
 meta/recipes-core/udev/udev_164.bb |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index 322e7e7..8d89d51 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -52,6 +52,11 @@  if [ "$DEVCACHE" != "" ]; then
 	fi
 fi
 
+if [ -x /sbin/depmod ] && [ ! -e "/lib/modules/$(uname -r)"/modules.dep ]; then
+	mkdir -p /lib/modules/$(uname -r)
+	depmod -ae
+fi
+
 # make_extra_nodes
 kill_udevd > "/dev/null" 2>&1
 
diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
index 6d71f4d..b993a13 100644
--- a/meta/recipes-core/udev/udev_164.bb
+++ b/meta/recipes-core/udev/udev_164.bb
@@ -1,6 +1,6 @@ 
 include udev.inc
 
-PR = "r10"
+PR = "r11"
 
 SRC_URI += "file://udev-166-v4l1-1.patch"
 

Comments

Richard Purdie Jan. 4, 2012, 5:15 p.m.
On Wed, 2011-12-28 at 19:55 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/recipes-core/udev/udev/init   |    5 +++++
>  meta/recipes-core/udev/udev_164.bb |    2 +-
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> index 322e7e7..8d89d51 100644
> --- a/meta/recipes-core/udev/udev/init
> +++ b/meta/recipes-core/udev/udev/init
> @@ -52,6 +52,11 @@ if [ "$DEVCACHE" != "" ]; then
>  	fi
>  fi
>  
> +if [ -x /sbin/depmod ] && [ ! -e "/lib/modules/$(uname -r)"/modules.dep ]; then
> +	mkdir -p /lib/modules/$(uname -r)
> +	depmod -ae
> +fi
> +
>  # make_extra_nodes
>  kill_udevd > "/dev/null" 2>&1

Why does udev need to do this instead of the kernel module postinstalls?
This strikes me as the wrong thing to be doing here...

Cheers,

Richard
Koen Kooi Jan. 4, 2012, 6:51 p.m.
Op 4 jan. 2012, om 18:15 heeft Richard Purdie het volgende geschreven:

> On Wed, 2011-12-28 at 19:55 +0000, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> meta/recipes-core/udev/udev/init   |    5 +++++
>> meta/recipes-core/udev/udev_164.bb |    2 +-
>> 2 files changed, 6 insertions(+), 1 deletions(-)
>> 
>> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
>> index 322e7e7..8d89d51 100644
>> --- a/meta/recipes-core/udev/udev/init
>> +++ b/meta/recipes-core/udev/udev/init
>> @@ -52,6 +52,11 @@ if [ "$DEVCACHE" != "" ]; then
>> 	fi
>> fi
>> 
>> +if [ -x /sbin/depmod ] && [ ! -e "/lib/modules/$(uname -r)"/modules.dep ]; then
>> +	mkdir -p /lib/modules/$(uname -r)
>> +	depmod -ae
>> +fi
>> +
>> # make_extra_nodes
>> kill_udevd > "/dev/null" 2>&1
> 
> Why does udev need to do this instead of the kernel module postinstalls?
> This strikes me as the wrong thing to be doing here...

Udev runs before those installs get run on first boot.

regards,

Koen
Richard Purdie Jan. 4, 2012, 11:04 p.m.
On Wed, 2012-01-04 at 19:51 +0100, Koen Kooi wrote:
> Op 4 jan. 2012, om 18:15 heeft Richard Purdie het volgende geschreven:
> 
> > On Wed, 2011-12-28 at 19:55 +0000, Otavio Salvador wrote:
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> meta/recipes-core/udev/udev/init   |    5 +++++
> >> meta/recipes-core/udev/udev_164.bb |    2 +-
> >> 2 files changed, 6 insertions(+), 1 deletions(-)
> >> 
> >> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> >> index 322e7e7..8d89d51 100644
> >> --- a/meta/recipes-core/udev/udev/init
> >> +++ b/meta/recipes-core/udev/udev/init
> >> @@ -52,6 +52,11 @@ if [ "$DEVCACHE" != "" ]; then
> >> 	fi
> >> fi
> >> 
> >> +if [ -x /sbin/depmod ] && [ ! -e "/lib/modules/$(uname -r)"/modules.dep ]; then
> >> +	mkdir -p /lib/modules/$(uname -r)
> >> +	depmod -ae
> >> +fi
> >> +
> >> # make_extra_nodes
> >> kill_udevd > "/dev/null" 2>&1
> > 
> > Why does udev need to do this instead of the kernel module postinstalls?
> > This strikes me as the wrong thing to be doing here...
> 
> Udev runs before those installs get run on first boot.

but pkg_postinst_kernel-image from kernel.bbclass should be creating
this at rootfs creation time?

Cheers,

Richard