[5/5] shaderc: enable only native build as the target is failing

Submitted by Jose Quaresma on Oct. 13, 2020, 5:35 p.m. | Patch ID: 177200

Details

Message ID 20201013173502.2245733-6-quaresma.jose@gmail.com
State New
Headers show

Commit Message

Jose Quaresma Oct. 13, 2020, 5:35 p.m.
For now, only the native build its working.
The target build is failing, when we can build for target
this commit can be reverted.

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
 rename meta/recipes-graphics/shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} (86%)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
similarity index 86%
rename from meta/recipes-graphics/shaderc/shaderc_2019.0.bb
rename to meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
index ac3db09937..4e095e1243 100644
--- a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb
+++ b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
@@ -33,4 +33,8 @@  do_configure_prepend() {
 EOF
 }
 
-BBCLASSEXTEND = "native nativesdk"
+# TODO: for now only the native build its working
+# the target build is failing, when the target builds
+# we can drop this inherit and rename the receipe.
+inherit native
+#BBCLASSEXTEND = "native nativesdk"

Comments

Andrey Zhizhikin Oct. 13, 2020, 6:58 p.m.
On Tue, Oct 13, 2020 at 7:35 PM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> For now, only the native build its working.
> The target build is failing, when we can build for target
> this commit can be reverted.
>
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
>  .../shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>  rename meta/recipes-graphics/shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} (86%)
>
> diff --git a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> similarity index 86%
> rename from meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> rename to meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> index ac3db09937..4e095e1243 100644
> --- a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> +++ b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> @@ -33,4 +33,8 @@ do_configure_prepend() {
>  EOF
>  }
>
> -BBCLASSEXTEND = "native nativesdk"
> +# TODO: for now only the native build its working
> +# the target build is failing, when the target builds
> +# we can drop this inherit and rename the receipe.
> +inherit native
> +#BBCLASSEXTEND = "native nativesdk"

Maybe BBCLASSEXTEND = "native" then? Why leave a stale commented code here?

More generic: should the failed target build be investigated further
here? Is there any severe technical problem that should be solved
here?

> --
> 2.28.0
>
>
> 
>
Jose Quaresma Oct. 13, 2020, 8:52 p.m.
Andrey Zhizhikin <andrey.z@gmail.com> escreveu no dia terça,
13/10/2020 à(s) 19:58:
>
> On Tue, Oct 13, 2020 at 7:35 PM Jose Quaresma <quaresma.jose@gmail.com> wrote:
> >
> > For now, only the native build its working.
> > The target build is failing, when we can build for target
> > this commit can be reverted.
> >
> > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > ---
> >  .../shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >  rename meta/recipes-graphics/shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} (86%)
> >
> > diff --git a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > similarity index 86%
> > rename from meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> > rename to meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > index ac3db09937..4e095e1243 100644
> > --- a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> > +++ b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > @@ -33,4 +33,8 @@ do_configure_prepend() {
> >  EOF
> >  }
> >
> > -BBCLASSEXTEND = "native nativesdk"
> > +# TODO: for now only the native build its working
> > +# the target build is failing, when the target builds
> > +# we can drop this inherit and rename the receipe.
> > +inherit native
> > +#BBCLASSEXTEND = "native nativesdk"
>
> Maybe BBCLASSEXTEND = "native" then? Why leave a stale commented code here?

with BBCLASSEXTEND = "native" the build fail when i run: bitbake shaderc

>
> More generic: should the failed target build be investigated further
> here? Is there any severe technical problem that should be solved
> here?

This commit is only to find some help in building shaderc for the target.
If anyone needs to build the gstreamer plugin on the target it will need
the shaderc on the target.

Because of these constraints in building for the target I rename the
recipe to only support native build.
Some extra pacthes are required to build it for the target and I need
some help for this.

>
> > --
> > 2.28.0
> >
> >
> > 
> >
>
>
> --
> Regards,
> Andrey.
Jose Quaresma Oct. 13, 2020, 10:03 p.m.
I have fixed this!

the mistake are:

-DEPENDS = "spirv-tools-native glslang-native"
+DEPENDS = "spirv-tools glslang"

I drop this patch on V2

Jose Quaresma <quaresma.jose@gmail.com> escreveu no dia terça,
13/10/2020 à(s) 21:52:
>
> Andrey Zhizhikin <andrey.z@gmail.com> escreveu no dia terça,
> 13/10/2020 à(s) 19:58:
> >
> > On Tue, Oct 13, 2020 at 7:35 PM Jose Quaresma <quaresma.jose@gmail.com> wrote:
> > >
> > > For now, only the native build its working.
> > > The target build is failing, when we can build for target
> > > this commit can be reverted.
> > >
> > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > > ---
> > >  .../shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >  rename meta/recipes-graphics/shaderc/{shaderc_2019.0.bb => shaderc-native_2019.0.bb} (86%)
> > >
> > > diff --git a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > > similarity index 86%
> > > rename from meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> > > rename to meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > > index ac3db09937..4e095e1243 100644
> > > --- a/meta/recipes-graphics/shaderc/shaderc_2019.0.bb
> > > +++ b/meta/recipes-graphics/shaderc/shaderc-native_2019.0.bb
> > > @@ -33,4 +33,8 @@ do_configure_prepend() {
> > >  EOF
> > >  }
> > >
> > > -BBCLASSEXTEND = "native nativesdk"
> > > +# TODO: for now only the native build its working
> > > +# the target build is failing, when the target builds
> > > +# we can drop this inherit and rename the receipe.
> > > +inherit native
> > > +#BBCLASSEXTEND = "native nativesdk"
> >
> > Maybe BBCLASSEXTEND = "native" then? Why leave a stale commented code here?
>
> with BBCLASSEXTEND = "native" the build fail when i run: bitbake shaderc
>
> >
> > More generic: should the failed target build be investigated further
> > here? Is there any severe technical problem that should be solved
> > here?
>
> This commit is only to find some help in building shaderc for the target.
> If anyone needs to build the gstreamer plugin on the target it will need
> the shaderc on the target.
>
> Because of these constraints in building for the target I rename the
> recipe to only support native build.
> Some extra pacthes are required to build it for the target and I need
> some help for this.
>
> >
> > > --
> > > 2.28.0
> > >
> > >
> > > 
> > >
> >
> >
> > --
> > Regards,
> > Andrey.
>
>
>
> --
> best regards,
> José Quaresma