[05/13] gstreamer1.0-plugins-bad: disable vulkan

Submitted by Jose Quaresma on Oct. 12, 2020, 12:36 p.m. | Patch ID: 177138

Details

Message ID 20201012123620.2095778-5-quaresma.jose@gmail.com
State New
Headers show

Commit Message

Jose Quaresma Oct. 12, 2020, 12:36 p.m.
vulkan build fail
to build vulkan, a new package is needed.
add shaderc package as a separate pacth

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349

| Program glslc found: NO
| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc'] not found or not executable

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb       | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
index 680b9a5cf5..7fc2eec0cb 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
@@ -22,7 +22,7 @@  inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
@@ -76,7 +76,13 @@  PACKAGECONFIG[uvch264]         = "-Duvch264=enabled,-Duvch264=disabled,libusb1 l
 PACKAGECONFIG[va]              = "-Dva=enabled,-Dva=disabled,libva"
 PACKAGECONFIG[voaacenc]        = "-Dvoaacenc=enabled,-Dvoaacenc=disabled,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "-Dvoamrwbenc=enabled,-Dvoamrwbenc=disabled,vo-amrwbenc"
-PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader"
+# FIXME: vulkan build fail
+# to build vulkan, a new package is needed.
+# add shaderc package as a separate pacth
+# https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349
+#| Program glslc found: NO
+#| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc'] not found or not executable
+#PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc"
 PACKAGECONFIG[wayland]         = "-Dwayland=enabled,-Dwayland=disabled,wayland-native wayland wayland-protocols libdrm"
 PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"

Comments

Alexander Kanavin Oct. 12, 2020, 3:54 p.m.
On Mon, 12 Oct 2020 at 14:36, Jose Quaresma <quaresma.jose@gmail.com> wrote:

> -PACKAGECONFIG[vulkan]          =
> "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader"
> +# FIXME: vulkan build fail
> +# to build vulkan, a new package is needed.
> +# add shaderc package as a separate pacth
> +# https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349
> +#| Program glslc found: NO
> +#| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc'] not
> found or not executable
> +#PACKAGECONFIG[vulkan]          =
> "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc"
>

I think this needs to be addressed, as it's a regression in what previously
worked. If a newer version of vulkan is required, I have done some work
towards that here:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498

but had to put it on hold because gstreamer 1.16 is not compatible with it
:) Can you cherry-pick that and see if it helps? (there's an even newer
vulkan available since, so maybe you need to do additional upgrading)

Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143238): https://lists.openembedded.org/g/openembedded-core/message/143238
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jose Quaresma Oct. 12, 2020, 4:13 p.m.
As I understand, the problem is not related with the vulkan package.

To build the vulkan gstreamer plugin whe need a native binary that is
not provided in OE core.
This binary is [glslc]

It is provided by the shaderc project
https://github.com/google/shaderc

Gstreamer upstream also suggests this project.
As glslangValidator is the tool coming from Khronos it would probably
be good to support it.
https://github.com/KhronosGroup/glslang

I can try to build a recipe to fix the missing glslc native binary.
But it's better if anyone can provide more information on this because
I am not expert in this area.

Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
12/10/2020 à(s) 16:54:
>
> On Mon, 12 Oct 2020 at 14:36, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>>
>> -PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader"
>> +# FIXME: vulkan build fail
>> +# to build vulkan, a new package is needed.
>> +# add shaderc package as a separate pacth
>> +# https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349
>> +#| Program glslc found: NO
>> +#| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc'] not found or not executable
>> +#PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc"
>
>
> I think this needs to be addressed, as it's a regression in what previously worked. If a newer version of vulkan is required, I have done some work towards that here:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
>
> but had to put it on hold because gstreamer 1.16 is not compatible with it :) Can you cherry-pick that and see if it helps? (there's an even newer vulkan available since, so maybe you need to do additional upgrading)

I understand the problem and is because of this that I put it in a
separate patch.
I will try your work on
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
But as I mentioned before I think the problem needs to be solved with
a new recipe.

>
> Alex
Alexander Kanavin Oct. 12, 2020, 5:27 p.m.
Right, this is fine then. But please add the information and links to the
commit message, so that anyone who wants to address this knows where to
start.

Alex

On Mon, 12 Oct 2020 at 18:13, Jose Quaresma <quaresma.jose@gmail.com> wrote:

> As I understand, the problem is not related with the vulkan package.
>
> To build the vulkan gstreamer plugin whe need a native binary that is
> not provided in OE core.
> This binary is [glslc]
>
> It is provided by the shaderc project
> https://github.com/google/shaderc
>
> Gstreamer upstream also suggests this project.
> As glslangValidator is the tool coming from Khronos it would probably
> be good to support it.
> https://github.com/KhronosGroup/glslang
>
> I can try to build a recipe to fix the missing glslc native binary.
> But it's better if anyone can provide more information on this because
> I am not expert in this area.
>
> Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
> 12/10/2020 à(s) 16:54:
> >
> > On Mon, 12 Oct 2020 at 14:36, Jose Quaresma <quaresma.jose@gmail.com>
> wrote:
> >>
> >> -PACKAGECONFIG[vulkan]          =
> "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader"
> >> +# FIXME: vulkan build fail
> >> +# to build vulkan, a new package is needed.
> >> +# add shaderc package as a separate pacth
> >> +#
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349
> >> +#| Program glslc found: NO
> >> +#| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc']
> not found or not executable
> >> +#PACKAGECONFIG[vulkan]          =
> "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc"
> >
> >
> > I think this needs to be addressed, as it's a regression in what
> previously worked. If a newer version of vulkan is required, I have done
> some work towards that here:
> >
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
> >
> > but had to put it on hold because gstreamer 1.16 is not compatible with
> it :) Can you cherry-pick that and see if it helps? (there's an even newer
> vulkan available since, so maybe you need to do additional upgrading)
>
> I understand the problem and is because of this that I put it in a
> separate patch.
> I will try your work on
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
> But as I mentioned before I think the problem needs to be solved with
> a new recipe.
>
> >
> > Alex
>
>
>
> --
> best regards,
> José Quaresma
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143240): https://lists.openembedded.org/g/openembedded-core/message/143240
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Andrey Zhizhikin Oct. 12, 2020, 6:05 p.m.
On Mon, Oct 12, 2020 at 7:28 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Right, this is fine then. But please add the information and links to the commit message, so that anyone who wants to address this knows where to start.
>
> Alex
>
> On Mon, 12 Oct 2020 at 18:13, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>>
>> As I understand, the problem is not related with the vulkan package.
>>
>> To build the vulkan gstreamer plugin whe need a native binary that is
>> not provided in OE core.
>> This binary is [glslc]
>>
>> It is provided by the shaderc project
>> https://github.com/google/shaderc
>>
>> Gstreamer upstream also suggests this project.
>> As glslangValidator is the tool coming from Khronos it would probably
>> be good to support it.
>> https://github.com/KhronosGroup/glslang
>>
>> I can try to build a recipe to fix the missing glslc native binary.
>> But it's better if anyone can provide more information on this because
>> I am not expert in this area.

That has been addressed in meta-freescale-distro layer
(https://github.com/Freescale/meta-freescale-distro/commit/01c87325571e5ee91ecc575c863fb693fc1c9955).
There has been a similar native dependency required for GPU SDK build
with Vulkan support, hence the recipe for glslang has been introduced.

Should this be maybe ported to OE-Core?

>>
>> Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
>> 12/10/2020 à(s) 16:54:
>> >
>> > On Mon, 12 Oct 2020 at 14:36, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>> >>
>> >> -PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader"
>> >> +# FIXME: vulkan build fail
>> >> +# to build vulkan, a new package is needed.
>> >> +# add shaderc package as a separate pacth
>> >> +# https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1349
>> >> +#| Program glslc found: NO
>> >> +#| gst-libs/gst/vulkan/meson.build:273:0: ERROR: Program(s) ['glslc'] not found or not executable
>> >> +#PACKAGECONFIG[vulkan]          = "-Dvulkan=enabled,-Dvulkan=disabled,vulkan-loader shaderc"
>> >
>> >
>> > I think this needs to be addressed, as it's a regression in what previously worked. If a newer version of vulkan is required, I have done some work towards that here:
>> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
>> >
>> > but had to put it on hold because gstreamer 1.16 is not compatible with it :) Can you cherry-pick that and see if it helps? (there's an even newer vulkan available since, so maybe you need to do additional upgrading)
>>
>> I understand the problem and is because of this that I put it in a
>> separate patch.
>> I will try your work on
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates-later&id=d6715a06317b1799f5380cc8169acfbd0696d498
>> But as I mentioned before I think the problem needs to be solved with
>> a new recipe.
>>
>> >
>> > Alex
>>
>>
>>
>> --
>> best regards,
>> José Quaresma
>
>
> 
>
Alexander Kanavin Oct. 12, 2020, 6:13 p.m.
On Mon, 12 Oct 2020 at 20:05, Andrey Zhizhikin <andrey.z@gmail.com> wrote:

> That has been addressed in meta-freescale-distro layer
> (
> https://github.com/Freescale/meta-freescale-distro/commit/01c87325571e5ee91ecc575c863fb693fc1c9955
> ).
> There has been a similar native dependency required for GPU SDK build
> with Vulkan support, hence the recipe for glslang has been introduced.
>
> Should this be maybe ported to OE-Core?
>

I think the provided links indicate that gstreamer currently does not
actually support this, and requires a different tool by google? And
gstreamer upstream seems to have conflicting opinions on which one they
want to require.

Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143244): https://lists.openembedded.org/g/openembedded-core/message/143244
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Andrey Zhizhikin Oct. 12, 2020, 6:20 p.m.
On Mon, Oct 12, 2020 at 8:13 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Mon, 12 Oct 2020 at 20:05, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
>>
>> That has been addressed in meta-freescale-distro layer
>> (https://github.com/Freescale/meta-freescale-distro/commit/01c87325571e5ee91ecc575c863fb693fc1c9955).
>> There has been a similar native dependency required for GPU SDK build
>> with Vulkan support, hence the recipe for glslang has been introduced.
>>
>> Should this be maybe ported to OE-Core?
>
>
> I think the provided links indicate that gstreamer currently does not actually support this, and requires a different tool by google? And gstreamer upstream seems to have conflicting opinions on which one they want to require.

What I meant to point out was - there is a dependency in Vulkan on
glslang, irrespective whether it is compiled standalone or as a
dependency of another package. I believe this Vulkan <- glslang
dependency should be solved first before Vulkan can be included
anywhere further.

As I know, it is currently solved locally in meta-freescale-distro
layer, hence it was my question on whether it should be moved to
OE-Core to solve the Vulkan dependency altogether?

>
> Alex
>
>
Alexander Kanavin Oct. 12, 2020, 7:45 p.m.
On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:

>
> What I meant to point out was - there is a dependency in Vulkan on
> glslang, irrespective whether it is compiled standalone or as a
> dependency of another package. I believe this Vulkan <- glslang
> dependency should be solved first before Vulkan can be included
> anywhere further.
>
> As I know, it is currently solved locally in meta-freescale-distro
> layer, hence it was my question on whether it should be moved to
> OE-Core to solve the Vulkan dependency altogether?
>

Can you please point to where glslang is used in the vulkan source tree? Is
it something recently added, as vulkan bits and examples have been building
fine without it in oe-core?

Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143254): https://lists.openembedded.org/g/openembedded-core/message/143254
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Otavio Salvador Oct. 12, 2020, 11:24 p.m.
Em seg., 12 de out. de 2020 às 16:45, Alexander Kanavin
<alex.kanavin@gmail.com> escreveu:
> On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
>>
>>
>> What I meant to point out was - there is a dependency in Vulkan on
>> glslang, irrespective whether it is compiled standalone or as a
>> dependency of another package. I believe this Vulkan <- glslang
>> dependency should be solved first before Vulkan can be included
>> anywhere further.
>>
>> As I know, it is currently solved locally in meta-freescale-distro
>> layer, hence it was my question on whether it should be moved to
>> OE-Core to solve the Vulkan dependency altogether?
>
>
> Can you please point to where glslang is used in the vulkan source tree? Is it something recently added, as vulkan bits and examples have been building fine without it in oe-core?

It seems as a good addition to OE-Core as more SoCs require it; this
also allow us to drop this from meta-freescale layers :-)
Khem Raj Oct. 13, 2020, 12:06 a.m.
On Mon, Oct 12, 2020 at 4:38 PM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>
> Em seg., 12 de out. de 2020 às 16:45, Alexander Kanavin
> <alex.kanavin@gmail.com> escreveu:
> > On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> >>
> >>
> >> What I meant to point out was - there is a dependency in Vulkan on
> >> glslang, irrespective whether it is compiled standalone or as a
> >> dependency of another package. I believe this Vulkan <- glslang
> >> dependency should be solved first before Vulkan can be included
> >> anywhere further.
> >>
> >> As I know, it is currently solved locally in meta-freescale-distro
> >> layer, hence it was my question on whether it should be moved to
> >> OE-Core to solve the Vulkan dependency altogether?
> >
> >
> > Can you please point to where glslang is used in the vulkan source tree? Is it something recently added, as vulkan bits and examples have been building fine without it in oe-core?
>
> It seems as a good addition to OE-Core as more SoCs require it; this
> also allow us to drop this from meta-freescale layers :-)
>


seems good to me. Please propose it for 3.3

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143265): https://lists.openembedded.org/g/openembedded-core/message/143265
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jose Quaresma Oct. 13, 2020, 8:11 a.m.
Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
12/10/2020 à(s) 20:45:
>
> On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
>>
>>
>> What I meant to point out was - there is a dependency in Vulkan on
>> glslang, irrespective whether it is compiled standalone or as a
>> dependency of another package. I believe this Vulkan <- glslang
>> dependency should be solved first before Vulkan can be included
>> anywhere further.
>>
>> As I know, it is currently solved locally in meta-freescale-distro
>> layer, hence it was my question on whether it should be moved to
>> OE-Core to solve the Vulkan dependency altogether?
>
>
> Can you please point to where glslang is used in the vulkan source tree? Is it something recently added, as vulkan bits and examples have been building fine without it in oe-core?

I am working on a recipe for 'shaderc' that is needed for build the
gstreamer vulkan plugin

This recipe needs glslang and spirv-tools.
I don't have knowledge of the existence of glslang on
meta-freescale-distro and I created one for myself.

>
> Alex
Jose Quaresma Oct. 13, 2020, 2:38 p.m.
I have new 3 recipes for fix the build of the vulkan gstreamer plugin

spirv-tools:
move it from meta-oe, add native build and install some extra header files.

glslang:
is the official reference compiler front end for the OpenGL ES and
OpenGL shading languages.

shaderc:
A collection of tools, libraries and tests for shader compilation that
provide the binary glslc need to build the vulkan plugin.

What is the better method to submit this?
A new patch series with these 3 recipes or a gstreamer patch series v2
with all the recipes needed.

Jose Quaresma via lists.openembedded.org
<quaresma.jose=gmail.com@lists.openembedded.org> escreveu no dia
terça, 13/10/2020 à(s) 09:11:
>
> Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
> 12/10/2020 à(s) 20:45:
> >
> > On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> >>
> >>
> >> What I meant to point out was - there is a dependency in Vulkan on
> >> glslang, irrespective whether it is compiled standalone or as a
> >> dependency of another package. I believe this Vulkan <- glslang
> >> dependency should be solved first before Vulkan can be included
> >> anywhere further.
> >>
> >> As I know, it is currently solved locally in meta-freescale-distro
> >> layer, hence it was my question on whether it should be moved to
> >> OE-Core to solve the Vulkan dependency altogether?
> >
> >
> > Can you please point to where glslang is used in the vulkan source tree? Is it something recently added, as vulkan bits and examples have been building fine without it in oe-core?
>
> I am working on a recipe for 'shaderc' that is needed for build the
> gstreamer vulkan plugin
>
> This recipe needs glslang and spirv-tools.
> I don't have knowledge of the existence of glslang on
> meta-freescale-distro and I created one for myself.
>
> >
> > Alex
>
>
>
> --
> best regards,
> José Quaresma
>
> 
>
Alexander Kanavin Oct. 13, 2020, 4:29 p.m.
Either way is ok. If there are two patchsets, reference them in cover
letters.

Alex

On Tue, 13 Oct 2020 at 16:38, Jose Quaresma <quaresma.jose@gmail.com> wrote:

> I have new 3 recipes for fix the build of the vulkan gstreamer plugin
>
> spirv-tools:
> move it from meta-oe, add native build and install some extra header files.
>
> glslang:
> is the official reference compiler front end for the OpenGL ES and
> OpenGL shading languages.
>
> shaderc:
> A collection of tools, libraries and tests for shader compilation that
> provide the binary glslc need to build the vulkan plugin.
>
> What is the better method to submit this?
> A new patch series with these 3 recipes or a gstreamer patch series v2
> with all the recipes needed.
>
> Jose Quaresma via lists.openembedded.org
> <quaresma.jose=gmail.com@lists.openembedded.org> escreveu no dia
> terça, 13/10/2020 à(s) 09:11:
> >
> > Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
> > 12/10/2020 à(s) 20:45:
> > >
> > > On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com>
> wrote:
> > >>
> > >>
> > >> What I meant to point out was - there is a dependency in Vulkan on
> > >> glslang, irrespective whether it is compiled standalone or as a
> > >> dependency of another package. I believe this Vulkan <- glslang
> > >> dependency should be solved first before Vulkan can be included
> > >> anywhere further.
> > >>
> > >> As I know, it is currently solved locally in meta-freescale-distro
> > >> layer, hence it was my question on whether it should be moved to
> > >> OE-Core to solve the Vulkan dependency altogether?
> > >
> > >
> > > Can you please point to where glslang is used in the vulkan source
> tree? Is it something recently added, as vulkan bits and examples have been
> building fine without it in oe-core?
> >
> > I am working on a recipe for 'shaderc' that is needed for build the
> > gstreamer vulkan plugin
> >
> > This recipe needs glslang and spirv-tools.
> > I don't have knowledge of the existence of glslang on
> > meta-freescale-distro and I created one for myself.
> >
> > >
> > > Alex
> >
> >
> >
> > --
> > best regards,
> > José Quaresma
> >
> > 
> >
>
>
> --
> best regards,
> José Quaresma
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143291): https://lists.openembedded.org/g/openembedded-core/message/143291
Mute This Topic: https://lists.openembedded.org/mt/77459442/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jose Quaresma Oct. 13, 2020, 5:39 p.m.
Thanks for the help.

I have submit a new series with the recipes for addressing the issue
in building the vulkan plugin

This adds the shaderc tool
https://patchwork.openembedded.org/series/26532

Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia terça,
13/10/2020 à(s) 17:29:
>
> Either way is ok. If there are two patchsets, reference them in cover letters.
>
> Alex
>
> On Tue, 13 Oct 2020 at 16:38, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>>
>> I have new 3 recipes for fix the build of the vulkan gstreamer plugin
>>
>> spirv-tools:
>> move it from meta-oe, add native build and install some extra header files.
>>
>> glslang:
>> is the official reference compiler front end for the OpenGL ES and
>> OpenGL shading languages.
>>
>> shaderc:
>> A collection of tools, libraries and tests for shader compilation that
>> provide the binary glslc need to build the vulkan plugin.
>>
>> What is the better method to submit this?
>> A new patch series with these 3 recipes or a gstreamer patch series v2
>> with all the recipes needed.
>>
>> Jose Quaresma via lists.openembedded.org
>> <quaresma.jose=gmail.com@lists.openembedded.org> escreveu no dia
>> terça, 13/10/2020 à(s) 09:11:
>> >
>> > Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda,
>> > 12/10/2020 à(s) 20:45:
>> > >
>> > > On Mon, 12 Oct 2020 at 20:20, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
>> > >>
>> > >>
>> > >> What I meant to point out was - there is a dependency in Vulkan on
>> > >> glslang, irrespective whether it is compiled standalone or as a
>> > >> dependency of another package. I believe this Vulkan <- glslang
>> > >> dependency should be solved first before Vulkan can be included
>> > >> anywhere further.
>> > >>
>> > >> As I know, it is currently solved locally in meta-freescale-distro
>> > >> layer, hence it was my question on whether it should be moved to
>> > >> OE-Core to solve the Vulkan dependency altogether?
>> > >
>> > >
>> > > Can you please point to where glslang is used in the vulkan source tree? Is it something recently added, as vulkan bits and examples have been building fine without it in oe-core?
>> >
>> > I am working on a recipe for 'shaderc' that is needed for build the
>> > gstreamer vulkan plugin
>> >
>> > This recipe needs glslang and spirv-tools.
>> > I don't have knowledge of the existence of glslang on
>> > meta-freescale-distro and I created one for myself.
>> >
>> > >
>> > > Alex
>> >
>> >
>> >
>> > --
>> > best regards,
>> > José Quaresma
>> >
>> > 
>> >
>>
>>
>> --
>> best regards,
>> José Quaresma