allarch: Remove MACHINEOVERRIDES

Submitted by Douglas via lists.openembedded.org on Oct. 9, 2020, 4:32 a.m. | Patch ID: 177071

Details

Message ID 20201009043246.20465-1-douglas.royds@taitradio.com
State New
Headers show

Commit Message

Douglas via lists.openembedded.org Oct. 9, 2020, 4:32 a.m.
Avoid machine-specific settings sneaking into allarch tasks.

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/allarch.bbclass | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass
index 5bd5c44a27..2365691fae 100644
--- a/meta/classes/allarch.bbclass
+++ b/meta/classes/allarch.bbclass
@@ -42,6 +42,7 @@  python () {
         d.setVar("TARGET_CXXFLAGS", "none")
         d.setVar("TARGET_LDFLAGS", "none")
         d.setVar("POPULATESYSROOTDEPS", "")
+        d.setVar("MACHINEOVERRIDES", "allarch")
 
         # Avoid this being unnecessarily different due to nuances of
         # the target machine that aren't important for "all" arch

Comments

Alexander Kanavin Oct. 9, 2020, 6:40 a.m.
Wait, I thought this specifically sets MACHINEOVERRIDES to a static value,
replacing the target specific one.

Alex

On Fri, 9 Oct 2020 at 06:36, Douglas via lists.openembedded.org
<douglas.royds=taitradio.com@lists.openembedded.org> wrote:

> Avoid machine-specific settings sneaking into allarch tasks.
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta/classes/allarch.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass
> index 5bd5c44a27..2365691fae 100644
> --- a/meta/classes/allarch.bbclass
> +++ b/meta/classes/allarch.bbclass
> @@ -42,6 +42,7 @@ python () {
>          d.setVar("TARGET_CXXFLAGS", "none")
>          d.setVar("TARGET_LDFLAGS", "none")
>          d.setVar("POPULATESYSROOTDEPS", "")
> +        d.setVar("MACHINEOVERRIDES", "allarch")
>
>          # Avoid this being unnecessarily different due to nuances of
>          # the target machine that aren't important for "all" arch
> --
> 2.17.1
>
>
> 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143153): https://lists.openembedded.org/g/openembedded-core/message/143153
Mute This Topic: https://lists.openembedded.org/mt/77398702/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Richard Purdie Oct. 9, 2020, 3:23 p.m.
On Fri, 2020-10-09 at 17:32 +1300, Douglas via lists.openembedded.org
wrote:
> Avoid machine-specific settings sneaking into allarch tasks.
> 
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta/classes/allarch.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/allarch.bbclass
> b/meta/classes/allarch.bbclass
> index 5bd5c44a27..2365691fae 100644
> --- a/meta/classes/allarch.bbclass
> +++ b/meta/classes/allarch.bbclass
> @@ -42,6 +42,7 @@ python () {
>          d.setVar("TARGET_CXXFLAGS", "none")
>          d.setVar("TARGET_LDFLAGS", "none")
>          d.setVar("POPULATESYSROOTDEPS", "")
> +        d.setVar("MACHINEOVERRIDES", "allarch")

Why would a recipe which is using allarch be using machine specific
overrides?

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143184): https://lists.openembedded.org/g/openembedded-core/message/143184
Mute This Topic: https://lists.openembedded.org/mt/77398702/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Douglas via lists.openembedded.org Oct. 11, 2020, 9:04 p.m.
On 10/10/20 4:23 am, Richard Purdie wrote:

> On Fri, 2020-10-09 at 17:32 +1300, Douglas via lists.openembedded.org
> wrote:
>> Avoid machine-specific settings sneaking into allarch tasks.
>>
>> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
>> ---
>>   meta/classes/allarch.bbclass | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/allarch.bbclass
>> b/meta/classes/allarch.bbclass
>> index 5bd5c44a27..2365691fae 100644
>> --- a/meta/classes/allarch.bbclass
>> +++ b/meta/classes/allarch.bbclass
>> @@ -42,6 +42,7 @@ python () {
>>           d.setVar("TARGET_CXXFLAGS", "none")
>>           d.setVar("TARGET_LDFLAGS", "none")
>>           d.setVar("POPULATESYSROOTDEPS", "")
>> +        d.setVar("MACHINEOVERRIDES", "allarch")
> Why would a recipe which is using allarch be using machine specific
> overrides?


Um, yes, I have to admit that we had an in-house defect over this one, 
now separately fixed.

It seems wrong to have machine-specific overrides in the list at all for 
allarch recipes, so this is just a suggested tidy-up.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143211): https://lists.openembedded.org/g/openembedded-core/message/143211
Mute This Topic: https://lists.openembedded.org/mt/77398702/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-