[dunfell] perl: fix ptest test count

Submitted by chee.yang.lee@intel.com on Oct. 5, 2020, 8:38 a.m. | Patch ID: 176968

Details

Message ID 20201005083843.8405-1-chee.yang.lee@intel.com
State New
Headers show

Commit Message

chee.yang.lee@intel.com Oct. 5, 2020, 8:38 a.m.
From: Chee Yang Lee <chee.yang.lee@intel.com>

patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd
failed ptest perl.t/re/pat. The patch updates incorrect test cases
count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4
test cases so it should be 868 instead of 873.

ptest-runner log :-
  PASS: t/re/overload
  # Looks like you planned 873 tests but ran 868.
  FAIL: t/re/pat
  PASS: t/re/pat_advanced

[YOCTO #14071]

Signed-off-by: Chee Yang Lee <chee.yang.lee@intel.com>
---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
index ad195cffab..d25f4d4a74 100644
--- a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
+++ b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
@@ -265,7 +265,7 @@  index 6a868f4..2869b58 100644
  skip_all_without_unicode_tables();
  
 -plan tests => 864;  # Update this when adding/deleting tests.
-+plan tests => 873;  # Update this when adding/deleting tests.
++plan tests => 868;  # Update this when adding/deleting tests.
  
  run_tests() unless caller;
  

Comments

Alexander Kanavin Oct. 5, 2020, 9:37 a.m.
Hello,

Is this fix meant for dunfell, or master or both? The bug is filed against
master.

Alex

On Mon, 5 Oct 2020 at 10:41, Lee Chee Yang <chee.yang.lee@intel.com> wrote:

> From: Chee Yang Lee <chee.yang.lee@intel.com>
>
> patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd
> failed ptest perl.t/re/pat. The patch updates incorrect test cases
> count causes the ptest to fail.
> 864 test cases before apply the patch while the patch added only 4
> test cases so it should be 868 instead of 873.
>
> ptest-runner log :-
>   PASS: t/re/overload
>   # Looks like you planned 873 tests but ran 868.
>   FAIL: t/re/pat
>   PASS: t/re/pat_advanced
>
> [YOCTO #14071]
>
> Signed-off-by: Chee Yang Lee <chee.yang.lee@intel.com>
> ---
>  meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> index ad195cffab..d25f4d4a74 100644
> --- a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> +++ b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> @@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
>   skip_all_without_unicode_tables();
>
>  -plan tests => 864;  # Update this when adding/deleting tests.
> -+plan tests => 873;  # Update this when adding/deleting tests.
> ++plan tests => 868;  # Update this when adding/deleting tests.
>
>   run_tests() unless caller;
>
> --
> 2.17.1
>
>
> 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143019): https://lists.openembedded.org/g/openembedded-core/message/143019
Mute This Topic: https://lists.openembedded.org/mt/77314518/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
chee.yang.lee@intel.com Oct. 5, 2020, 9:53 a.m.
For Dunfell only


From: Alexander Kanavin <alex.kanavin@gmail.com>

Sent: Monday, 5 October, 2020 5:37 PM
To: Lee, Chee Yang <chee.yang.lee@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH][dunfell] perl: fix ptest test count

Hello,

Is this fix meant for dunfell, or master or both? The bug is filed against master.

Alex

On Mon, 5 Oct 2020 at 10:41, Lee Chee Yang <chee.yang.lee@intel.com<mailto:chee.yang.lee@intel.com>> wrote:
From: Chee Yang Lee <chee.yang.lee@intel.com<mailto:chee.yang.lee@intel.com>>


patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd
failed ptest perl.t/re/pat. The patch updates incorrect test cases
count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4
test cases so it should be 868 instead of 873.

ptest-runner log :-
  PASS: t/re/overload
  # Looks like you planned 873 tests but ran 868.
  FAIL: t/re/pat
  PASS: t/re/pat_advanced

[YOCTO #14071]

Signed-off-by: Chee Yang Lee <chee.yang.lee@intel.com<mailto:chee.yang.lee@intel.com>>

---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143021): https://lists.openembedded.org/g/openembedded-core/message/143021
Mute This Topic: https://lists.openembedded.org/mt/77314518/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Steve Sakoman Oct. 5, 2020, 2:07 p.m.
Thanks!  I tested this fix on Friday and can confirm that it fixes the problem.

I'll include this in the next batch of dunfell patches.

Steve

On Sun, Oct 4, 2020 at 10:41 PM Lee Chee Yang <chee.yang.lee@intel.com> wrote:
>
> From: Chee Yang Lee <chee.yang.lee@intel.com>
>
> patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd
> failed ptest perl.t/re/pat. The patch updates incorrect test cases
> count causes the ptest to fail.
> 864 test cases before apply the patch while the patch added only 4
> test cases so it should be 868 instead of 873.
>
> ptest-runner log :-
>   PASS: t/re/overload
>   # Looks like you planned 873 tests but ran 868.
>   FAIL: t/re/pat
>   PASS: t/re/pat_advanced
>
> [YOCTO #14071]
>
> Signed-off-by: Chee Yang Lee <chee.yang.lee@intel.com>
> ---
>  meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> index ad195cffab..d25f4d4a74 100644
> --- a/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> +++ b/meta/recipes-devtools/perl/files/CVE-2020-12723.patch
> @@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
>   skip_all_without_unicode_tables();
>
>  -plan tests => 864;  # Update this when adding/deleting tests.
> -+plan tests => 873;  # Update this when adding/deleting tests.
> ++plan tests => 868;  # Update this when adding/deleting tests.
>
>   run_tests() unless caller;
>
> --
> 2.17.1
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143022): https://lists.openembedded.org/g/openembedded-core/message/143022
Mute This Topic: https://lists.openembedded.org/mt/77314518/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-