[meta-oe,3/4] tune-cortexa57-cortexa53.inc: add CRC and set march

Submitted by Jon Mason on Sept. 9, 2020, 10:16 p.m. | Patch ID: 176218

Details

Message ID 20200909221652.6750-4-jon.mason@arm.com
State Master Next
Commit 6e04821e91c492c9f37ab3dd7068b54e748da93c
Headers show

Commit Message

Jon Mason Sept. 9, 2020, 10:16 p.m.
Add CRC to the default tuning of big.LITTLE Cortex-A57-A53.  This puts
it inline with all other ARMv8a tunings.  Also, reference
PACKAGE_EXTRA_ARCHS_tune-armv8a-crc instead of
PACKAGE_EXTRA_ARCHS_tune-aarch64, which sets the -march to armv8 and
enables the CRC.

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc b/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
index ba4b0738529c..5880bf203231 100644
--- a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
+++ b/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
@@ -10,6 +10,6 @@  require conf/machine/include/arm/arch-armv8a.inc
 # Little Endian base configs
 AVAILTUNES += "cortexa57-cortexa53"
 ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53"
-TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53"
-PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53"
+TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 crc cortexa57-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57-cortexa53"
 BASE_LIB_tune-cortexa57-cortexa53 = "lib64"

Comments

Mark Hatle Sept. 9, 2020, 10:39 p.m.
On 9/9/20 5:16 PM, Jon Mason wrote:
> Add CRC to the default tuning of big.LITTLE Cortex-A57-A53.  This puts
> it inline with all other ARMv8a tunings.  Also, reference
> PACKAGE_EXTRA_ARCHS_tune-armv8a-crc instead of
> PACKAGE_EXTRA_ARCHS_tune-aarch64, which sets the -march to armv8 and
> enables the CRC.
> 
> Signed-off-by: Jon Mason <jon.mason@arm.com>
> ---
>  meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc b/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
> index ba4b0738529c..5880bf203231 100644
> --- a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
> +++ b/meta/conf/machine/include/tune-cortexa57-cortexa53.inc
> @@ -10,6 +10,6 @@ require conf/machine/include/arm/arch-armv8a.inc
>  # Little Endian base configs
>  AVAILTUNES += "cortexa57-cortexa53"
>  ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53"
> -TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53"
> -PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53"
> +TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 crc cortexa57-cortexa53"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57-cortexa53"

So all a57 and a53 (as well as big.LITTLE) contain the CRC unit?

I use the a72/a53, but I use it as a common intersection for software for
multiple products.  One has an a72 and one has an a53, so it's not a true
bigLittle configuration.  I could see someone try this using this tune as well.

--Mark

>  BASE_LIB_tune-cortexa57-cortexa53 = "lib64"
> 
> 
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#142323): https://lists.openembedded.org/g/openembedded-core/message/142323
Mute This Topic: https://lists.openembedded.org/mt/76743748/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-