[meta-arm,v2,1/3] arm/trusted-firmware-a: fix variable name typo

Submitted by Khasim Mohammed on Aug. 21, 2020, 4:09 p.m. | Patch ID: 175524

Details

Message ID 20200821160927.10598-1-khasim.mohammed@arm.com
State New
Headers show

Commit Message

Khasim Mohammed Aug. 21, 2020, 4:09 p.m.
Variable name "processes" is wrongly mentioned as "processed", this patch
fixes the same.

Change-Id: Id9362f514861c75f8f6a727582e11b0e65736349
Issue-Id: PLATFORMS-3971
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
index 4362882..e4847b5 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
@@ -171,7 +171,7 @@  do_install() {
             echo "dtbs install, skipped"
         elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
             echo "Tools $atfbin install, skipped"
-        elif [ "$processed" = "0" ]; then
+        elif [ "$processes" = "0" ]; then
             bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
             exit 1
         fi

Comments

Denys Dmytriyenko Aug. 22, 2020, 12:28 a.m.
On Fri, Aug 21, 2020 at 09:39:25PM +0530, Khasim Mohammed wrote:
> Variable name "processes" is wrongly mentioned as "processed", this patch
> fixes the same.

Heh, I believe it was meant to be called "processed", i.e. when at least one 
of the checks matches and gets processed, the final condition is not met. So, 
it results in an error only when none of them gets processed.

But looks like I copied and pasted the version with the typo all over the 
place, while using the correct name in the final "if" statement:
https://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc?id=01825739a4a49d857f7b1a839374da4381b92c2e

Sorry about that. Using the correct name would require fixing it in 4 places 
instead of one. So not sure if it's worth it...


> Change-Id: Id9362f514861c75f8f6a727582e11b0e65736349
> Issue-Id: PLATFORMS-3971
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> ---
>  meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index 4362882..e4847b5 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -171,7 +171,7 @@ do_install() {
>              echo "dtbs install, skipped"
>          elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
>              echo "Tools $atfbin install, skipped"
> -        elif [ "$processed" = "0" ]; then
> +        elif [ "$processes" = "0" ]; then
>              bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
>              exit 1
>          fi
> -- 
> 2.17.1
> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#1064): https://lists.yoctoproject.org/g/meta-arm/message/1064
Mute This Topic: https://lists.yoctoproject.org/mt/76332163/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason Aug. 23, 2020, 8:54 p.m.
On Fri, Aug 21, 2020 at 08:28:18PM -0400, Denys Dmytriyenko wrote:
> On Fri, Aug 21, 2020 at 09:39:25PM +0530, Khasim Mohammed wrote:
> > Variable name "processes" is wrongly mentioned as "processed", this patch
> > fixes the same.
> 
> Heh, I believe it was meant to be called "processed", i.e. when at least one 
> of the checks matches and gets processed, the final condition is not met. So, 
> it results in an error only when none of them gets processed.
> 
> But looks like I copied and pasted the version with the typo all over the 
> place, while using the correct name in the final "if" statement:
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc?id=01825739a4a49d857f7b1a839374da4381b92c2e
> 
> Sorry about that. Using the correct name would require fixing it in 4 places 
> instead of one. So not sure if it's worth it...

Yeah, I was of the same opinion.  It should be "processed", but don't
feel live a v3 of this patch is needed for just that.  I'll do a
follow-on patcch to clean it up :)

Thanks,
Jon

> 
> 
> > Change-Id: Id9362f514861c75f8f6a727582e11b0e65736349
> > Issue-Id: PLATFORMS-3971
> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> > ---
> >  meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > index 4362882..e4847b5 100644
> > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > @@ -171,7 +171,7 @@ do_install() {
> >              echo "dtbs install, skipped"
> >          elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
> >              echo "Tools $atfbin install, skipped"
> > -        elif [ "$processed" = "0" ]; then
> > +        elif [ "$processes" = "0" ]; then
> >              bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
> >              exit 1
> >          fi
> > -- 
> > 2.17.1
> > 
> 
> > 
> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#1065): https://lists.yoctoproject.org/g/meta-arm/message/1065
Mute This Topic: https://lists.yoctoproject.org/mt/76332163/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason Aug. 23, 2020, 8:54 p.m.
On Fri, Aug 21, 2020 at 09:39:25PM +0530, Khasim Mohammed wrote:
> Variable name "processes" is wrongly mentioned as "processed", this patch
> fixes the same.
> 
> Change-Id: Id9362f514861c75f8f6a727582e11b0e65736349
> Issue-Id: PLATFORMS-3971
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>

Series pulled into master.

Thanks,
Jon

> ---
>  meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index 4362882..e4847b5 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -171,7 +171,7 @@ do_install() {
>              echo "dtbs install, skipped"
>          elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
>              echo "Tools $atfbin install, skipped"
> -        elif [ "$processed" = "0" ]; then
> +        elif [ "$processes" = "0" ]; then
>              bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
>              exit 1
>          fi
> -- 
> 2.17.1
> 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#1066): https://lists.yoctoproject.org/g/meta-arm/message/1066
Mute This Topic: https://lists.yoctoproject.org/mt/76332163/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-