[1/2] libunwind: Use -fcommon option to compile

Submitted by Khem Raj on Aug. 5, 2020, 6:14 a.m. | Patch ID: 175032

Details

Message ID 20200805061449.1029166-1-raj.khem@gmail.com
State New
Headers show

Commit Message

Khem Raj Aug. 5, 2020, 6:14 a.m.
defaults for gcc is to use -fno-common this ensures that it keeps using
-fcommon until the real issue is fixed

Fixes
src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-support/libunwind/libunwind_1.4.0.bb | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-support/libunwind/libunwind_1.4.0.bb b/meta/recipes-support/libunwind/libunwind_1.4.0.bb
index 34c2249e91..a0bfec90b5 100644
--- a/meta/recipes-support/libunwind/libunwind_1.4.0.bb
+++ b/meta/recipes-support/libunwind/libunwind_1.4.0.bb
@@ -23,3 +23,5 @@  ARM_INSTRUCTION_SET_armv5 = "arm"
 LDFLAGS += "-Wl,-z,relro,-z,now ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 SECURITY_LDFLAGS_append_libc-musl = " -lssp_nonshared"
+
+CFLAGS += "-fcommon"

Comments

Adrian Bunk Aug. 5, 2020, 9:26 a.m.
On Tue, Aug 04, 2020 at 11:14:48PM -0700, Khem Raj wrote:
> defaults for gcc is to use -fno-common this ensures that it keeps using
> -fcommon until the real issue is fixed
> 
> Fixes
> src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here
>...

The upstream fix is
https://github.com/libunwind/libunwind/commit/29e17d8d2ccbca07c423e3089a6d5ae8a1c9cb6e

cu
Adrian
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#141200): https://lists.openembedded.org/g/openembedded-core/message/141200
Mute This Topic: https://lists.openembedded.org/mt/76002561/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Khem Raj Aug. 5, 2020, 4:53 p.m.
On Wed, Aug 5, 2020 at 2:26 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Tue, Aug 04, 2020 at 11:14:48PM -0700, Khem Raj wrote:
> > defaults for gcc is to use -fno-common this ensures that it keeps using
> > -fcommon until the real issue is fixed
> >
> > Fixes
> > src/arm/Ginit.c:60: multiple definition of `_U_dyn_info_list'; mi/.libs/dyn-info-list.o:/usr/src/debug/libunwind/1.4.0-r0/build/src/../../libunwind-1.4.0/src/mi/dyn-info-list.c:28: first defined here
> >...
>
> The upstream fix is
> https://github.com/libunwind/libunwind/commit/29e17d8d2ccbca07c423e3089a6d5ae8a1c9cb6e
>

Thanks for suggesting this, I have sent a v2

> cu
> Adrian
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#141233): https://lists.openembedded.org/g/openembedded-core/message/141233
Mute This Topic: https://lists.openembedded.org/mt/76002561/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-