[meta-arm,1/6] arm-toolchain/external-arm-toolchain: rename common include

Submitted by Ross Burton on July 16, 2020, 2:55 p.m. | Patch ID: 174489

Details

Message ID 20200716145542.232165-1-ross@burtonini.com
State New
Headers show

Commit Message

Ross Burton July 16, 2020, 2:55 p.m.
From: Ross Burton <ross.burton@arm.com>

These recipes all used a common include
external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
the recipes are for x86-64, there typically are more than x86-64
binaries available, and it's not for an external toolchain but
integrating a binary toolchain.

Rename the include to arm-binary-toolchain.inc, as they're all the Arm
binary toolchain.

Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
 .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
 .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
 .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)

Patch hide | download patch | download mbox

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
similarity index 100%
rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
index 4aeba68..7a7673b 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
@@ -3,7 +3,7 @@ 
 # Copyright (c) 2020 Arm Limited
 #
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
 HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index a45fee0..020bbf8 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -1,7 +1,7 @@ 
 # Copyright (C) 2020 Texas Instruments Inc.
 # Released under the MIT license (see COPYING.MIT for the terms)
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal GCC for Aarch64 processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
index 6403fe1..77e44ce 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
@@ -1,7 +1,7 @@ 
 # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
 # Released under the MIT license (see COPYING.MIT for the terms)
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"

Comments

Sumit Garg July 17, 2020, 6:45 a.m.
On Thu, 16 Jul 2020 at 20:25, Ross Burton <ross@burtonini.com> wrote:
>
> From: Ross Burton <ross.burton@arm.com>
>
> These recipes all used a common include
> external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
> the recipes are for x86-64, there typically are more than x86-64
> binaries available, and it's not for an external toolchain but
> integrating a binary toolchain.
>
> Rename the include to arm-binary-toolchain.inc, as they're all the Arm
> binary toolchain.
>
> Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
>  .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
>  .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
>  .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
>  4 files changed, 3 insertions(+), 3 deletions(-)
>  rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)
>

Looks good to me. For the series:

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> similarity index 100%
> rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
> rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> index 4aeba68..7a7673b 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> @@ -3,7 +3,7 @@
>  # Copyright (c) 2020 Arm Limited
>  #
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
>  HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> index a45fee0..020bbf8 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> @@ -1,7 +1,7 @@
>  # Copyright (C) 2020 Texas Instruments Inc.
>  # Released under the MIT license (see COPYING.MIT for the terms)
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal GCC for Aarch64 processors"
>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> index 6403fe1..77e44ce 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> @@ -1,7 +1,7 @@
>  # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
>  # Released under the MIT license (see COPYING.MIT for the terms)
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> --
> 2.26.2
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#871): https://lists.yoctoproject.org/g/meta-arm/message/871
Mute This Topic: https://lists.yoctoproject.org/mt/75543263/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason July 17, 2020, 1:13 p.m.
On Fri, Jul 17, 2020 at 12:15:28PM +0530, Sumit Garg wrote:
> On Thu, 16 Jul 2020 at 20:25, Ross Burton <ross@burtonini.com> wrote:
> >
> > From: Ross Burton <ross.burton@arm.com>
> >
> > These recipes all used a common include
> > external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
> > the recipes are for x86-64, there typically are more than x86-64
> > binaries available, and it's not for an external toolchain but
> > integrating a binary toolchain.
> >
> > Rename the include to arm-binary-toolchain.inc, as they're all the Arm
> > binary toolchain.
> >
> > Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >  ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
> >  .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
> >  .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
> >  .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
> >  4 files changed, 3 insertions(+), 3 deletions(-)
> >  rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)
> >
> 
> Looks good to me. For the series:
> 
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

Series applied to master.

Thanks,
Jon

> 
> -Sumit
> 
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > similarity index 100%
> > rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
> > rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > index 4aeba68..7a7673b 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > @@ -3,7 +3,7 @@
> >  # Copyright (c) 2020 Arm Limited
> >  #
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
> >  HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > index a45fee0..020bbf8 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > @@ -1,7 +1,7 @@
> >  # Copyright (C) 2020 Texas Instruments Inc.
> >  # Released under the MIT license (see COPYING.MIT for the terms)
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal GCC for Aarch64 processors"
> >  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > index 6403fe1..77e44ce 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > @@ -1,7 +1,7 @@
> >  # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
> >  # Released under the MIT license (see COPYING.MIT for the terms)
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
> >  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> > --
> > 2.26.2
> >
> > 

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#872): https://lists.yoctoproject.org/g/meta-arm/message/872
Mute This Topic: https://lists.yoctoproject.org/mt/75543263/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-