[meta-arm] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default

Submitted by Kamil Dziezyk on July 16, 2020, 11:53 a.m. | Patch ID: 174478

Details

Message ID 20200716115329.19153-1-kamil.dziezyk@arm.com
State New
Headers show

Commit Message

Kamil Dziezyk July 16, 2020, 11:53 a.m.
In some cases user doesn't want to create any file system on a specific partition.

Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
---
 meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass b/meta-arm-bsp/classes/image_types_disk_img.bbclass
index ea7ba86..78cc0d8 100644
--- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
+++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
@@ -51,7 +51,7 @@  disk_img_createpart() {
     local imagefile="$1"
     local start="$2"
     local size="$3"
-    local fstype="${4:-ext4}"
+    local fstype="${4:-}"
     local content="${5:-}"
     local formatargs=""
 

Comments

Diego Sueiro July 16, 2020, 12:02 p.m.
On Thu, Jul 16, 2020 at 12:53 PM, Kamil Dziezyk wrote:

>
> In some cases user doesn't want to create any file system on a specific
> partition.
> 
> Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> index ea7ba86..78cc0d8 100644
> --- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> +++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> @@ -51,7 +51,7 @@ disk_img_createpart() {
>      local imagefile="$1"
>      local start="$2"
>      local size="$3"
> -    local fstype="${4:-ext4}"
> +    local fstype="${4:-}"
>      local content="${5:-}"
>      local formatargs=""
>  
> -- 
> 2.17.1
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#860): https://lists.yoctoproject.org/g/meta-arm/message/860
Mute This Topic: https://lists.yoctoproject.org/mt/75539619/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason July 17, 2020, 1:14 p.m.
On Thu, Jul 16, 2020 at 05:02:06AM -0700, Diego Sueiro wrote:
> On Thu, Jul 16, 2020 at 12:53 PM, Kamil Dziezyk wrote:
> 
> >
> > In some cases user doesn't want to create any file system on a specific
> > partition.
> > 
> > Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
> > Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> 
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

Applied to master.

Thanks,
Jon

> 
> > ---
> >  meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > index ea7ba86..78cc0d8 100644
> > --- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > +++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > @@ -51,7 +51,7 @@ disk_img_createpart() {
> >      local imagefile="$1"
> >      local start="$2"
> >      local size="$3"
> > -    local fstype="${4:-ext4}"
> > +    local fstype="${4:-}"
> >      local content="${5:-}"
> >      local formatargs=""
> >
> > -- 
> > 2.17.1
> > 
> >

>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#874): https://lists.yoctoproject.org/g/meta-arm/message/874
Mute This Topic: https://lists.yoctoproject.org/mt/75539619/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Kamil Dziezyk July 17, 2020, 1:42 p.m.
Can you backport this change to dunfell?
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#880): https://lists.yoctoproject.org/g/meta-arm/message/880
Mute This Topic: https://lists.yoctoproject.org/mt/75539619/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Jon Mason July 17, 2020, 7:34 p.m.
On Fri, Jul 17, 2020 at 06:42:36AM -0700, Kamil Dziezyk wrote:
> Can you backport this change to dunfell?

Done.


>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#882): https://lists.yoctoproject.org/g/meta-arm/message/882
Mute This Topic: https://lists.yoctoproject.org/mt/75539619/3617530
Group Owner: meta-arm+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-