recipes-kernel/linux-firmware: Add qcom-sdm845 firmware package

Submitted by Aníbal Limón on March 31, 2020, 2:01 a.m. | Patch ID: 171450

Details

Message ID 20200331020114.25468-1-anibal.limon@linaro.org
State Master Next
Commit bdb6dfdc5c16bde420b9d376262938bd2751e77a
Headers show

Commit Message

Aníbal Limón March 31, 2020, 2:01 a.m.
Contains the firmware for the modem and wireless in SDM845 platforms.

Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
---
 meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
index a7406e48de..3e03aafb6b 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
@@ -289,6 +289,7 @@  PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
              ${PN}-qcom-license \
              ${PN}-qcom-venus-1.8 ${PN}-qcom-venus-4.2 \
              ${PN}-qcom-adreno-a3xx ${PN}-qcom-adreno-a530 \
+             ${PN}-qcom-sdm845 \
              ${PN}-whence-license \
              ${PN}-license \
              "
@@ -848,10 +849,12 @@  FILES_${PN}-qcom-venus-1.8 = "${nonarch_base_libdir}/firmware/qcom/venus-1.8/*"
 FILES_${PN}-qcom-venus-4.2 = "${nonarch_base_libdir}/firmware/qcom/venus-4.2/*"
 FILES_${PN}-qcom-adreno-a3xx = "${nonarch_base_libdir}/firmware/qcom/a300_*.fw ${nonarch_base_libdir}/firmware/a300_*.fw"
 FILES_${PN}-qcom-adreno-a530 = "${nonarch_base_libdir}/firmware/qcom/a530*.*"
+FILES_${PN}-qcom-sdm845 = "${nonarch_base_libdir}/firmware/qcom/sdm845/*"
 RDEPENDS_${PN}-qcom-venus-1.8 = "${PN}-qcom-license"
 RDEPENDS_${PN}-qcom-venus-4.2 = "${PN}-qcom-license"
 RDEPENDS_${PN}-qcom-adreno-a3xx = "${PN}-qcom-license"
 RDEPENDS_${PN}-qcom-adreno-a530 = "${PN}-qcom-license"
+RDEPENDS_${PN}-qcom-sdm845 = "${PN}-qcom-license"
 
 FILES_${PN}-liquidio = "${nonarch_base_libdir}/firmware/liquidio"
 

Comments

Nicolas Dechesne March 31, 2020, 1:31 p.m.
On Tue, Mar 31, 2020 at 4:01 AM Aníbal Limón <anibal.limon@linaro.org>
wrote:

> Contains the firmware for the modem and wireless in SDM845 platforms.
>

it is more than that, since that folder contains also the audio and compute
DSP firmware, so we should either say that , or not include them.


> Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
> b/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
> index a7406e48de..3e03aafb6b 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
> @@ -289,6 +289,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
>               ${PN}-qcom-license \
>               ${PN}-qcom-venus-1.8 ${PN}-qcom-venus-4.2 \
>               ${PN}-qcom-adreno-a3xx ${PN}-qcom-adreno-a530 \
> +             ${PN}-qcom-sdm845 \
>               ${PN}-whence-license \
>               ${PN}-license \
>               "
> @@ -848,10 +849,12 @@ FILES_${PN}-qcom-venus-1.8 =
> "${nonarch_base_libdir}/firmware/qcom/venus-1.8/*"
>  FILES_${PN}-qcom-venus-4.2 =
> "${nonarch_base_libdir}/firmware/qcom/venus-4.2/*"
>  FILES_${PN}-qcom-adreno-a3xx =
> "${nonarch_base_libdir}/firmware/qcom/a300_*.fw
> ${nonarch_base_libdir}/firmware/a300_*.fw"
>  FILES_${PN}-qcom-adreno-a530 =
> "${nonarch_base_libdir}/firmware/qcom/a530*.*"
> +FILES_${PN}-qcom-sdm845 = "${nonarch_base_libdir}/firmware/qcom/sdm845/*"
>

I think we should be specific for the files we include, using the wildcard
means we don't control/know what we are packaging. We could do several
packages for qcom-sdm845-modem, qcom-sdm845-audio, qcom-sdm845-compute, ...
which would be ideal.. but i am not sure how appropriate this is for
oe-core. but for the other qcom firmware, we package them by 'feature' (see
above).

 RDEPENDS_${PN}-qcom-venus-1.8 = "${PN}-qcom-license"
>  RDEPENDS_${PN}-qcom-venus-4.2 = "${PN}-qcom-license"
>  RDEPENDS_${PN}-qcom-adreno-a3xx = "${PN}-qcom-license"
>  RDEPENDS_${PN}-qcom-adreno-a530 = "${PN}-qcom-license"
> +RDEPENDS_${PN}-qcom-sdm845 = "${PN}-qcom-license"
>
>  FILES_${PN}-liquidio = "${nonarch_base_libdir}/firmware/liquidio"
>
> --
> 2.26.0
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#136881): https://lists.openembedded.org/g/openembedded-core/message/136881
Mute This Topic: https://lists.openembedded.org/mt/72669191/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-
Aníbal Limón March 31, 2020, 7:05 p.m.
On Tue, 31 Mar 2020 at 07:31, Nicolas Dechesne <nicolas.dechesne@linaro.org>
wrote:

>
>
> On Tue, Mar 31, 2020 at 4:01 AM Aníbal Limón <anibal.limon@linaro.org>
> wrote:
>
>> Contains the firmware for the modem and wireless in SDM845 platforms.
>>
>
> it is more than that, since that folder contains also the audio and
> compute DSP firmware, so we should either say that , or not include them.
>
>
>> Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
>> ---
>>  meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-kernel/linux-firmware/
>> linux-firmware_20200122.bb b/meta/recipes-kernel/linux-firmware/
>> linux-firmware_20200122.bb
>> index a7406e48de..3e03aafb6b 100644
>> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
>> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20200122.bb
>> @@ -289,6 +289,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
>>               ${PN}-qcom-license \
>>               ${PN}-qcom-venus-1.8 ${PN}-qcom-venus-4.2 \
>>               ${PN}-qcom-adreno-a3xx ${PN}-qcom-adreno-a530 \
>> +             ${PN}-qcom-sdm845 \
>>               ${PN}-whence-license \
>>               ${PN}-license \
>>               "
>> @@ -848,10 +849,12 @@ FILES_${PN}-qcom-venus-1.8 =
>> "${nonarch_base_libdir}/firmware/qcom/venus-1.8/*"
>>  FILES_${PN}-qcom-venus-4.2 =
>> "${nonarch_base_libdir}/firmware/qcom/venus-4.2/*"
>>  FILES_${PN}-qcom-adreno-a3xx =
>> "${nonarch_base_libdir}/firmware/qcom/a300_*.fw
>> ${nonarch_base_libdir}/firmware/a300_*.fw"
>>  FILES_${PN}-qcom-adreno-a530 =
>> "${nonarch_base_libdir}/firmware/qcom/a530*.*"
>> +FILES_${PN}-qcom-sdm845 = "${nonarch_base_libdir}/firmware/qcom/sdm845/*"
>>
>
> I think we should be specific for the files we include, using the wildcard
> means we don't control/know what we are packaging. We could do several
> packages for qcom-sdm845-modem, qcom-sdm845-audio, qcom-sdm845-compute, ...
> which would be ideal.. but i am not sure how appropriate this is for
> oe-core. but for the other qcom firmware, we package them by 'feature' (see
> above).
>

Right, better to have a split of firmware by feature, I will send a v2.

Anibal

>
>  RDEPENDS_${PN}-qcom-venus-1.8 = "${PN}-qcom-license"
>>  RDEPENDS_${PN}-qcom-venus-4.2 = "${PN}-qcom-license"
>>  RDEPENDS_${PN}-qcom-adreno-a3xx = "${PN}-qcom-license"
>>  RDEPENDS_${PN}-qcom-adreno-a530 = "${PN}-qcom-license"
>> +RDEPENDS_${PN}-qcom-sdm845 = "${PN}-qcom-license"
>>
>>  FILES_${PN}-liquidio = "${nonarch_base_libdir}/firmware/liquidio"
>>
>> --
>> 2.26.0
>>
>>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#136893): https://lists.openembedded.org/g/openembedded-core/message/136893
Mute This Topic: https://lists.openembedded.org/mt/72669191/3617530
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  [oe-patchwork@oe-patch.openembedded.org]
-=-=-=-=-=-=-=-=-=-=-=-