gdb: add PACKAGECONFIG for xz (lzma) compression support

Submitted by Callaghan, Dan on Jan. 20, 2020, 11:48 p.m. | Patch ID: 169268

Details

Message ID 20200120234818.13068-1-dan.callaghan@opengear.com
State Superseded
Headers show

Commit Message

Callaghan, Dan Jan. 20, 2020, 11:48 p.m.
Similar to elfutils, when xz support is built into gdb it will be able
to read xz-compressed ELF sections containing debuginfo. This is used by
the "mini debuginfo" format:

https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
---
 meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 08f615addf..5d670561b0 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -21,7 +21,7 @@  EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
 
 EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
                 --with-curses --disable-multilib --disable-sim \
-                --without-lzma --without-guile \
+                --without-guile \
                 ${GDBPROPREFIX} ${EXPAT} \
                 ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
                 --disable-rpath \
@@ -37,6 +37,7 @@  PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
 PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
 # ncurses is already a hard DEPENDS, but would be added here if it weren't
 PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
+PACKAGECONFIG[xz] = "--with-lzma,--without-lzma"
 
 GDBPROPREFIX = "--program-prefix=''"
 

Comments

Richard Purdie Jan. 21, 2020, 12:04 a.m.
On Tue, 2020-01-21 at 09:48 +1000, Dan Callaghan wrote:
> Similar to elfutils, when xz support is built into gdb it will be able
> to read xz-compressed ELF sections containing debuginfo. This is used by
> the "mini debuginfo" format:
> 
> https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> ---
>  meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 08f615addf..5d670561b0 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
>  
>  EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
>                  --with-curses --disable-multilib --disable-sim \
> -                --without-lzma --without-guile \
> +                --without-guile \
>                  ${GDBPROPREFIX} ${EXPAT} \
>                  ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>                  --disable-rpath \
> @@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
>  PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
>  # ncurses is already a hard DEPENDS, but would be added here if it weren't
>  PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
> +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma"
>  
>  GDBPROPREFIX = "--program-prefix=''"

Is there an extra DEPENDS needed when enabling this?

Cheers,

Richard
Callaghan, Dan Jan. 21, 2020, 12:19 a.m.
Excerpts from Richard Purdie's message of 2020-01-21 00:04:53 +00:00:
> Is there an extra DEPENDS needed when enabling this?

Oops, yes it should really pull in xz. I missed this because xz is 
already a transitive dependency through something else. Will post a new 
patch.
Callaghan, Dan Jan. 21, 2020, 12:25 p.m.
This is a system generated Comment: Patch 169268 was automatically marked as superseded by patch 169270.