[1/2] qemuboot-mips: Enable VGA device

Submitted by Khem Raj on Jan. 10, 2020, 5:29 p.m. | Patch ID: 168797

Details

Message ID 20200110172938.3060002-1-raj.khem@gmail.com
State Master Next
Commit f29c06c293f0a15ab36a27b6533765f583310746
Headers show

Commit Message

Khem Raj Jan. 10, 2020, 5:29 p.m.
This helps in booting weston images ( core-image-weston ) with fbdev
backend, without this westons initialization of fbdev backend fails
because it does not get correct frame buffer settings and exits
pre-maturely

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta/conf/machine/include/qemuboot-mips.inc b/meta/conf/machine/include/qemuboot-mips.inc
index 978820a2e0..52cb28a5d2 100644
--- a/meta/conf/machine/include/qemuboot-mips.inc
+++ b/meta/conf/machine/include/qemuboot-mips.inc
@@ -5,3 +5,8 @@  QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run out of entropy
 QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0 -device virtio-rng-pci,rng=rng0"
+
+# For graphics to work we need to define the VGA device as well as the necessary USB devices
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
+

Comments

Richard Purdie Jan. 11, 2020, 9:16 a.m.
On Fri, 2020-01-10 at 09:29 -0800, Khem Raj wrote:
> This helps in booting weston images ( core-image-weston ) with fbdev
> backend, without this westons initialization of fbdev backend fails
> because it does not get correct frame buffer settings and exits
> pre-maturely
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/conf/machine/include/qemuboot-mips.inc b/meta/conf/machine/include/qemuboot-mips.inc
> index 978820a2e0..52cb28a5d2 100644
> --- a/meta/conf/machine/include/qemuboot-mips.inc
> +++ b/meta/conf/machine/include/qemuboot-mips.inc
> @@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
>  QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
>  # Add the 'virtio-rng-pci' device otherwise the guest may run out of entropy
>  QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0 -device virtio-rng-pci,rng=rng0"
> +
> +# For graphics to work we need to define the VGA device as well as the necessary USB devices
> +QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
> +QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
> +

The change is probably good but it causes consistent failures in out
testimage runs for mips and mips64:

https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431

all due to errors appearing in the logs.

Cheers,

Richard
Khem Raj Jan. 11, 2020, 8:25 p.m.
On Sat, Jan 11, 2020 at 1:16 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2020-01-10 at 09:29 -0800, Khem Raj wrote:
> > This helps in booting weston images ( core-image-weston ) with fbdev
> > backend, without this westons initialization of fbdev backend fails
> > because it does not get correct frame buffer settings and exits
> > pre-maturely
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/conf/machine/include/qemuboot-mips.inc
> b/meta/conf/machine/include/qemuboot-mips.inc
> > index 978820a2e0..52cb28a5d2 100644
> > --- a/meta/conf/machine/include/qemuboot-mips.inc
> > +++ b/meta/conf/machine/include/qemuboot-mips.inc
> > @@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
> >  QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
> >  # Add the 'virtio-rng-pci' device otherwise the guest may run out of
> entropy
> >  QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0
> -device virtio-rng-pci,rng=rng0"
> > +
> > +# For graphics to work we need to define the VGA device as well as the
> necessary USB devices
> > +QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
> > +QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
> > +
>
> The change is probably good but it causes consistent failures in out
> testimage runs for mips and mips64:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
> https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
> https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431
>
> all due to errors appearing in the logs.


Is it due to glibc 2.31 that we were discussing or a separate issue

>
>
> Cheers,
>
> Richard
>
>
Richard Purdie Jan. 11, 2020, 11:44 p.m.
On Sat, 2020-01-11 at 12:25 -0800, Khem Raj wrote:
> 
> 
> On Sat, Jan 11, 2020 at 1:16 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2020-01-10 at 09:29 -0800, Khem Raj wrote:
> > > This helps in booting weston images ( core-image-weston ) with
> > fbdev
> > > backend, without this westons initialization of fbdev backend
> > fails
> > > because it does not get correct frame buffer settings and exits
> > > pre-maturely
> > > 
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/meta/conf/machine/include/qemuboot-mips.inc
> > b/meta/conf/machine/include/qemuboot-mips.inc
> > > index 978820a2e0..52cb28a5d2 100644
> > > --- a/meta/conf/machine/include/qemuboot-mips.inc
> > > +++ b/meta/conf/machine/include/qemuboot-mips.inc
> > > @@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0
> > console=tty"
> > >  QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
> > >  # Add the 'virtio-rng-pci' device otherwise the guest may run
> > out of entropy
> > >  QB_OPT_APPEND += "-object rng-
> > random,filename=/dev/urandom,id=rng0 -device virtio-rng-
> > pci,rng=rng0"
> > > +
> > > +# For graphics to work we need to define the VGA device as well
> > as the necessary USB devices
> > > +QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
> > > +QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device
> > usb-kbd"
> > > +
> > 
> > The change is probably good but it causes consistent failures in
> > out
> > testimage runs for mips and mips64:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431
> > 
> > all due to errors appearing in the logs.
> 
> Is it due to glibc 2.31 that we were discussing or a separate issue 

Separate, there are two issues.

Cheers,

Richard
Khem Raj Jan. 12, 2020, 4:50 a.m.
OK I can reproduce atleast couple of them

On Sat, Jan 11, 2020 at 3:44 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sat, 2020-01-11 at 12:25 -0800, Khem Raj wrote:
> >
> >
> > On Sat, Jan 11, 2020 at 1:16 AM Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > On Fri, 2020-01-10 at 09:29 -0800, Khem Raj wrote:
> > > > This helps in booting weston images ( core-image-weston ) with
> > > fbdev
> > > > backend, without this westons initialization of fbdev backend
> > > fails
> > > > because it does not get correct frame buffer settings and exits
> > > > pre-maturely
> > > >
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > >  meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/meta/conf/machine/include/qemuboot-mips.inc
> > > b/meta/conf/machine/include/qemuboot-mips.inc
> > > > index 978820a2e0..52cb28a5d2 100644
> > > > --- a/meta/conf/machine/include/qemuboot-mips.inc
> > > > +++ b/meta/conf/machine/include/qemuboot-mips.inc
> > > > @@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0
> > > console=tty"
> > > >  QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
> > > >  # Add the 'virtio-rng-pci' device otherwise the guest may run
> > > out of entropy
> > > >  QB_OPT_APPEND += "-object rng-
> > > random,filename=/dev/urandom,id=rng0 -device virtio-rng-
> > > pci,rng=rng0"
> > > > +
> > > > +# For graphics to work we need to define the VGA device as well
> > > as the necessary USB devices
> > > > +QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
> > > > +QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device
> > > usb-kbd"
> > > > +
> > >
> > > The change is probably good but it causes consistent failures in
> > > out
> > > testimage runs for mips and mips64:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431
> > >
> > > all due to errors appearing in the logs.
> >
> > Is it due to glibc 2.31 that we were discussing or a separate issue
>
> Separate, there are two issues.
>
> Cheers,
>
> Richard
>