diff mbox series

[v2] CI: define DEFAULT_TAG and CPU_REQUEST

Message ID 20221215152415.6537-1-jon.mason@arm.com
State New
Headers show
Series [v2] CI: define DEFAULT_TAG and CPU_REQUEST | expand

Commit Message

Jon Mason Dec. 15, 2022, 3:24 p.m. UTC
DEFAULT_TAG and CPU_REQUEST are being used to help with internal Gitlab
pipeline setups know which type of machines to run on, but has no value
outside of Arm Corp.  Gitlab CI allows for variables to be overridden
by default.  So, we can give it a default value of NULL/empty and have
everything work internally and externally by default.

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 .gitlab-ci.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jon Mason Dec. 16, 2022, 2:12 p.m. UTC | #1
On Thu, 15 Dec 2022 10:24:15 -0500, Jon Mason wrote:
> DEFAULT_TAG and CPU_REQUEST are being used to help with internal Gitlab
> pipeline setups know which type of machines to run on, but has no value
> outside of Arm Corp.  Gitlab CI allows for variables to be overridden
> by default.  So, we can give it a default value of NULL/empty and have
> everything work internally and externally by default.

Applied, thanks!

[1/1] CI: define DEFAULT_TAG and CPU_REQUEST
      commit: c32c4043ff6fade1ec96ce1381512fbf7ce771e5

Best regards,
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6ee42315..cc5710c2 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,8 +1,10 @@ 
 image: ghcr.io/siemens/kas/kas:latest-release
 
-# These are needed as the k8s executor doesn't respect the container entrypoint
-# by default
 variables:
+  CPU_REQUEST: ""
+  DEFAULT_TAG: ""
+  # These are needed as the k8s executor doesn't respect the container entrypoint
+  # by default
   FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: 0
   FF_KUBERNETES_HONOR_ENTRYPOINT: 1