diff mbox series

process: log odd unlink events with bitbake.sock

Message ID 20221214160946.19456-1-debrabander@gmail.com
State Accepted, archived
Commit cfd7c9899f988bab6d9fe7bbfbdb60603fb5ed34
Headers show
Series process: log odd unlink events with bitbake.sock | expand

Commit Message

Frank de Brabander Dec. 14, 2022, 4:09 p.m. UTC 
Log when the socket file already exists and is removed before
recreating a new socket.

Log when unlinking the socket file failed.

Signed-off-by: Frank de Brabander <debrabander@gmail.com>
---
 lib/bb/server/process.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 44c65451..12498a6c 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -278,8 +278,8 @@  class ProcessServer():
         # Remove the socket file so we don't get any more connections to avoid races
         try:
             os.unlink(self.sockname)
-        except:
-            pass
+        except Exception as err:
+            serverlog("Removing socket file '%s' failed (%s)" % (self.sockname, err))
         self.sock.close()
 
         try:
@@ -543,6 +543,7 @@  def execServer(lockfd, readypipeinfd, lockname, sockname, server_timeout, xmlrpc
 
         # Create server control socket
         if os.path.exists(sockname):
+            serverlog("WARNING: removing existing socket file '%s'" % sockname)
             os.unlink(sockname)
 
         sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)