[bitbake-devel] bitbake/runqueue: don't shout about hash updates

Submitted by Ross Burton on Oct. 23, 2019, 3:33 p.m. | Patch ID: 166066

Details

Message ID 20191023153339.2313-1-ross.burton@intel.com
State New
Headers show

Commit Message

Ross Burton Oct. 23, 2019, 3:33 p.m.
With hash equivalency enabled the runqueue logs at level info quite heavily,
which spams the console.

Reduce the log level down to debug so it's there if needed but doesn't get in
the way.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 bitbake/lib/bb/runqueue.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 18049436fd5..e1eaf49b8cd 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -2361,7 +2361,7 @@  class RunQueueExecute:
             if tid in self.build_stamps:
                 del self.build_stamps[tid]
 
-            logger.info("Setscene task %s now valid and being rerun" % tid)
+            logger.debug(2, "Setscene task %s now valid and being rerun" % tid)
             self.sqdone = False
             update_scenequeue_data([tid], self.sqdata, self.rqdata, self.rq, self.cooker, self.stampcache, self)
 

Comments

Mark Hatle Oct. 23, 2019, 3:37 p.m.
This was from a patch the other day:

-                bb.warn("Deferring %s after %s" % (tid, sqdata.hashes[h]))
+                bb.note("Deferring %s after %s" % (tid, sqdata.hashes[h]))

Is that also debug, or is it really something to be displayed?  (Same file.)

--Mark

On 10/23/19 10:33 AM, Ross Burton wrote:
> With hash equivalency enabled the runqueue logs at level info quite heavily,
> which spams the console.
> 
> Reduce the log level down to debug so it's there if needed but doesn't get in
> the way.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  bitbake/lib/bb/runqueue.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index 18049436fd5..e1eaf49b8cd 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -2361,7 +2361,7 @@ class RunQueueExecute:
>              if tid in self.build_stamps:
>                  del self.build_stamps[tid]
>  
> -            logger.info("Setscene task %s now valid and being rerun" % tid)
> +            logger.debug(2, "Setscene task %s now valid and being rerun" % tid)
>              self.sqdone = False
>              update_scenequeue_data([tid], self.sqdata, self.rqdata, self.rq, self.cooker, self.stampcache, self)
>  
>
Richard Purdie Oct. 23, 2019, 9:56 p.m.
On Wed, 2019-10-23 at 10:37 -0500, Mark Hatle wrote:
> This was from a patch the other day:
> 
> -                bb.warn("Deferring %s after %s" % (tid,
> sqdata.hashes[h]))
> +                bb.note("Deferring %s after %s" % (tid,
> sqdata.hashes[h]))
> 
> Is that also debug, or is it really something to be displayed?  (Same
> file.)

The more of this we hide on the console, the harder debugging any
failures will be. Debugging this code is a total nightmare so if people
want help with sorting failures we will have to put up with some
verbosity for now.

I merged the above since it is useful to know you have an overlapping
build and the code is working.

I agree that bitbake is too chatty about the other message Ross has
posted about but I want to ensure we are printing the useful event info
we need before I merge that or something similar.

Cheers,

Richard