[meta-oe] polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
  /usr/lib/polkit-1/polkit-agent-helper-1
  /usr/lib/polkit-1/polkitd
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
polkit: 2 installed and not shipped files. [installed-vs-shipped]

Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
---
 meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of leimaohui
> Sent: den 7 december 2022 04:14
> To: openembedded-devel@lists.openembedded.org
> Cc: Lei Maohui <leimaohui@fujitsu.com>
> Subject: [oe] [meta-oe][PATCH] polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

That is a very long subject, way longer than the recommendations.
I suggest you change it to something shorter, e.g.: 

  polkit: Make it build with multilib

> 
> ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
>   /usr/lib/polkit-1/polkit-agent-helper-1
>   /usr/lib/polkit-1/polkitd
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> polkit: 2 installed and not shipped files. [installed-vs-shipped]
> 
> Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
> ---
>  meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-extended/polkit/polkit_122.bb b/meta-oe/recipes-extended/polkit/polkit_122.bb
> index dfa6c14a4..a7cfbdd62 100644
> --- a/meta-oe/recipes-extended/polkit/polkit_122.bb
> +++ b/meta-oe/recipes-extended/polkit/polkit_122.bb
> @@ -46,4 +46,6 @@ do_install:append() {
>  	chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
>  }
> 
> -FILES:${PN} += "${libdir}/polkit-1 ${datadir}"
> +FILES:${PN} += "${libdir}/polkit-1 ${datadir} \
> +                ${nonarch_libdir}/${BPN}-1 \
> +               "

It would be more obvious what's going on if you change the above to:

FILES:${PN} += "${libdir}/polkit-1 ${nonarch_libdir}/polkit-1 ${datadir}"

> --
> 2.25.1

//Peter

Thanks for review Peter, I have made these changes on master-next

On Thu, Dec 8, 2022 at 4:07 PM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> > -----Original Message-----
> > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of leimaohui
> > Sent: den 7 december 2022 04:14
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Lei Maohui <leimaohui@fujitsu.com>
> > Subject: [oe] [meta-oe][PATCH] polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.
>
> That is a very long subject, way longer than the recommendations.
> I suggest you change it to something shorter, e.g.:
>
>   polkit: Make it build with multilib
>
> >
> > ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
> >   /usr/lib/polkit-1/polkit-agent-helper-1
> >   /usr/lib/polkit-1/polkitd
> > Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> > polkit: 2 installed and not shipped files. [installed-vs-shipped]
> >
> > Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
> > ---
> >  meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-extended/polkit/polkit_122.bb b/meta-oe/recipes-extended/polkit/polkit_122.bb
> > index dfa6c14a4..a7cfbdd62 100644
> > --- a/meta-oe/recipes-extended/polkit/polkit_122.bb
> > +++ b/meta-oe/recipes-extended/polkit/polkit_122.bb
> > @@ -46,4 +46,6 @@ do_install:append() {
> >       chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
> >  }
> >
> > -FILES:${PN} += "${libdir}/polkit-1 ${datadir}"
> > +FILES:${PN} += "${libdir}/polkit-1 ${datadir} \
> > +                ${nonarch_libdir}/${BPN}-1 \
> > +               "
>
> It would be more obvious what's going on if you change the above to:
>
> FILES:${PN} += "${libdir}/polkit-1 ${nonarch_libdir}/polkit-1 ${datadir}"
>
> > --
> > 2.25.1
>
> //Peter
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#100000): https://lists.openembedded.org/g/openembedded-devel/message/100000
> Mute This Topic: https://lists.openembedded.org/mt/95509198/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>