[meta-oe,thud] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules

Submitted by Arturo Buzarra on Aug. 2, 2019, 7:02 a.m. | Patch ID: 163589

Details

Message ID 20190802070221.15706-1-arturo.buzarra@digi.com
State Superseded
Delegated to: Armin Kuster
Headers show

Commit Message

Arturo Buzarra Aug. 2, 2019, 7:02 a.m.
Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
a package dependency due to lvm2-udevrules needs dmsetup, however
dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2:
libdevicemapper package needs udev rules and dmsetup"), so this
dependency should be only for libdevmapper instead of the full package.

With the current implementation, a package that has a dependency with
lvm2-udev rules will include also many unnecessary packages like lvm2,
lvm2-scripts, etc. and their dependencies.

Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
---
 meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
index 7bd7b09d8..08287e358 100644
--- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
+++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
@@ -48,11 +48,11 @@  FILES_${PN}-scripts = " \
     ${sbindir}/lvmdump \
 "
 # Specified explicitly for the udev rules, just in case that it does not get picked
 # up automatically:
 FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
-RDEPENDS_${PN}-udevrules = "${PN}"
+RDEPENDS_${PN}-udevrules = "libdevmapper"
 RDEPENDS_${PN}_append_class-target = " libdevmapper"
 RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
 
 RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
 RRECOMMENDS_${PN}_class-target = "${PN}-scripts (= ${EXTENDPKGV})"

Comments

Khem Raj Aug. 2, 2019, 6:42 p.m.
can you send it rebased on top of master

On Fri, Aug 2, 2019 at 12:02 AM Arturo Buzarra <arturo.buzarra@digi.com> wrote:
>
> Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
> a package dependency due to lvm2-udevrules needs dmsetup, however
> dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2:
> libdevicemapper package needs udev rules and dmsetup"), so this
> dependency should be only for libdevmapper instead of the full package.
>
> With the current implementation, a package that has a dependency with
> lvm2-udev rules will include also many unnecessary packages like lvm2,
> lvm2-scripts, etc. and their dependencies.
>
> Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> index 7bd7b09d8..08287e358 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> +++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> @@ -48,11 +48,11 @@ FILES_${PN}-scripts = " \
>      ${sbindir}/lvmdump \
>  "
>  # Specified explicitly for the udev rules, just in case that it does not get picked
>  # up automatically:
>  FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
> -RDEPENDS_${PN}-udevrules = "${PN}"
> +RDEPENDS_${PN}-udevrules = "libdevmapper"
>  RDEPENDS_${PN}_append_class-target = " libdevmapper"
>  RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
>
>  RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
>  RRECOMMENDS_${PN}_class-target = "${PN}-scripts (= ${EXTENDPKGV})"
> --
> 2.22.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Arturo Buzarra Aug. 5, 2019, 6:24 p.m.
This is a system generated Comment: Patch 163589 was automatically marked as superseded by patch 163673.