[meta-networking,1/1] drbd-utils: enable reproducible_build awareness

Submitted by Slater, Joseph on July 10, 2019, 11:56 p.m. | Patch ID: 162976

Details

Message ID 20190710235657.97551-1-joe.slater@windriver.com
State Accepted
Commit dfbcacc79577300a53ba3d77a7915bf86145b608
Headers show

Commit Message

Slater, Joseph July 10, 2019, 11:56 p.m.
Enable use of SOURCE_DATE_EPOCH from the reproducible_build bbclass.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
index 70e04b9..7fd3090 100644
--- a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
+++ b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
@@ -35,6 +35,9 @@  EXTRA_OECONF = " \
                 --without-manual \
                "
 
+# If we have inherited reproducible_build, we want to use it.
+export WANT_DRBD_REPRODUCIBLE_BUILD = "yes"
+
 do_configure_prepend() {
     # move the the file under folder /lib/drbd/ to /usr/lib/drbd when usrmerge enabled
     if ${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', 'true', 'false', d)}; then

Comments

Khem Raj July 11, 2019, 7:33 a.m.
On Wed, Jul 10, 2019 at 4:57 PM Joe Slater <joe.slater@windriver.com> wrote:
>
> Enable use of SOURCE_DATE_EPOCH from the reproducible_build bbclass.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
>  meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> index 70e04b9..7fd3090 100644
> --- a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> +++ b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> @@ -35,6 +35,9 @@ EXTRA_OECONF = " \
>                  --without-manual \
>                 "
>
> +# If we have inherited reproducible_build, we want to use it.
> +export WANT_DRBD_REPRODUCIBLE_BUILD = "yes"

should this be set after checking for inherit ?
> +
>  do_configure_prepend() {
>      # move the the file under folder /lib/drbd/ to /usr/lib/drbd when usrmerge enabled
>      if ${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', 'true', 'false', d)}; then
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Slater, Joseph July 11, 2019, 5:13 p.m.
> -----Original Message-----
> From: Khem Raj [mailto:raj.khem@gmail.com]
> Sent: Thursday, July 11, 2019 12:33 AM
> To: Slater, Joseph
> Cc: openembeded-devel
> Subject: Re: [oe] [meta-networking][PATCH 1/1] drbd-utils: enable
> reproducible_build awareness
> 
> On Wed, Jul 10, 2019 at 4:57 PM Joe Slater <joe.slater@windriver.com>
> wrote:
> >
> > Enable use of SOURCE_DATE_EPOCH from the reproducible_build bbclass.
> >
> > Signed-off-by: Joe Slater <joe.slater@windriver.com>
> > ---
> >  meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > index 70e04b9..7fd3090 100644
> > --- a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > +++ b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > @@ -35,6 +35,9 @@ EXTRA_OECONF = " \
> >                  --without-manual \
> >                 "
> >
> > +# If we have inherited reproducible_build, we want to use it.
> > +export WANT_DRBD_REPRODUCIBLE_BUILD = "yes"
> 
> should this be set after checking for inherit 

[Joe Slater] This variable is always queried and the code checks for a reproducible_build environment, so we don't need to test here.

> > +
> >  do_configure_prepend() {
> >      # move the the file under folder /lib/drbd/ to /usr/lib/drbd when
> usrmerge enabled
> >      if ${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', 'true', 'false', d)};
> then
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj July 11, 2019, 5:47 p.m.
Ok, thanks.

On Thu, Jul 11, 2019 at 10:14 AM Slater, Joseph <joe.slater@windriver.com>
wrote:

>
>
> > -----Original Message-----
> > From: Khem Raj [mailto:raj.khem@gmail.com]
> > Sent: Thursday, July 11, 2019 12:33 AM
> > To: Slater, Joseph
> > Cc: openembeded-devel
> > Subject: Re: [oe] [meta-networking][PATCH 1/1] drbd-utils: enable
> > reproducible_build awareness
> >
> > On Wed, Jul 10, 2019 at 4:57 PM Joe Slater <joe.slater@windriver.com>
> > wrote:
> > >
> > > Enable use of SOURCE_DATE_EPOCH from the reproducible_build bbclass.
> > >
> > > Signed-off-by: Joe Slater <joe.slater@windriver.com>
> > > ---
> > >  meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > > index 70e04b9..7fd3090 100644
> > > --- a/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > > +++ b/meta-networking/recipes-support/drbd/drbd-utils_9.10.0.bb
> > > @@ -35,6 +35,9 @@ EXTRA_OECONF = " \
> > >                  --without-manual \
> > >                 "
> > >
> > > +# If we have inherited reproducible_build, we want to use it.
> > > +export WANT_DRBD_REPRODUCIBLE_BUILD = "yes"
> >
> > should this be set after checking for inherit
>
> [Joe Slater] This variable is always queried and the code checks for a
> reproducible_build environment, so we don't need to test here.
>
> > > +
> > >  do_configure_prepend() {
> > >      # move the the file under folder /lib/drbd/ to /usr/lib/drbd when
> > usrmerge enabled
> > >      if ${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', 'true',
> 'false', d)};
> > then
> > > --
> > > 2.7.4
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>