[bitbake-devel,20/26] runqueue: Further scheduler buildable tasks cleanup

Submitted by Richard Purdie on July 10, 2019, 11:54 p.m. | Patch ID: 162968

Details

Message ID 20190710235420.23825-20-richard.purdie@linuxfoundation.org
State Accepted
Commit ce3cd2df5b034f8dbdcf9834e8b9a393b6b01aad
Headers show

Commit Message

Richard Purdie July 10, 2019, 11:54 p.m.
The code for setting up buildable tasks can be simplified.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/runqueue.py | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Patch hide | download patch | download mbox

diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index 97c825a546..580323f285 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -196,11 +196,6 @@  class RunQueueScheduler(object):
         if self.rq.can_start_task():
             return self.next_buildable_task()
 
-    def initbuildable(self):
-        for tid in self.rqdata.runtaskentries:
-            if tid in self.rq.runq_buildable:
-                self.buildable.append(tid)
-
     def newbuildable(self, task):
         self.buildable.append(task)
 
@@ -2493,7 +2488,7 @@  def start_runqueue_tasks(rqexec):
         # Mark initial buildable tasks
         for tid in rqexec.rqdata.runtaskentries:
             if len(rqexec.rqdata.runtaskentries[tid].depends) == 0:
-                rqexec.runq_buildable.add(tid)
+                rqexec.setbuildable(tid)
             if len(rqexec.rqdata.runtaskentries[tid].revdeps) > 0 and rqexec.rqdata.runtaskentries[tid].revdeps.issubset(rqexec.scenequeue_covered):
                 rqexec.scenequeue_covered.add(tid)
 
@@ -2516,8 +2511,6 @@  def start_runqueue_tasks(rqexec):
         for task in self.rq.scenequeue_notcovered:
             logger.debug(1, 'Not skipping task %s', task)
 
-        rqexec.sched.initbuildable()
-
 class TaskFailure(Exception):
     """
     Exception raised when a task in a runqueue fails