go.bbclass: remove ptest inherit

Submitted by mingli.yu@windriver.com on July 3, 2019, 9:24 a.m. | Patch ID: 162759

Details

Message ID 20190703092412.30747-1-mingli.yu@windriver.com
State New
Headers show

Commit Message

mingli.yu@windriver.com July 3, 2019, 9:24 a.m.
From: Mingli Yu <mingli.yu@windriver.com>

Remove the ptest bbclass inherit logic to let
each recipe inherit ptest individually if the
specified recipe wants to support ptest to avoid
the recipe which inherits go bblcass inheriting
ptest automatically.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/classes/go.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index e05a5c641c..424d869540 100644
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -1,4 +1,4 @@ 
-inherit goarch ptest
+inherit goarch
 
 GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"
 

Comments

Matt Madison July 4, 2019, 12:38 p.m.
On Wed, Jul 3, 2019 at 2:25 AM <mingli.yu@windriver.com> wrote:
>
> From: Mingli Yu <mingli.yu@windriver.com>
>
> Remove the ptest bbclass inherit logic to let
> each recipe inherit ptest individually if the
> specified recipe wants to support ptest to avoid
> the recipe which inherits go bblcass inheriting
> ptest automatically.

Recipes will have to inherit ptest before inheriting go, which seems
counter-intuitive; with ptest after go, the compile_ptest and
install_ptest functions will be the null ones from ptest.bbclass.
Ross's suggestion of breaking out the ptest-related functions from
go.bbclass into a separate bbclass would be better.  Perhaps called
ptest-go.bbclass, similar to the ones already there for gnome and
perl.

Thanks,
-Matt

> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  meta/classes/go.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
> index e05a5c641c..424d869540 100644
> --- a/meta/classes/go.bbclass
> +++ b/meta/classes/go.bbclass
> @@ -1,4 +1,4 @@
> -inherit goarch ptest
> +inherit goarch
>
>  GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"
>
> --
> 2.21.0
>