openssl: Fix a build bug on aarch64BE.

Submitted by leimaohui on June 2, 2019, 12:22 a.m. | Patch ID: 162178

Details

Message ID 1559434935-11842-1-git-send-email-leimaohui@cn.fujitsu.com
State Superseded
Headers show

Commit Message

leimaohui June 2, 2019, 12:22 a.m.
From: Hong Liu <hongl.fnst@cn.fujitsu.com>

Fix bug as following on aarch64BE:

Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'

Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]

Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
---
 ...01-Fix-build-error-for-aarch64-big-endian.patch | 41 ++++++++++++++++++++++
 .../recipes-connectivity/openssl/openssl_1.1.1c.bb |  1 +
 2 files changed, 42 insertions(+)
 create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch

Patch hide | download patch | download mbox

diff --git a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
new file mode 100644
index 0000000..65ca02c
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
@@ -0,0 +1,41 @@ 
+From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001
+From: Lei Maohui <leimaohui@cn.fujitsu.com>
+Date: Thu, 13 Jun 2019 12:17:30 +0900
+Subject: [PATCH] Fix build error for aarch64 big endian.
+
+Modified rev to rev64, because rev only takes integer registers.
+https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
+Otherwise, the following error will occur.
+
+Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
+
+Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
+---
+ crypto/sha/asm/keccak1600-armv8.pl | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/crypto/sha/asm/keccak1600-armv8.pl b/crypto/sha/asm/keccak1600-armv8.pl
+index dc72f18..6620690 100755
+--- a/crypto/sha/asm/keccak1600-armv8.pl
++++ b/crypto/sha/asm/keccak1600-armv8.pl
+@@ -731,7 +731,7 @@ $code.=<<___;
+ 	blo	.Lprocess_block_ce
+ 	ldr	d31,[$inp],#8		// *inp++
+ #ifdef	__AARCH64EB__
+-	rev	v31.16b,v31.16b
++	rev64	v31.16b,v31.16b
+ #endif
+ 	eor	$A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b
+ 	beq	.Lprocess_block_ce
+@@ -740,7 +740,7 @@ ___
+ $code.=<<___;
+ 	ldr	d31,[$inp],#8		// *inp++
+ #ifdef	__AARCH64EB__
+-	rev	v31.16b,v31.16b
++	rev64	v31.16b,v31.16b
+ #endif
+ 	eor	$A[4][4],$A[4][4],v31.16b
+ 
+-- 
+2.7.4
+
diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
index 669b1a1..ec85ccd 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
@@ -16,6 +16,7 @@  SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
            file://0001-skip-test_symbol_presence.patch \
            file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
            file://afalg.patch \
+           file://0001-Fix-build-error-for-aarch64-big-endian.patch \
            "
 
 SRC_URI_append_class-nativesdk = " \

Comments

Ross Burton June 13, 2019, 9:23 a.m.
On Thu, 13 Jun 2019 at 09:48, Lei Maohui <leimaohui@cn.fujitsu.com> wrote:
>
> From: Hong Liu <hongl.fnst@cn.fujitsu.com>
>
> Fix bug as following on aarch64BE:
>
> Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
>
> Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]

This line ^^^

> Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> ---
>  ...01-Fix-build-error-for-aarch64-big-endian.patch | 41 ++++++++++++++++++++++
>  .../recipes-connectivity/openssl/openssl_1.1.1c.bb |  1 +
>  2 files changed, 42 insertions(+)
>  create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
>
> diff --git a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> new file mode 100644
> index 0000000..65ca02c
> --- /dev/null
> +++ b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> @@ -0,0 +1,41 @@
> +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001
> +From: Lei Maohui <leimaohui@cn.fujitsu.com>
> +Date: Thu, 13 Jun 2019 12:17:30 +0900
> +Subject: [PATCH] Fix build error for aarch64 big endian.
> +
> +Modified rev to rev64, because rev only takes integer registers.
> +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
> +Otherwise, the following error will occur.
> +
> +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> +

^^ goes here.

The upstream status is a property of the patch you're adding, not the
commit message.

> +Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> +---
> + crypto/sha/asm/keccak1600-armv8.pl | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/crypto/sha/asm/keccak1600-armv8.pl b/crypto/sha/asm/keccak1600-armv8.pl
> +index dc72f18..6620690 100755
> +--- a/crypto/sha/asm/keccak1600-armv8.pl
> ++++ b/crypto/sha/asm/keccak1600-armv8.pl
> +@@ -731,7 +731,7 @@ $code.=<<___;
> +       blo     .Lprocess_block_ce
> +       ldr     d31,[$inp],#8           // *inp++
> + #ifdef        __AARCH64EB__
> +-      rev     v31.16b,v31.16b
> ++      rev64   v31.16b,v31.16b
> + #endif
> +       eor     $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b
> +       beq     .Lprocess_block_ce
> +@@ -740,7 +740,7 @@ ___
> + $code.=<<___;
> +       ldr     d31,[$inp],#8           // *inp++
> + #ifdef        __AARCH64EB__
> +-      rev     v31.16b,v31.16b
> ++      rev64   v31.16b,v31.16b
> + #endif
> +       eor     $A[4][4],$A[4][4],v31.16b
> +
> +--
> +2.7.4
> +
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> index 669b1a1..ec85ccd 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> @@ -16,6 +16,7 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
>             file://0001-skip-test_symbol_presence.patch \
>             file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
>             file://afalg.patch \
> +           file://0001-Fix-build-error-for-aarch64-big-endian.patch \
>             "
>
>  SRC_URI_append_class-nativesdk = " \
> --
> 2.7.4
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Alexander Kanavin June 13, 2019, 12:45 p.m.
Also if the patch is already submitted, the status should not be Pending.

Alex

On Thu, 13 Jun 2019 at 11:23, Burton, Ross <ross.burton@intel.com> wrote:

> On Thu, 13 Jun 2019 at 09:48, Lei Maohui <leimaohui@cn.fujitsu.com> wrote:
> >
> > From: Hong Liu <hongl.fnst@cn.fujitsu.com>
> >
> > Fix bug as following on aarch64BE:
> >
> > Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> >
> > Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]
>
> This line ^^^
>
> > Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > ---
> >  ...01-Fix-build-error-for-aarch64-big-endian.patch | 41
> ++++++++++++++++++++++
> >  .../recipes-connectivity/openssl/openssl_1.1.1c.bb |  1 +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644
> meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> >
> > diff --git
> a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> > new file mode 100644
> > index 0000000..65ca02c
> > --- /dev/null
> > +++
> b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> > @@ -0,0 +1,41 @@
> > +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001
> > +From: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +Date: Thu, 13 Jun 2019 12:17:30 +0900
> > +Subject: [PATCH] Fix build error for aarch64 big endian.
> > +
> > +Modified rev to rev64, because rev only takes integer registers.
> > +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
> > +Otherwise, the following error will occur.
> > +
> > +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> > +
>
> ^^ goes here.
>
> The upstream status is a property of the patch you're adding, not the
> commit message.
>
> > +Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +---
> > + crypto/sha/asm/keccak1600-armv8.pl | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/crypto/sha/asm/keccak1600-armv8.pl b/crypto/sha/asm/
> keccak1600-armv8.pl
> > +index dc72f18..6620690 100755
> > +--- a/crypto/sha/asm/keccak1600-armv8.pl
> > ++++ b/crypto/sha/asm/keccak1600-armv8.pl
> > +@@ -731,7 +731,7 @@ $code.=<<___;
> > +       blo     .Lprocess_block_ce
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b
> > +       beq     .Lprocess_block_ce
> > +@@ -740,7 +740,7 @@ ___
> > + $code.=<<___;
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[4][4],$A[4][4],v31.16b
> > +
> > +--
> > +2.7.4
> > +
> > diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > index 669b1a1..ec85ccd 100644
> > --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > @@ -16,6 +16,7 @@ SRC_URI = "
> http://www.openssl.org/source/openssl-${PV}.tar.gz \
> >             file://0001-skip-test_symbol_presence.patch \
> >
>  file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
> >             file://afalg.patch \
> > +           file://0001-Fix-build-error-for-aarch64-big-endian.patch \
> >             "
> >
> >  SRC_URI_append_class-nativesdk = " \
> > --
> > 2.7.4
> >
> >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
leimaohui June 14, 2019, 12:57 a.m.
Hi, Ross

Thank you. I got it. I will submit v2 patch.

Best regards 
Lei

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Thursday, June 13, 2019 5:24 PM
> To: Lei, Maohui
> Cc: OE-core; Hong Liu
> Subject: Re: [OE-core] [PATCH] openssl: Fix a build bug on aarch64BE.
> 
> On Thu, 13 Jun 2019 at 09:48, Lei Maohui <leimaohui@cn.fujitsu.com> wrote:
> >
> > From: Hong Liu <hongl.fnst@cn.fujitsu.com>
> >
> > Fix bug as following on aarch64BE:
> >
> > Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> >
> > Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]
> 
> This line ^^^
> 
> > Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > ---
> >  ...01-Fix-build-error-for-aarch64-big-endian.patch | 41
> ++++++++++++++++++++++
> >  .../recipes-connectivity/openssl/openssl_1.1.1c.bb |  1 +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-Fix-build-
> error-for-aarch64-big-endian.patch
> >
> > diff --git a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-
> for-aarch64-big-endian.patch b/meta/recipes-connectivity/openssl/openssl/0001-
> Fix-build-error-for-aarch64-big-endian.patch
> > new file mode 100644
> > index 0000000..65ca02c
> > --- /dev/null
> > +++ b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-
> aarch64-big-endian.patch
> > @@ -0,0 +1,41 @@
> > +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001
> > +From: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +Date: Thu, 13 Jun 2019 12:17:30 +0900
> > +Subject: [PATCH] Fix build error for aarch64 big endian.
> > +
> > +Modified rev to rev64, because rev only takes integer registers.
> > +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
> > +Otherwise, the following error will occur.
> > +
> > +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> > +
> 
> ^^ goes here.
> 
> The upstream status is a property of the patch you're adding, not the
> commit message.
> 
> > +Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +---
> > + crypto/sha/asm/keccak1600-armv8.pl | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/crypto/sha/asm/keccak1600-armv8.pl b/crypto/sha/asm/keccak1600-
> armv8.pl
> > +index dc72f18..6620690 100755
> > +--- a/crypto/sha/asm/keccak1600-armv8.pl
> > ++++ b/crypto/sha/asm/keccak1600-armv8.pl
> > +@@ -731,7 +731,7 @@ $code.=<<___;
> > +       blo     .Lprocess_block_ce
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b
> > +       beq     .Lprocess_block_ce
> > +@@ -740,7 +740,7 @@ ___
> > + $code.=<<___;
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[4][4],$A[4][4],v31.16b
> > +
> > +--
> > +2.7.4
> > +
> > diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > index 669b1a1..ec85ccd 100644
> > --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > @@ -16,6 +16,7 @@ SRC_URI = "http://www.openssl.org/source/openssl-
> ${PV}.tar.gz \
> >             file://0001-skip-test_symbol_presence.patch \
> >             file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-
> co.patch \
> >             file://afalg.patch \
> > +           file://0001-Fix-build-error-for-aarch64-big-endian.patch \
> >             "
> >
> >  SRC_URI_append_class-nativesdk = " \
> > --
> > 2.7.4
> >
> >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
leimaohui June 14, 2019, 12:59 a.m.
Hi, Alex


I refered to the previous patches. Should the Upstream-Status be “Submitted” ?





Best regards

Lei


From: Alexander Kanavin [mailto:alex.kanavin@gmail.com]

Sent: Thursday, June 13, 2019 8:45 PM
To: Burton, Ross
Cc: Lei, Maohui/雷 茂慧; Hong Liu; OE-core
Subject: Re: [OE-core] [PATCH] openssl: Fix a build bug on aarch64BE.

Also if the patch is already submitted, the status should not be Pending.

Alex

On Thu, 13 Jun 2019 at 11:23, Burton, Ross <ross.burton@intel.com<mailto:ross.burton@intel.com>> wrote:
On Thu, 13 Jun 2019 at 09:48, Lei Maohui <leimaohui@cn.fujitsu.com<mailto:leimaohui@cn.fujitsu.com>> wrote:
>

> From: Hong Liu <hongl.fnst@cn.fujitsu.com<mailto:hongl.fnst@cn.fujitsu.com>>

>

> Fix bug as following on aarch64BE:

>

> Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'

>

> Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]


This line ^^^

> Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com<mailto:leimaohui@cn.fujitsu.com>>

> ---

>  ...01-Fix-build-error-for-aarch64-big-endian.patch | 41 ++++++++++++++++++++++

>  .../recipes-connectivity/openssl/openssl_1.1.1c.bb<http://openssl_1.1.1c.bb> |  1 +

>  2 files changed, 42 insertions(+)

>  create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch

>

> diff --git a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch

> new file mode 100644

> index 0000000..65ca02c

> --- /dev/null

> +++ b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch

> @@ -0,0 +1,41 @@

> +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001

> +From: Lei Maohui <leimaohui@cn.fujitsu.com<mailto:leimaohui@cn.fujitsu.com>>

> +Date: Thu, 13 Jun 2019 12:17:30 +0900

> +Subject: [PATCH] Fix build error for aarch64 big endian.

> +

> +Modified rev to rev64, because rev only takes integer registers.

> +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827

> +Otherwise, the following error will occur.

> +

> +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'

> +


^^ goes here.

The upstream status is a property of the patch you're adding, not the
commit message.

> +Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com<mailto:leimaohui@cn.fujitsu.com>>

> +---

> + crypto/sha/asm/keccak1600-armv8.pl<http://keccak1600-armv8.pl> | 4 ++--

> + 1 file changed, 2 insertions(+), 2 deletions(-)

> +

> +diff --git a/crypto/sha/asm/keccak1600-armv8.pl<http://keccak1600-armv8.pl> b/crypto/sha/asm/keccak1600-armv8.pl<http://keccak1600-armv8.pl>

> +index dc72f18..6620690 100755

> +--- a/crypto/sha/asm/keccak1600-armv8.pl<http://keccak1600-armv8.pl>

> ++++ b/crypto/sha/asm/keccak1600-armv8.pl<http://keccak1600-armv8.pl>

> +@@ -731,7 +731,7 @@ $code.=<<___;

> +       blo     .Lprocess_block_ce

> +       ldr     d31,[$inp],#8           // *inp++

> + #ifdef        __AARCH64EB__

> +-      rev     v31.16b,v31.16b

> ++      rev64   v31.16b,v31.16b

> + #endif

> +       eor     $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b

> +       beq     .Lprocess_block_ce

> +@@ -740,7 +740,7 @@ ___

> + $code.=<<___;

> +       ldr     d31,[$inp],#8           // *inp++

> + #ifdef        __AARCH64EB__

> +-      rev     v31.16b,v31.16b

> ++      rev64   v31.16b,v31.16b

> + #endif

> +       eor     $A[4][4],$A[4][4],v31.16b

> +

> +--

> +2.7.4

> +

> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb<http://openssl_1.1.1c.bb> b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb<http://openssl_1.1.1c.bb>

> index 669b1a1..ec85ccd 100644

> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb<http://openssl_1.1.1c.bb>

> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb<http://openssl_1.1.1c.bb>

> @@ -16,6 +16,7 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz<http://www.openssl.org/source/openssl-$%7BPV%7D.tar.gz> \

>             file://0001-skip-test_symbol_presence.patch \

>             file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \

>             file://afalg.patch \

> +           file://0001-Fix-build-error-for-aarch64-big-endian.patch \

>             "

>

>  SRC_URI_append_class-nativesdk = " \

> --

> 2.7.4

>

>

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Alexander Kanavin June 14, 2019, 9:25 a.m.
Yes:
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status

Alex

On Fri, 14 Jun 2019 at 03:00, Lei, Maohui <leimaohui@cn.fujitsu.com> wrote:

> Hi, Alex
>
>
>
> I refered to the previous patches. Should the Upstream-Status be
> “Submitted” ?
>
>
>
>
>
> Best regards
>
> Lei
>
>
>
>
>
> *From:* Alexander Kanavin [mailto:alex.kanavin@gmail.com]
> *Sent:* Thursday, June 13, 2019 8:45 PM
> *To:* Burton, Ross
> *Cc:* Lei, Maohui/雷 茂慧; Hong Liu; OE-core
> *Subject:* Re: [OE-core] [PATCH] openssl: Fix a build bug on aarch64BE.
>
>
>
> Also if the patch is already submitted, the status should not be Pending.
>
>
>
> Alex
>
>
>
> On Thu, 13 Jun 2019 at 11:23, Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 13 Jun 2019 at 09:48, Lei Maohui <leimaohui@cn.fujitsu.com> wrote:
> >
> > From: Hong Liu <hongl.fnst@cn.fujitsu.com>
> >
> > Fix bug as following on aarch64BE:
> >
> > Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> >
> > Upstream-Status: Pending [https://github.com/openssl/openssl/pull/9151]
>
> This line ^^^
>
> > Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > ---
> >  ...01-Fix-build-error-for-aarch64-big-endian.patch | 41
> ++++++++++++++++++++++
> >  .../recipes-connectivity/openssl/openssl_1.1.1c.bb |  1 +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644
> meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> >
> > diff --git
> a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> > new file mode 100644
> > index 0000000..65ca02c
> > --- /dev/null
> > +++
> b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch
> > @@ -0,0 +1,41 @@
> > +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001
> > +From: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +Date: Thu, 13 Jun 2019 12:17:30 +0900
> > +Subject: [PATCH] Fix build error for aarch64 big endian.
> > +
> > +Modified rev to rev64, because rev only takes integer registers.
> > +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
> > +Otherwise, the following error will occur.
> > +
> > +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
> > +
>
> ^^ goes here.
>
> The upstream status is a property of the patch you're adding, not the
> commit message.
>
> > +Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com>
> > +---
> > + crypto/sha/asm/keccak1600-armv8.pl | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/crypto/sha/asm/keccak1600-armv8.pl b/crypto/sha/asm/
> keccak1600-armv8.pl
> > +index dc72f18..6620690 100755
> > +--- a/crypto/sha/asm/keccak1600-armv8.pl
> > ++++ b/crypto/sha/asm/keccak1600-armv8.pl
> > +@@ -731,7 +731,7 @@ $code.=<<___;
> > +       blo     .Lprocess_block_ce
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b
> > +       beq     .Lprocess_block_ce
> > +@@ -740,7 +740,7 @@ ___
> > + $code.=<<___;
> > +       ldr     d31,[$inp],#8           // *inp++
> > + #ifdef        __AARCH64EB__
> > +-      rev     v31.16b,v31.16b
> > ++      rev64   v31.16b,v31.16b
> > + #endif
> > +       eor     $A[4][4],$A[4][4],v31.16b
> > +
> > +--
> > +2.7.4
> > +
> > diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > index 669b1a1..ec85ccd 100644
> > --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> > @@ -16,6 +16,7 @@ SRC_URI = "
> http://www.openssl.org/source/openssl-${PV}.tar.gz \
> >             file://0001-skip-test_symbol_presence.patch \
> >
>  file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
> >             file://afalg.patch \
> > +           file://0001-Fix-build-error-for-aarch64-big-endian.patch \
> >             "
> >
> >  SRC_URI_append_class-nativesdk = " \
> > --
> > 2.7.4
> >
> >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
leimaohui June 17, 2019, 1:53 p.m.
This is a system generated Comment: Patch 162178 was automatically marked as superseded by patch 162234.