[meta-xfce] xfce4-settings: set default theme Adwaita

Submitted by Kang Kai on June 11, 2019, 8:15 a.m. | Patch ID: 162099

Details

Message ID 20190611081516.169741-1-kai.kang@windriver.com
State Accepted
Commit 6220a83db59698c114a98fa5235d0b7543c5da01
Headers show

Commit Message

Kang Kai June 11, 2019, 8:15 a.m.
From: Kai Kang <kai.kang@windriver.com>

The pre-configured default theme Xfce doesn't work as expected. For
example, no layout in start menu and applications' menu bar. And
GtkColorButton is blank in config tab page from xfce4-terminal -> Edit
-> Preference -> Colors.

So set Adwaita as default theme instead.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 .../files/0001-xsettings.xml-Set-default-themes.patch  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch b/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
index 67df05a79..0463d2ebd 100644
--- a/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
+++ b/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
@@ -9,6 +9,14 @@  Content-Transfer-Encoding: 8bit
 Upstram status:  Inappropriate [configuration]
 
 Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
+
+Theme Xfce doesn't work as expected. For example, no layout in start
+menu and applications' menu bar. And GtkColorButton is blank in config
+tab page from xfce4-terminal -> Edit -> Preference -> Colors.
+
+So use Adwaita as default theme instead.
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
 ---
  xfsettingsd/xsettings.xml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
@@ -23,7 +31,7 @@  index 65ba1ee..9efb3cd 100644
    <property name="Net" type="empty">
 -    <property name="ThemeName" type="empty"/>
 -    <property name="IconThemeName" type="empty"/>
-+    <property name="ThemeName" type="string" value="Xfce"/>
++    <property name="ThemeName" type="string" value="Adwaita"/>
 +    <property name="IconThemeName" type="string" value="Adwaita"/>
      <property name="DoubleClickTime" type="int" value="400"/>
      <property name="DoubleClickDistance" type="int" value="5"/>

Comments

Andreas Müller June 11, 2019, 9:14 a.m.
On Tue, Jun 11, 2019 at 10:15 AM <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> The pre-configured default theme Xfce doesn't work as expected. For
> example, no layout in start menu and applications' menu bar. And
> GtkColorButton is blank in config tab page from xfce4-terminal -> Edit
> -> Preference -> Colors.
>
> So set Adwaita as default theme instead.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
Had other issues and worked around by shipping a default
configuration. Had forgotten the patch added in 2012.

Thanks

Acked-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>  .../files/0001-xsettings.xml-Set-default-themes.patch  | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch b/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
> index 67df05a79..0463d2ebd 100644
> --- a/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
> +++ b/meta-xfce/recipes-xfce/xfce4-settings/files/0001-xsettings.xml-Set-default-themes.patch
> @@ -9,6 +9,14 @@ Content-Transfer-Encoding: 8bit
>  Upstram status:  Inappropriate [configuration]
>
>  Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> +
> +Theme Xfce doesn't work as expected. For example, no layout in start
> +menu and applications' menu bar. And GtkColorButton is blank in config
> +tab page from xfce4-terminal -> Edit -> Preference -> Colors.
> +
> +So use Adwaita as default theme instead.
> +
> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
>  ---
>   xfsettingsd/xsettings.xml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> @@ -23,7 +31,7 @@ index 65ba1ee..9efb3cd 100644
>     <property name="Net" type="empty">
>  -    <property name="ThemeName" type="empty"/>
>  -    <property name="IconThemeName" type="empty"/>
> -+    <property name="ThemeName" type="string" value="Xfce"/>
> ++    <property name="ThemeName" type="string" value="Adwaita"/>
>  +    <property name="IconThemeName" type="string" value="Adwaita"/>
>       <property name="DoubleClickTime" type="int" value="400"/>
>       <property name="DoubleClickDistance" type="int" value="5"/>
> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel