[warrior] dbus-test: Improve ptest dependencies dependencies

Submitted by Martin Jansa on June 9, 2019, 7:56 a.m. | Patch ID: 162066

Details

Message ID 20190609075658.688-1-Martin.Jansa@gmail.com
State warrior-next
Delegated to: Armin Kuster
Headers show

Commit Message

Martin Jansa June 9, 2019, 7:56 a.m.
From: Richard Purdie <richard.purdie@linuxfoundation.org>

The dbus-test package is empty, move its dependencies to the ${PN}-ptest
package. Also ensure that it doesn't depend on the empty ${PN} package
which is about to start causing image failures in the following commit.
In this case the correct dependency is dbus itself.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/dbus/dbus-test_1.12.12.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-core/dbus/dbus-test_1.12.12.bb b/meta/recipes-core/dbus/dbus-test_1.12.12.bb
index f4131926c2..486a996879 100644
--- a/meta/recipes-core/dbus/dbus-test_1.12.12.bb
+++ b/meta/recipes-core/dbus/dbus-test_1.12.12.bb
@@ -7,7 +7,6 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
 
 DEPENDS = "dbus glib-2.0"
 
-RDEPENDS_${PN} += "make"
 RDEPENDS_${PN}-dev = ""
 
 SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
@@ -78,6 +77,7 @@  do_install_ptest() {
         sed -i -e 's;@PTEST_PATH@;${PTEST_PATH};g'  ${D}${PTEST_PATH}/run-ptest
 }
 
-RDEPENDS_${PN}-ptest += "bash"
+RDEPENDS_${PN}-ptest += "bash make dbus"
+RDEPENDS_${PN}-ptest_remove = "${PN}"
 
 PRIVATE_LIBS_${PN}-ptest = "libdbus-1.so.3"

Comments

Armin Kuster June 9, 2019, 2:36 p.m.
On 6/9/19 12:56 AM, Martin Jansa wrote:
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> The dbus-test package is empty, move its dependencies to the ${PN}-ptest
> package. Also ensure that it doesn't depend on the empty ${PN} package
> which is about to start causing image failures in the following commit.
> In this case the correct dependency is dbus itself.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
got it
thanks
Armin
> ---
>  meta/recipes-core/dbus/dbus-test_1.12.12.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/dbus/dbus-test_1.12.12.bb b/meta/recipes-core/dbus/dbus-test_1.12.12.bb
> index f4131926c2..486a996879 100644
> --- a/meta/recipes-core/dbus/dbus-test_1.12.12.bb
> +++ b/meta/recipes-core/dbus/dbus-test_1.12.12.bb
> @@ -7,7 +7,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>  
>  DEPENDS = "dbus glib-2.0"
>  
> -RDEPENDS_${PN} += "make"
>  RDEPENDS_${PN}-dev = ""
>  
>  SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
> @@ -78,6 +77,7 @@ do_install_ptest() {
>          sed -i -e 's;@PTEST_PATH@;${PTEST_PATH};g'  ${D}${PTEST_PATH}/run-ptest
>  }
>  
> -RDEPENDS_${PN}-ptest += "bash"
> +RDEPENDS_${PN}-ptest += "bash make dbus"
> +RDEPENDS_${PN}-ptest_remove = "${PN}"
>  
>  PRIVATE_LIBS_${PN}-ptest = "libdbus-1.so.3"