devtool: build: add deploy to the tasks run for devtool build

Submitted by Jaewon Lee on June 7, 2019, 10:17 p.m. | Patch ID: 162051

Details

Message ID 1559945821-18316-1-git-send-email-jaewon.lee@xilinx.com
State Master Next
Commit f70c928951125d4a04978561c7ea5e807f18cdbc
Headers show

Commit Message

Jaewon Lee June 7, 2019, 10:17 p.m.
Right now `devtool build` runs populate_sysroot and packagedata tasks.
Adding deploy to this list so that the newly built artifacts are
available in the deploy directory.

Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>

[YOCTO #13382]

Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
---
 scripts/lib/devtool/build.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/scripts/lib/devtool/build.py b/scripts/lib/devtool/build.py
index 7543398..aff5710 100644
--- a/scripts/lib/devtool/build.py
+++ b/scripts/lib/devtool/build.py
@@ -37,7 +37,7 @@  def _set_file_values(fn, values):
     return updated
 
 def _get_build_tasks(config):
-    tasks = config.get('Build', 'build_task', 'populate_sysroot,packagedata').split(',')
+    tasks = config.get('Build', 'build_task', 'deploy,populate_sysroot,packagedata').split(',')
     return ['do_%s' % task.strip() for task in tasks]
 
 def build(args, config, basepath, workspace):

Comments

Richard Purdie June 8, 2019, 12:15 p.m.
On Fri, 2019-06-07 at 15:17 -0700, Jaewon Lee wrote:
> Right now `devtool build` runs populate_sysroot and packagedata
> tasks.
> Adding deploy to this list so that the newly built artifacts are
> available in the deploy directory.
> 
> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
> 
> [YOCTO #13382]
> 
> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
> ---
>  scripts/lib/devtool/build.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/devtool/build.py
> b/scripts/lib/devtool/build.py
> index 7543398..aff5710 100644
> --- a/scripts/lib/devtool/build.py
> +++ b/scripts/lib/devtool/build.py
> @@ -37,7 +37,7 @@ def _set_file_values(fn, values):
>      return updated
>  
>  def _get_build_tasks(config):
> -    tasks = config.get('Build', 'build_task',
> 'populate_sysroot,packagedata').split(',')
> +    tasks = config.get('Build', 'build_task',
> 'deploy,populate_sysroot,packagedata').split(',')
>      return ['do_%s' % task.strip() for task in tasks]
>  
>  def build(args, config, basepath, workspace):

This frustrates me a bit.

The key question you have to ask here is "What happens for recipes that
don't have a do_deploy task?".

The answer is it breaks:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/506

*Please*, when sending devtool patches, test with:

oe-selftest -r devtool

Cheers,

Richard
Jaewon Lee June 8, 2019, 3:34 p.m.
Sorry about that Richard 
Will be sure to test with that 

Thanks,
Jaewon


> On Jun 8, 2019, at 5:15 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
>> On Fri, 2019-06-07 at 15:17 -0700, Jaewon Lee wrote:
>> Right now `devtool build` runs populate_sysroot and packagedata
>> tasks.
>> Adding deploy to this list so that the newly built artifacts are
>> available in the deploy directory.
>> 
>> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
>> 
>> [YOCTO #13382]
>> 
>> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
>> ---
>> scripts/lib/devtool/build.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/scripts/lib/devtool/build.py
>> b/scripts/lib/devtool/build.py
>> index 7543398..aff5710 100644
>> --- a/scripts/lib/devtool/build.py
>> +++ b/scripts/lib/devtool/build.py
>> @@ -37,7 +37,7 @@ def _set_file_values(fn, values):
>>     return updated
>> 
>> def _get_build_tasks(config):
>> -    tasks = config.get('Build', 'build_task',
>> 'populate_sysroot,packagedata').split(',')
>> +    tasks = config.get('Build', 'build_task',
>> 'deploy,populate_sysroot,packagedata').split(',')
>>     return ['do_%s' % task.strip() for task in tasks]
>> 
>> def build(args, config, basepath, workspace):
> 
> This frustrates me a bit.
> 
> The key question you have to ask here is "What happens for recipes that
> don't have a do_deploy task?".
> 
> The answer is it breaks:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/506
> 
> *Please*, when sending devtool patches, test with:
> 
> oe-selftest -r devtool
> 
> Cheers,
> 
> Richard
> 
> 
> 
> 
>